From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 6204C5A8A
 for <dev@dpdk.org>; Wed, 25 Feb 2015 12:22:03 +0100 (CET)
Received: by wghn12 with SMTP id n12so2994061wgh.1
 for <dev@dpdk.org>; Wed, 25 Feb 2015 03:22:03 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=r8nfpuwhpwv1Asj/GlSYAxEsH2Ba0K4rD6JehR8itq8=;
 b=GzwzG5Y8Q0jEi2PkiO85onLeRfMmRtcbsMwxbJPLo4Fj/hiC2H/cDXi7MhpS7JV38j
 jev6mT9iVSB70KliMP8kBDKqyuPHlYa1RPSIrgmZI0w4ZyuredJyhUhLblnmuNpzDNuz
 +VQQo33FVCOP25aIMEAONAFeDnM389KUaqxFDPnBrl3b1W+0yvG+56C60A+eN7Kmh26t
 ibY+Vm5BbxlB3lPGEBzHLgpI4y5v3W8AG9ofv64LR9mXXoIE5xHaa7GccXLzpcz3dcY3
 CuZ5ClLgkgFLLssV1AHMwsU8G/8/71DOE9/RkIinAzikqn94psMvQv1i2wSfUUGBgpww
 xdqw==
X-Gm-Message-State: ALoCoQmVij04kJMCC+x2XsrN/jOvmTvwP7TgI5bmlkq2MNpnywaMO4NFyuf9NbUH0Ps2u8SZ92A7
X-Received: by 10.194.23.39 with SMTP id j7mr5315374wjf.9.1424863323233;
 Wed, 25 Feb 2015 03:22:03 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id 18sm64397862wjr.46.2015.02.25.03.22.01
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 25 Feb 2015 03:22:02 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Date: Wed, 25 Feb 2015 12:21:29 +0100
Message-ID: <2987764.cYYQsyCFG8@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1424837093-5661-13-git-send-email-mukawa@igel.co.jp>
References: <1424060073-23484-2-git-send-email-mukawa@igel.co.jp>
 <1424837093-5661-1-git-send-email-mukawa@igel.co.jp>
 <1424837093-5661-13-git-send-email-mukawa@igel.co.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v14 12/13] eal/pci: Add
	rte_eal_dev_attach/detach() functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2015 11:22:03 -0000

2015-02-25 13:04, Tetsuya Mukawa:
> --- a/lib/librte_eal/common/eal_common_dev.c
> +++ b/lib/librte_eal/common/eal_common_dev.c
> @@ -32,10 +32,13 @@
>   *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>   */
>  
> +#include <stdio.h>
> +#include <limits.h>
>  #include <string.h>
>  #include <inttypes.h>
>  #include <sys/queue.h>
>  
> +#include <rte_ethdev.h>
>  #include <rte_dev.h>
>  #include <rte_devargs.h>

No, you must not include ethdev in EAL.
The ethdev layer is by design on top of EAL.
Maxime already asked why you did it. He was implicitly asking to remove it.
You said that you are calling ethdev_is_detachable() but you should
call a function eal_is_detachable() or something like that.
The detachable state must be only device-related, i.e. in EAL.
The ethdev API is only a wrapper (with port id) in such case.

> --- a/lib/librte_eal/linuxapp/eal/Makefile
> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> @@ -45,6 +45,7 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
>  CFLAGS += -I$(RTE_SDK)/lib/librte_ring
>  CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
>  CFLAGS += -I$(RTE_SDK)/lib/librte_malloc
> +CFLAGS += -I$(RTE_SDK)/lib/librte_mbuf

By removing ethdev dependency, you can remove this ugly mbuf dependency.

Thanks Tetsuya