From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 12859CCB6 for ; Fri, 17 Jun 2016 12:30:35 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id a66so94929701wme.0 for ; Fri, 17 Jun 2016 03:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Uy+IBSDxCVSw95gZF8Vz06ZFKeViCDBLijMU30fKGDI=; b=G3aY6Sfj6nFsEyyrv1R0Y/I5cvF8Ljs2KL0lctlx3X7R5cQLVNIR2YseaMFZSE8AYI YS5Wd//BThpuAnZkKRdHtJiPGHrwXVaGiJhtqKoAC9hdD+/e/dv8VyLy4Fzg8TiBXNLi Wd42hU22VQubOTvMMvb/UrlIxEWkNbiI9S4p++yTW1Gn6ZGDzU+cj0KjTzoeU/X7HvUO aCYz5cGAP/yrGmELkpUmE06IBw5W3JBRP37t6jLbhnwIRN7KWQ4D9O82wnZmK8/OqxcE yv9+gKGZp/FAd2MpyFrzS9HPIoSW515bwA7aPmP0gRe3UX1sqWdkF6Ca7HiPGp4wmKo8 xfyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Uy+IBSDxCVSw95gZF8Vz06ZFKeViCDBLijMU30fKGDI=; b=OZRNyZOFO+AY35I8w+kJlCMO+mOpQ6s/7d0BxuKpYArkb7/kKjHTHN2SF6+dJxyQRn 7JsVCNw5pANzRS+id3unz6Au0PYMgDmdZ/Z9IbD1wWsEVg89U8kMEUwXOJLktHRivA/5 2/9gE4j+wkZZEU90r15JpNJ2w6hoZLiJxsXmtkedcCNutGVFbyaL6b2urXfRsHBhpDMm GOEtVPf3V4pmZ636sQnYU8nKas+XBEvBU3rKVaofA6GrTjq3VmR8865HjgqU3nvugM+w j+NpFVz3gFSOcMCcOWxkMVYEHQuZEnFKPB0Tp6C7a0XQtzoHPZ06qLSNua129iA2ZqfS Volw== X-Gm-Message-State: ALyK8tIhV5Ne3u6yhDdzzyG63FWubQUbwqFjBT42vxE0HVIoHP2DdIWZklN/1HqPXxHFkFFN X-Received: by 10.28.4.140 with SMTP id 134mr20499149wme.91.1466159434720; Fri, 17 Jun 2016 03:30:34 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id h8sm48087121wjg.9.2016.06.17.03.30.33 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 03:30:33 -0700 (PDT) From: Thomas Monjalon To: Jianbo Liu Cc: dev@dpdk.org, Jerin Jacob Date: Fri, 17 Jun 2016 12:30:32 +0200 Message-ID: <2989572.Qmv8XzlVsK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2611917.yjRp4jXU2P@xps13> References: <1462869064-9423-1-git-send-email-jianbo.liu@linaro.org> <2611917.yjRp4jXU2P@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] arm64: change rte_memcpy to inline function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 10:30:35 -0000 2016-05-19 17:56, Thomas Monjalon: > 2016-05-19 21:48, Jianbo Liu: > > On 13 May 2016 at 23:49, Thomas Monjalon wrote: > > > 2016-05-10 14:01, Jianbo Liu: > > >> Other APP may call rte_memcpy by function pointer, > > >> so change it to an inline function. > > > > > > Any example in mind? > > > > > It's for ODP-DPDK. > > Given that ODP is open (dataplane), you should also consider ppc64 and tile. > > > >> --- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h > > >> +++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h > > >> -#define rte_memcpy(d, s, n) memcpy((d), (s), (n)) > > >> +static inline void * > > >> +rte_memcpy(void *dst, const void *src, size_t n) > > >> +{ > > >> + return memcpy(dst, src, n); > > >> +} > > > > > > It has no sense if other archs (arm32, ppc64, tile) are not updated. > > > > > But it also an inline function on x86. > > In x86, it was implemented as a function because there is some code. > If you want to make sure it is always a function, even in the case > of just calling memcpy from libc, you should put a doxygen comment in > the generic part and adapt every archs. no news? a v2 would be welcome