From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BF754A053A;
Wed, 5 Aug 2020 16:14:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 9F9BE2C28;
Wed, 5 Aug 2020 16:14:44 +0200 (CEST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0A31B2BB5;
Wed, 5 Aug 2020 16:14:43 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id 86DA95C0165;
Wed, 5 Aug 2020 10:14:42 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute7.internal (MEProxy); Wed, 05 Aug 2020 10:14:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
ziA3arth8X6HwAy1I9d4jS9D4ob/2ZneQCuP5v1FYmE=; b=RG1im3IAZaGr3lTZ
II8dL7JQcrmusrtwm2D2TRGIzuGTXpHIyo2vvo9709/UZafHDUxVIp1UseQnZG3W
fYsnUguiVcAqUDLxD2NXwCOUkQFNQvTEzUxv9SCgKK3OC/O5cMuVsQXh7wWV8UPQ
C6h5ctzNqHlUtYINcg6+AHE8Z/ZBBH4mIMOsN3KZSN3o/fk3Mn/fPDon1jPvPgPF
I/mg9N/eP4BUW7uaneKi9UUGTF0xXUtHBhxF6Z4thoyhq+RUcS97R9puX+s2LLE3
aEjiAh0rsRR+4QB1syxGr5jf30GhlTOnESIPZxYLrGBKHKCVujUvjDaZaGbgLOYI
jAGlDg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=ziA3arth8X6HwAy1I9d4jS9D4ob/2ZneQCuP5v1FY
mE=; b=RAhnSOsSiHbqpK+e+J/o0oB+Q58OCa5w7pYDG1o4A5rAIygDYzEtNKgKS
LW2oomz2a/QWqkSGgho93OWUmh4mD336wZeFv8bNZDZGu9ilu3bi5wUx9f9zLkH5
NrEAb7895LyANyggmuafMx8FCYEFhQLcRIlAfPomqsgcBjEzNtWzZanjhvZumCE4
8VvVEtOfq3zuJeJZFf0uYbBpJsBnguxoZzhMGd/x8yB4xfeoUhiBNM3QcIsvUBbK
EKx6UrgyeG5WKyIgq/ZjI+lwjC9QpEyMNu0QfqJXeZiu0NMlPueHuLC/rDqfdMpD
XJq5pwWwdwAfCbLn8faRtCOtG7WTQ==
X-ME-Sender: <xms:0r4qX6tX02X4btY-RlmoG8cKfaOZM5dGcDnxmgjDM2VB2ah-DCoh3Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdejjecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:0r4qX_cRWp_0ooEqcMxcqCIcpjjs3sRbA1Z7Nqhxd-QpVLifHjeiPw>
<xmx:0r4qX1zokX77Gv52V2pMm8qk1ur6NwQwIWrU2D2QGk6h5P-BAXpLeg>
<xmx:0r4qX1MDljzV7rNP-GDTQ9ipzkvMfM08i6dW2djOPgNmYWCA_KiqDQ>
<xmx:0r4qX8KU3gkxqWVSjc2rxQ77q62wnvI0oXjQw9nejE5XiZcCxH9-Mw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 63B58328005D;
Wed, 5 Aug 2020 10:14:41 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Dekel Peled <dekelp@mellanox.com>
Cc: matan@mellanox.com, viacheslavo@mellanox.com, rasland@mellanox.com,
stable@dpdk.org, dev@dpdk.org
Date: Wed, 05 Aug 2020 16:14:40 +0200
Message-ID: <2991040.2UnnyQe84E@thomas>
In-Reply-To: <70ff61d3d8431aeb73ee5c5c23c87e525dc221ec.1596446316.git.dekelp@mellanox.com>
References: <70ff61d3d8431aeb73ee5c5c23c87e525dc221ec.1596446316.git.dekelp@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix number of
retries for UAR allocation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
03/08/2020 11:18, Dekel Peled:
> Previous patch added definition of number of retries for UAR allocation.
> This value is adequate for x86 systems with 4K pages.
> On power9 system with 64K pages the required value is 32.
> This patch updates the defined value from 2 to 32.
What about bigger pages?
> Fixes: a0bfe9d56f74 ("net/mlx5: fix UAR memory mapping type")
> Cc: stable@dpdk.org
No need of stable@dpdk.org because it was introduced in this release.
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_defs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
> index e5f7acc..c26d5a2 100644
> --- a/drivers/net/mlx5/mlx5_defs.h
> +++ b/drivers/net/mlx5/mlx5_defs.h
> @@ -202,9 +202,7 @@
> * UAR base address if UAR was not the first object in the UAR page.
> * It caused the PMD failure and we should try to get another UAR
> * till we get the first one with non-NULL base address returned.
> - * Should follow the rdma_core internal (not exported) definition
> - * MLX5_NUM_NON_FP_BFREGS_PER_UAR.
> */
> -#define MLX5_ALLOC_UAR_RETRY 2
> +#define MLX5_ALLOC_UAR_RETRY 32
It is missing a comment to explain the calculation with 64K page.