From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] testpmd: Simplify logic in error branch
Date: Thu, 19 Jun 2014 01:06:59 +0200 [thread overview]
Message-ID: <2992380.R7eycFGcZK@xps13> (raw)
In-Reply-To: <1403030472-25060-1-git-send-email-bruce.richardson@intel.com>
> Simplifiy the logic in the error checking branch. Rather than having a
> single error branch which checked both RX and TX conditions and made
> extensive use of the ? operator, move the error checking explicitly into
> the RX and TX individual branches.
>
> The original code caused compilation issues when attempting compilation
> with clang on BSD, due to type mismatches. This change fixes the issues
> while making the code easier to read and maintain overall.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied for version 1.7.0.
Thanks
--
Thomas
prev parent reply other threads:[~2014-06-18 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 18:41 Bruce Richardson
2014-06-18 23:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2992380.R7eycFGcZK@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).