From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id E23462A7 for ; Thu, 19 Jun 2014 01:06:45 +0200 (CEST) Received: by mail-we0-f177.google.com with SMTP id u56so1568411wes.36 for ; Wed, 18 Jun 2014 16:07:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=OjZe4atOKNDXVTTczyeX3IJCyFnfrwY3kULvFu893CE=; b=PmLAF+Lc1m9+VLyOfOeV1S42fysTgxXetvKmC+HEilAdnvctRa7/4048chA7yMQlAU 3wDJ4K69nPHk6nagBFS3JvZ0QXHk8eSErY1ac5LK9RHiJhoZ/BPfC4Oa3HV9faTM1Lq8 IaXiqpuL8O3HfnK7PnRZDnScBliIFAs0s/iYADoHjK2mA/hcJ+dpTYU4WMTjo6rxQORB VNLD/H9gX5E5rvHM44oSrtrGhhnG5vh/m5lSmzNatEXj71D9wc9MmzLFlvN6aeBbOS9a sPwJnQBX8qi9lEKGwDGKymCXL3zROBKUhsoq+gumF/vocZxxNfOWh7w0hNOoeSS6qqkl kP+g== X-Gm-Message-State: ALoCoQmr5VUGaScvE/iMoJGXH0VPxEDTiG1cAlALZgyEWx3yvF1G5vaKt+ETd9aaYn6QwDz3HVq3 X-Received: by 10.194.186.178 with SMTP id fl18mr855399wjc.83.1403132822535; Wed, 18 Jun 2014 16:07:02 -0700 (PDT) Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr. [80.236.123.96]) by mx.google.com with ESMTPSA id e11sm6058116wiw.19.2014.06.18.16.07.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jun 2014 16:07:01 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 19 Jun 2014 01:06:59 +0200 Message-ID: <2992380.R7eycFGcZK@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1403030472-25060-1-git-send-email-bruce.richardson@intel.com> References: <1403030472-25060-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] testpmd: Simplify logic in error branch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2014 23:06:46 -0000 > Simplifiy the logic in the error checking branch. Rather than having a > single error branch which checked both RX and TX conditions and made > extensive use of the ? operator, move the error checking explicitly into > the RX and TX individual branches. > > The original code caused compilation issues when attempting compilation > with clang on BSD, due to type mismatches. This change fixes the issues > while making the code easier to read and maintain overall. > > Signed-off-by: Bruce Richardson Acked-by: Thomas Monjalon Applied for version 1.7.0. Thanks -- Thomas