From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 189F5AA97 for ; Fri, 27 Apr 2018 16:22:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B62B320CA5; Fri, 27 Apr 2018 10:22:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 27 Apr 2018 10:22:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=WKa0akxTSyOnwbv1Fb7dau3qoJ 2ix6HF3SwpKdEZGRc=; b=hMTiJctcIFmaMk9pH6oANmic5Itije+9E09C2y7c+t GVYCL6v2wr2vL1BSxxVzhekhfrLdkAWByYge3nPDkkbrTMJ/bl1tyLBVO9LQiScb IWq8eN9HhLjtttFRiRbzgIH6dU0KvyD13mtGZWaoAnha3OKJCVy3zezoCswzGuGv o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=WKa0ak xTSyOnwbv1Fb7dau3qoJ2ix6HF3SwpKdEZGRc=; b=HFydyd70uP1Ocjz5mxwqW/ pnWVIrrVljZaUZACjb36GLsCxG2GEQW6TVLD+FuDbX+Eigyt4+bWAzlmKRcMOIak TPFe8KtubWDh+FjQMf63dkBYKhWGShP66RLJg9tNcOVn/WCPt4bEns/SYlAP51mr C74zBe97/AmA+ilUVIUedMg4AVA5SaYHI/BWhYhZKzZl8G8AKOKP0a5dn/s2o6NW CtadHRS+dQoTOcXC9VsiwXrkJnPe/5dgYuXVLjfaFFXY5lnGpv05LE/yUjDf8TOA ki7WnoUIW5ZI5FjvtALTrbdr6pXkuLJHif1dvwWjJC0Ex7HaCuq+SbBdvmNokIPw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8688CE509E; Fri, 27 Apr 2018 10:22:10 -0400 (EDT) From: Thomas Monjalon To: Arnon Warshavsky Cc: dev@dpdk.org, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Date: Fri, 27 Apr 2018 16:22:09 +0200 Message-ID: <2992884.f5kbt66Nfe@xps> In-Reply-To: <1524723664-30510-1-git-send-email-arnon@qwilt.com> References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 14:22:13 -0000 26/04/2018 08:20, Arnon Warshavsky: > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. > > This patch modifies the majority of rte_panic calls > under lib and drivers, and replaces them with a log message > and an error return code according to context, > that can be propagated up the call stack. > > - Focus was given to the dpdk initialization path > - Some of the panic calls within drivers were left in place where > the call is from within an interrupt or calls that are > on the data path,where there is no simple applicative > route to propagate the error to temination. > These should be handled by the driver maintainers.. > - local void functions with no api were changed to retrun a value > where needed > - No change took place in example and test files > - No change took place for debug assertions calling panic > - A new function was added to devtools/checkpatches.sh > in order to prevent new additions of calls to rte_panic > under lib and drivers. > > Keep calm and don't panic What is the status of this patchset? It seems not ready for RC1 (today). I don't want to push it in RC2 because it changes too many things. So it's today or wait for 18.08. What do you think? The last patch for check tooling can be separated and pushed at anytime.