From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DA06CA0093;
	Fri, 22 Apr 2022 05:56:04 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8409F40042;
	Fri, 22 Apr 2022 05:56:04 +0200 (CEST)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id B354640040
 for <dev@dpdk.org>; Fri, 22 Apr 2022 05:56:02 +0200 (CEST)
Received: from kwepemi500011.china.huawei.com (unknown [172.30.72.55])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kl0r76B0RzFps9;
 Fri, 22 Apr 2022 11:53:27 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (7.193.23.242) by
 kwepemi500011.china.huawei.com (7.221.188.124) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.24; Fri, 22 Apr 2022 11:56:00 +0800
Received: from [10.67.103.231] (10.67.103.231) by
 kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.24; Fri, 22 Apr 2022 11:55:59 +0800
Message-ID: <2994c7eb-7ef4-d82d-0a49-ab3c9c8b675e@huawei.com>
Date: Fri, 22 Apr 2022 11:55:59 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
From: "lihuisong (C)" <lihuisong@huawei.com>
Subject: Question about flow_type_rss_offloads in rte_eth_dev_info
To: "dev@dpdk.org" <dev@dpdk.org>
CC: Thomas Monjalon <thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,
 huangdaode <huangdaode@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
 kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi, all.

The RTE_ETH_FLOW_XXX macros, are used to display supported flow types 
for PMD
based on the rte_eth_dev_info.flow_type_rss_offloads in the 
port_infos_display() of
testpmd.

And PMD assigns RSS offload capability bit, like RTE_ETH_RSS_XXX, to 
this field.
The usage of RTE_ETH_RSS_XXX macros are described as follows in:
/*
  * Below macros are defined for RSS offload types, they can be used to
  * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types.
  */
#define RTE_ETH_RSS_IPV4               RTE_BIT64(2)

But RTE_ETH_FLOW_MAX is 24, and the number of RTE_ETH_FLOW_XXX micro far 
less than
the number of RTE_ETH_RSS_XXX. If PMD sets RSS offload capability bit 
out range of
RTE_ETH_FLOW_XXX, like RTE_ETH_RSS_L3_SRC_ONLY, to this field, testpmd 
will display
"user defined 63" when run 'show port info 0'. This is a problem that I 
have now.

On the other hand, rx_adv_conf.rte_eth_rss_conf.rss_hf from App must be 
within the
rte_eth_dev_info.flow_type_rss_offloads in dev_configure.

To sum up, I'm a little confused right now.
How should PMD populate the field "flow_type_rss_offloads" in struct 
rte_eth_dev_info?