From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@xilinx.com>
Cc: longli@microsoft.com, David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, Ajay Sharma <sharmaajay@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [Patch v4 15/17] net/mana: add function to send packets
Date: Wed, 24 Aug 2022 15:38:38 +0200 [thread overview]
Message-ID: <2995953.CbtlEUcBR6@thomas> (raw)
In-Reply-To: <3a64804d-3316-3042-4204-ca299d583749@xilinx.com>
22/08/2022 17:09, Ferruh Yigit:
> On 7/9/2022 12:49 AM, longli@linuxonhyperv.com wrote:
> > + for (uint16_t seg_idx = 0; seg_idx < m_pkt->nb_segs; seg_idx++) {
>
> This is C99 feature and we tend to not use it BUT,
>
> Thomas, David,
>
> In the past there were c89/c90/ansi code in DPDK, but as far as I can
> see no more left.
>
> Is there anything that prevents us using C99 features, like variable in
> the for loop, I think it is usefull that it reduces the scope and makes
> code more readable, etc...
I agree that variable declaration in the "for" loop is nice.
I would be very cautious to test that all compilers used around
don't emit a warning. If it passes the tests, I think we can accept
and update the coding style documentation to make it officially allowed.
next prev parent reply other threads:[~2022-08-24 13:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 23:49 [Patch v4 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD longli
2022-07-08 23:49 ` [Patch v4 01/17] net/mana: add basic driver, build environment and doc longli
2022-08-22 15:03 ` Ferruh Yigit
2022-08-22 15:07 ` Ferruh Yigit
2022-08-22 18:27 ` Long Li
2022-08-29 7:58 ` Thomas Monjalon
2022-08-29 8:51 ` Ferruh Yigit
2022-08-29 9:20 ` Thomas Monjalon
2022-09-07 23:38 ` Long Li
2022-07-08 23:49 ` [Patch v4 02/17] net/mana: add device configuration and stop longli
2022-07-08 23:49 ` [Patch v4 03/17] net/mana: add function to report support ptypes longli
2022-07-08 23:49 ` [Patch v4 04/17] net/mana: add link update longli
2022-07-08 23:49 ` [Patch v4 05/17] net/mana: add function for device removal interrupts longli
2022-07-08 23:49 ` [Patch v4 06/17] net/mana: add device info longli
2022-07-08 23:49 ` [Patch v4 07/17] net/mana: add function to configure RSS longli
2022-07-08 23:49 ` [Patch v4 08/17] net/mana: add function to configure RX queues longli
2022-07-08 23:49 ` [Patch v4 09/17] net/mana: add function to configure TX queues longli
2022-07-08 23:49 ` [Patch v4 10/17] net/mana: implement memory registration longli
2022-07-08 23:49 ` [Patch v4 11/17] net/mana: implement the hardware layer operations longli
2022-08-22 15:08 ` Ferruh Yigit
2022-08-22 18:28 ` Long Li
2022-07-08 23:49 ` [Patch v4 12/17] net/mana: add function to start/stop TX queues longli
2022-07-08 23:49 ` [Patch v4 13/17] net/mana: add function to start/stop RX queues longli
2022-07-08 23:49 ` [Patch v4 14/17] net/mana: add function to receive packets longli
2022-07-08 23:49 ` [Patch v4 15/17] net/mana: add function to send packets longli
2022-08-22 15:09 ` Ferruh Yigit
2022-08-24 13:38 ` Thomas Monjalon [this message]
2022-07-08 23:49 ` [Patch v4 16/17] net/mana: add function to start/stop device longli
2022-07-08 23:49 ` [Patch v4 17/17] net/mana: add function to report queue stats longli
2022-08-22 15:08 ` Ferruh Yigit
2022-08-22 18:35 ` Long Li
2022-08-22 14:59 ` [Patch v4 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD Ferruh Yigit
2022-08-22 17:07 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2995953.CbtlEUcBR6@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).