From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CADAFA0543; Wed, 24 Aug 2022 15:38:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EF6040DDE; Wed, 24 Aug 2022 15:38:42 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id E9D434067B; Wed, 24 Aug 2022 15:38:40 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 36B285C012B; Wed, 24 Aug 2022 09:38:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 24 Aug 2022 09:38:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1661348320; x= 1661434720; bh=wssV/BeAjbtdQ9S6rQnUTM1ArNrT2giOjON84abJz7c=; b=k 5TQwbLmqjviKPH4aQbEuVyrZiEnKuspSNJlrbGamOwlzoRUx/DiTxoxaaPMPT33l OJuCjR+MLz16NPFVhv5TG5cdpH6ZXbG/uSl4lO15ChnML40GDFEQezaGuw7d3B3p o27d7yzcdEK3fZpFigGce5tD5zvecNfCCaVkG3473FBXG+1uwIYGGSYLq6uKwbtP Yd7/380xqaGORG2PFuAfaYVbRo/wa99TRle5NjUqM5zubxvGKAYleE886HJVsSvb +KXAJPjFAQJMOdmIz6maCvpZ5Vr0BIceJ5ILgm464ZwhlbHPAcI+IOkM3yNsp2Au qdc+eNubPMZk9pCPgrIcw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661348320; x= 1661434720; bh=wssV/BeAjbtdQ9S6rQnUTM1ArNrT2giOjON84abJz7c=; b=F F2gaV8J7aYpi9nAYfwwdDm+DBKuK8FrR27xYBv0gQYuC5t8JPKsbo21InnULe1E9 SuYOw0lmIPRtOYz1hnM9eKxlAgCuRghrogK5xd9K1zrv16e5S9WRMDHJ32GuwJZa RCWMWdlPhYDhS+pHzKMN68fYFpy3mlXnJs/XbYb28T+q9o3gEMf3WKTdolBy5dBe oL2kCA1Fv0abGiTyz/n4NXzThEdFP3c0UiAQzl8sJxWqGFZFxp67gyzMzAWOnhq2 uRyCzwFfvP72ESPEWOzdu3ty+XLFtrDGvrGaackREzNNLdGMu5dysz7CaZuaryfT KZGWZ/nDS2IQ1aHZhTIWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejuddgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Aug 2022 09:38:39 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: longli@microsoft.com, David Marchand , dev@dpdk.org, Ajay Sharma , Stephen Hemminger , "techboard@dpdk.org" Subject: Re: [Patch v4 15/17] net/mana: add function to send packets Date: Wed, 24 Aug 2022 15:38:38 +0200 Message-ID: <2995953.CbtlEUcBR6@thomas> In-Reply-To: <3a64804d-3316-3042-4204-ca299d583749@xilinx.com> References: <1657324171-31369-1-git-send-email-longli@linuxonhyperv.com> <1657324171-31369-16-git-send-email-longli@linuxonhyperv.com> <3a64804d-3316-3042-4204-ca299d583749@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/08/2022 17:09, Ferruh Yigit: > On 7/9/2022 12:49 AM, longli@linuxonhyperv.com wrote: > > + for (uint16_t seg_idx = 0; seg_idx < m_pkt->nb_segs; seg_idx++) { > > This is C99 feature and we tend to not use it BUT, > > Thomas, David, > > In the past there were c89/c90/ansi code in DPDK, but as far as I can > see no more left. > > Is there anything that prevents us using C99 features, like variable in > the for loop, I think it is usefull that it reduces the scope and makes > code more readable, etc... I agree that variable declaration in the "for" loop is nice. I would be very cautious to test that all compilers used around don't emit a warning. If it passes the tests, I think we can accept and update the coding style documentation to make it officially allowed.