From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 0631B7E75 for ; Thu, 13 Nov 2014 22:20:35 +0100 (CET) Received: by mail-wi0-f171.google.com with SMTP id r20so919276wiv.4 for ; Thu, 13 Nov 2014 13:30:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=gIWwoi+dWDaUcwDAX4kF+DxwhiiLhsFXypiOkslrTGg=; b=aqM1VXwJvjdb9Z9EPCGED2Jr23MVtqY9Mklo6xsCeombAHYk1rr7jJd5luSVNxMQW0 EKFLIe+wSQo4WrtY0bnOBaobCog6Zh1dA4st+ZltLQRpF4G7FKbYay/SI0rbD5bNlF5N ZN0eQW+jVmSraCWU9RZM3rASOvwONd9TdYzj/9tveaurs/ba2mEGpFrxtusntTK8fOy+ YDaHs20H4NuP4+EtWzeUMi3GlI9nGfWTl2UVEw0YIjUdnnheG2KF1wS2piC/CQ2auyyR XOHrAoE47uEUbM/Q9TTPiPnH8Q9lh6ofthD4fV/xB9kgPb/heSaApp2gWTJI2P7FONBE eHTA== X-Gm-Message-State: ALoCoQlBdP/1CPyaJEswPdazZXxAl+0UN7Dmh4yEP915vBeTwtNu2Tcrxj37Yo34Iube0Z8aey6/ X-Received: by 10.180.79.169 with SMTP id k9mr1951499wix.34.1415914235248; Thu, 13 Nov 2014 13:30:35 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id cu9sm37083546wjb.0.2014.11.13.13.30.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 13:30:34 -0800 (PST) From: Thomas Monjalon To: "Pattan, Reshma" Date: Thu, 13 Nov 2014 22:30:16 +0100 Message-ID: <2996275.IBF3pFpS8C@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1413554380-22809-1-git-send-email-reshma.pattan@intel.com> <1415029784-16638-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7] distributor_app: new sample app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Nov 2014 21:20:35 -0000 Hi Reshma, > > From: Reshma Pattan > > > > A new sample app that shows the usage of the distributor library. This > > app works as follows: > > > > * An RX thread runs which pulls packets from each ethernet port in turn > > and passes those packets to worker using a distributor component. > > * The workers take the packets in turn, and determine the output port > > for those packets using basic l2forwarding doing an xor on the source > > port id. > > * The RX thread takes the returned packets from the workers and enqueue > > those packets into an rte_ring structure. > > * A TX thread pulls the packets off the rte_ring structure and then > > sends each packet out the output port specified previously by the worker > > * Command-line option support provided only for portmask. > > > > v5 change: > > * Handled gracefull shutdown of rx and tx threads upon SIGINT. > > > > v6 change: > > * modified graceful shutdown logic to handle all threads upon SIGINT > > * removed call to rte_eal_pci_probe() > > * added seperate print_stats function > > > > v7 change: > > * passing NULL as rxconf/txconf parameter for rx/tx queue setup > > * removed zero-ed fields from port conf structure > > * fixed style related comments > > > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Reshma Pattan > > Acked-by: Pablo de Lara Before applying this patch, I have 2 comments: - Other examples directories don't have _app suffix. - checkpatch reports "switch and case should be at the same indent" If you agree I will fix these 2 minor issues before applying. Thanks -- Thomas