From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86C74A0350; Wed, 24 Jun 2020 13:53:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CF801BEB1; Wed, 24 Jun 2020 13:53:58 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 5D1C51BEA7; Wed, 24 Jun 2020 13:53:57 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id CE222580454; Wed, 24 Jun 2020 07:53:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 24 Jun 2020 07:53:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= iPSnRNsZcNV+b0uGpfF2gIgkl78j+qI4hds8QCqUqLw=; b=GEt3Bkusj4O0Pztt ppk3lCznvUciZI6ZDfDqNnRyQABvBX/lbqJISQCx6dcLi2BSKK7hj0rm2sXBUSiv 1es7cUDKvlwX88zG8hbDHk4DM5lkdnAmF/hOJX6yEXKAtcwAIclzsPaFmswMpckT dOAii0dgp/0ip+i1AjfR/WBdTWsfDw8YyMsLR7371HQWmbO3p1SUcjSGFCe22sEw 5kBpLw48KeHpoTRoG98EdFAGsBQ/BeCNZlaVQWIEqka5dt/hF19+7QRGsU7WLLHy QcPUJ0zur/ZGGgX549KlQ9HPUnx3Lh7G/GG+faX7XIxHNmq1A5h8QferopQSlgVc pEizsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=iPSnRNsZcNV+b0uGpfF2gIgkl78j+qI4hds8QCqUq Lw=; b=Tta8CFs35cPVbDyVTwbzdjZnc1GqmJANQWoXWZYmSxdiVghmocAUUOZpq esOjB1Hc4xL2Qo6XZZ92V8A9HDCG/FJibetuX1z6AXqR6me1dk5PRzP+U1W3vqcZ iXRWnU0nu7s6CUhA7TydzAfNmVEsOLHhKeRIiz7Mdg7nhV2dPxHRXZY9pFToA0mj 8WPZ+1qBdrmOLg5H3eGM48uJ75qrEMV8rlw6WqYDMAcwH/IBjAdhpO76aYg9s+1w 7aSZwDVjMnrt5KsJ215q8h9hhGv3Q/tkfKdFlN18cPEyAb2+bAwk4tik2jnU84Ui Q0SYjR/LxigcuBYrEXnIwn2rl2IQw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekjedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthhqre dttddtudenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeefgeffiefhfeettdfhvd fgteekffffudekvedtvedtvdfgveeuudevgedvgeegtdenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 21857328005A; Wed, 24 Jun 2020 07:53:54 -0400 (EDT) From: Thomas Monjalon To: guohongzhi1@huawei.com Cc: dev@dpdk.org, stable@dpdk.org, olivier.matz@6wind.com, mb@smartsharesystems.com, konstantin.ananyev@intel.com, jiayu.hu@intel.com, ferruh.yigit@intel.com, nicolas.chautru@intel.com, cristian.dumitrescu@intel.com, zhoujingbin@huawei.com, chenchanghu@huawei.com, jerry.lilijun@huawei.com, haifeng.lin@huawei.com Date: Wed, 24 Jun 2020 13:53:52 +0200 Message-ID: <2998964.7raKxpcYx0@thomas> In-Reply-To: <20200526100805.24896-1-guohongzhi1@huawei.com> References: <20200526100805.24896-1-guohongzhi1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/05/2020 12:08, guohongzhi: > From: Hongzhi Guo >=20 > 0xffff is invalid for IPv4 checksum(RFC1624) >=20 > Fixes: 6006818cfb26 ("net: new checksum functions") > Cc: stable@dpdk.org >=20 > Reviewed-By: Morten Br=F8rup > Acked-by: Olivier Matz >=20 > Signed-off-by: Hongzhi Guo The Signed-off should be in chronological order, before reviews. As suggested in previous patch, the title should be net: fix IPv4 checksum I am doing above modifications while merging. More advices about submitting patches: - use -v2, -v3, etc when sending new versions - add a changelog below the line --- - use --in-reply-to to keep all versions threaded > @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr) > { > uint16_t cksum; > cksum =3D rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr)); > - return (cksum =3D=3D 0xffff) ? cksum : (uint16_t)~cksum; > + return (uint16_t)~cksum; > } Applied, thanks