DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
	Anoob Joseph <anoobj@marvell.com>,
	Ankur Dwivedi <adwivedi@marvell.com>,
	Matan Azrad <matan@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: replace hugepages commands with dedicated tool
Date: Fri, 12 Feb 2021 13:51:36 +0100	[thread overview]
Message-ID: <2999521.QBpJZUq1JZ@thomas> (raw)
In-Reply-To: <6d6b5f40-2145-38df-6749-f3f9f581de17@intel.com>

12/02/2021 12:55, Ferruh Yigit:
> On 2/11/2021 6:16 PM, Thomas Monjalon wrote:
> > --- a/doc/guides/howto/lm_bond_virtio_sriov.rst
> > +++ b/doc/guides/howto/lm_bond_virtio_sriov.rst
> > @@ -581,9 +581,9 @@ Set up DPDK in the Virtual Machine
> >      # virtio port is 03
> >      # vf port is 04
> >   
> > -   cat  /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
> > -   echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
> > -   cat  /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
> > +   /root/dpdk/usertools/dpdk-hugepages.py --show
> > +   /root/dpdk/usertools/dpdk-hugepages.py --setup 2G
> > +   /root/dpdk/usertools/dpdk-hugepages.py --show
> 
> Wouldn't be better to use 'dpdk-hugepages.py' only, or perhaps 
> './usertools/dpdk-hugepages.py' but not full path.
> The dpdk path, '/root/dpdk/', assumption can be missleading.

Using this fixed path is consistent with the rest of this howto.
Maybe you would prefer a rewrite of the howto?



      reply	other threads:[~2021-02-12 12:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 18:16 Thomas Monjalon
2021-02-11 19:07 ` Stephen Hemminger
2021-02-11 22:28   ` Thomas Monjalon
2021-02-12 11:55 ` Ferruh Yigit
2021-02-12 12:51   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2999521.QBpJZUq1JZ@thomas \
    --to=thomas@monjalon.net \
    --cc=adwivedi@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@nvidia.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).