DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Xiao Wang <xiao.w.wang@intel.com>,
	Nicolas Chautru <nicolas.chautru@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Jiayu Hu <jiayu.hu@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	Declan Doherty <declan.doherty@intel.com>,
	Ori Kam <orika@mellanox.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	Tomasz Kantecki <tomasz.kantecki@intel.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Harry van Haaren <harry.van.haaren@intel.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Bernard Iremonger <bernard.iremonger@intel.com>,
	Maryam Tahhan <maryam.tahhan@intel.com>,
	Reshma Pattan <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc/guides: clean repeated words
Date: Wed, 13 Nov 2019 10:12:23 +0100	[thread overview]
Message-ID: <29a2b40e-b08a-c3cc-2c8a-e2eb7914dc42@redhat.com> (raw)
In-Reply-To: <1573587221-25158-1-git-send-email-david.marchand@redhat.com>



On 12/11/2019 20:33, David Marchand wrote:
> Shoot repeated words in all our guides.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

For anyone interested, I caught this with a patch I added to my checks:

awk '
{
	if (prev_file != FILENAME) {
		prev=""
		prev_line=""
		prev_file=FILENAME
		NR=1
		display_banner=1
	}
	for (i = 1; i <= NF; i++) {
		current=tolower($i)
		if (current ~ /^[a-z]*$/ && prev == current) {
			if (display_banner == 1) {
				print "\n"FILENAME":"
				display_banner=0
			}
			print "  Detected repeated word \""prev"\""
			if (i == 1) {
				printf("    %5d: \"%s\"\n", NR-1, prev_line)
			}
			printf("    %5d: \"%s\"\n", NR, $0)
		}
		prev=current
	}
	prev_line=$0
	if (NF == 0) {
		prev=""
	}
}' $(git ls-tree --name-only -r HEAD |grep -E '\.rst$') >.check/doc.txt


It has some false positive, so the output is compared to a reference
output I manually checked once.

if [ -e .check/doc.ref ] ; then
	diff -u0 .check/doc.ref .check/doc.txt
else
	mv .check/doc.txt .check/doc.ref
fi


-- 
David Marchand


  reply	other threads:[~2019-11-13  9:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 19:33 David Marchand
2019-11-13  9:12 ` David Marchand [this message]
2019-11-18  8:52   ` Mcnamara, John
2019-11-13 10:47 ` Kevin Traynor
2019-11-15 10:37   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29a2b40e-b08a-c3cc-2c8a-e2eb7914dc42@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=akhil.goyal@nxp.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jiayu.hu@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=maryam.tahhan@intel.com \
    --cc=nicolas.chautru@intel.com \
    --cc=orika@mellanox.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=pbhagavatula@marvell.com \
    --cc=qi.z.zhang@intel.com \
    --cc=radu.nicolau@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=skori@marvell.com \
    --cc=tomasz.kantecki@intel.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiao.w.wang@intel.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).