DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>,
	Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	"Xueming(Steven) Li" <xuemingl@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [RFC] ethdev: add generic TTL rewrite actions
Date: Fri, 24 Aug 2018 09:48:29 +0100	[thread overview]
Message-ID: <29a35612-9936-a901-2937-e18643901925@intel.com> (raw)
In-Reply-To: <20180824071711.u2xefstgefadh437@MTBC-JACKMIN.mtl.com>

On 8/24/2018 8:17 AM, Jack MIN wrote:
> On Thu, Aug 23, 2018 at 03:00:53PM +0100, Ferruh Yigit wrote:
>> On 8/7/2018 3:20 PM, Jack Min wrote:
>>> There is a need to rewrite TTL by decrease or just set it directly,
>>> and it's not necessary to check if the final result is zero or not.
>>>
>>> This is slightly different from the one defined by openflow and
>>> make the actions more generic.
>>>
>>>
>>>
>>>
>>> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
>>
>> Looks good to me.
>>
>> Can we use existing testpmd commands to test these new actions?
> No, I don't think so.

Can you please update testpmd counterpart of new actions so that they can be tested?

> The current TTL related testpmd commands are all for OpenFlow variety
> 
> -Jack
> 

      reply	other threads:[~2018-08-24  8:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 14:20 Jack Min
2018-08-23 14:00 ` Ferruh Yigit
2018-08-24  7:17   ` Jack MIN
2018-08-24  8:48     ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29a35612-9936-a901-2937-e18643901925@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=xuemingl@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).