From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2029EA0C43; Thu, 23 Sep 2021 09:19:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88421410DD; Thu, 23 Sep 2021 09:19:15 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2B922410DC for ; Thu, 23 Sep 2021 09:19:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="223823254" X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="223823254" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2021 00:19:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="455015207" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 23 Sep 2021 00:19:11 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 00:19:11 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 00:19:11 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 23 Sep 2021 00:19:11 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 23 Sep 2021 00:19:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PY21v4Q/QjxkR6fMlr6zl5b4C9euhfJ8td0OZqNDdAQClFyy85DddVayKExlTv/XWXeIVXLrexa/wQKlb5UpCVcD0eEPJG8LvWz30ZQX3dx1rVktat/THRwb8hRadnhLDhuQcBSzaG2EJgp20FLzgdkzlvvMI5/iikLuTyOG6x9/81y/qGtZPO4V+wA9+KFqNl+lac/DUwoxEE1Cq2Eaoi+dvYjdGu4Z0zoiThFV/mCRVUEo40WjUi4Tz7txjDuQ6SXZj52W+D6DLo4Q9gTel8L/9tO57VkdBbexIqgz5jMUHDnDe1bRYK4ZweVAumtZgkCpbDL9pmDjQoQQHE7J1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6Cqk2Trs6HOU6ck0VDnqt45WNp17qN7JtXu6X/RGT7g=; b=X93M0QNZWcOF7lLQGc0w51dFgRacqefVVIs4ttUJ8CVT9Kt2bjIKe/bQlDep91HaqvwcGzJ74AA3DbaikXTDKs1axxVHUEd1KNiFY+q6uBJ8KsPd3NQHXF266lBhHTk9EQA/ZEvPYrb57zy6bNyquFOzBta8zfMHwIzQhYqcC3M4aLI9XK9Iq+oVSEKs1zm3PilFQVeSvPnmxYRhiiBKcqbJrY634+bR5mQj0yMaKvBe4dip0pCWMl7jlVlopO0nWpRuoNMTu5p10HeJ2oyv0U+ab1XbOnCYvU1G6W+ZvQTiigBPSyZySojSrPoMKd8fl1FL/22nWG2fUREEQrlPBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Cqk2Trs6HOU6ck0VDnqt45WNp17qN7JtXu6X/RGT7g=; b=qKNxtDfwwV/YWwuaSqOSO168jVY34I6K1FO47Yseh1pXEIOaMJh3vsvVQIbPgxLEtmMMSDEkzgxEMin9Iatabp8SjqtZUPEs08pmP3QFQ7l2wU5eWVl3OtooUwA5Dyr86Az1i3FVR8wb9dxFMDCkvjJLIpU4KzMeXXPTCRPxj6g= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5142.namprd11.prod.outlook.com (2603:10b6:510:39::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Thu, 23 Sep 2021 07:19:08 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.014; Thu, 23 Sep 2021 07:19:08 +0000 To: Ajit Khaparde CC: Venkat Duvvuru , dpdk-dev , David Marchand , Aaron Conole References: <20210908050643.9989-1-venkatkumar.duvvuru@broadcom.com> <20210920074214.23747-1-venkatkumar.duvvuru@broadcom.com> <48401ae7-eeb8-9283-3894-747c89fd963a@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <29ca852a-c6cf-5aa2-6397-da61a2bbddd5@intel.com> Date: Thu, 23 Sep 2021 08:19:02 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0601CA0035.eurprd06.prod.outlook.com (2603:10a6:4:17::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0601CA0035.eurprd06.prod.outlook.com (2603:10a6:4:17::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Thu, 23 Sep 2021 07:19:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6564ad5f-ff86-469c-b3b8-08d97e626eec X-MS-TrafficTypeDiagnostic: PH0PR11MB5142: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F+0i5g/5arv5dwNQ0kK6xq+RZ7JkTEVunT+MAVic3anVYhcCMhVi01YFvGH+c/7L/spak+VtTJvEGaaeVFTD6p/PmiDITr66UniQXQEilUc/j9W/DmHOlASet7FUcfPTRrcUQNph44x56gEmEXyUo7TCbvaL29VrQafnHnaZTyKoAwohlWQYbWhTpIhjXcbkgvSOM0ZBuV2inRnN1PWatNBXS3KBUFVj6cv4wLQHSEx7tJeYmNM6KTBsbH920LCsag/IThw/aaOOueyfBKzP6Imhpv9D0d26pz6xr12d1rS16UzETQVupEr8+Dravz1uJah0/79vtmYIipoU4QXiocYw4R39oaSddSU0q8zHy2iyYVSPMbqOOJeryIs+60U5brFLqUNCSPVBmPLXjhzq5U/nV+5LTl3HnwsbQArgZ5VNFG8FVV9kq1au9TkkZqzSOCBZq2yuvjP475jKVFhNOME3yaSAqkw9c66rPpf09MQm17Ub7MeWdf/zLKff6JjGJiMzXv8Gs6DgDOwFqgRGtqM2fk8T74k5oGl3fuQnRQRcWGwj4pS8TaflqIEfFYYN4FAElsynQqDDNkpWuDjFMpx36QPDfsqPmLmWdWEu37iKDe3rpaidp37OSqTX+p+rVWNCCUvxU7UiJk2zXTHqZjtSVwsrWm2Fd351Me8fGkuTWy3gIJ9/gqKGHPEvlV5+1vaRkWh2s5puZU6VYS7+xv6yE8we1h2txYsF5r2QYdKPP3ILDZXXzLMGJ3QHddQP+l4uQ2w8M2rQQwgP89/kxr8+j0dUDOSsdIVf6Nu40qU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6916009)(8936002)(66946007)(66476007)(4326008)(2616005)(186003)(956004)(26005)(38100700002)(44832011)(16576012)(2906002)(31696002)(66556008)(8676002)(36756003)(54906003)(508600001)(31686004)(83380400001)(53546011)(86362001)(5660300002)(316002)(6666004)(6486002)(966005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkFIQmVNRWtuZ0wvRWpJemVaZUtSRisyUHpjd1MwdHI2YzNXTlQzc3prMk1S?= =?utf-8?B?TDl5TmVKcVVncWhIZUM1a1IwMWhkbkhSb3hRK0QvYWhKSnVyd2YwRXpRc3M1?= =?utf-8?B?bnArZHRJRytwS0FQdHRDYkl4TjV0U3c1ekY5Y2dFOW9sQUlpVmdwcGVJNmMw?= =?utf-8?B?RzRqWG1KTUk3cVZhbkYrU3dxOTc5VHM1VVZqL2drVytnNVFPTHZldkl3Smoy?= =?utf-8?B?ZDEwTkpsUkVPaVkzV21obVQ3ekEzQUN0aVh3WU9hV0NkOUcvMGcyYlQ2cG05?= =?utf-8?B?aWo0MlRQWStJcURuazMvdVN5WUhaYlBBZU5OY09mM2tRZjhBRjc5WWhCTGhj?= =?utf-8?B?U3NOWFlNV01TQ1dsWnJZMnBqK29QbXlnWE84TTJnUVh3TC9aMTA4eHhlYTdO?= =?utf-8?B?OXJER1ZPRnBHaTE3c2VCc3NqZEZpT1YwaUJGMlgyWjFpMzdaRFZ6SmFNY1pJ?= =?utf-8?B?UjVLR1NjbHgzYUF0OVhWVHBCTThsZTNOWnNXL3dMRVluL3VMRzJHODQ5NGVV?= =?utf-8?B?UFlSRGF4ZW00SVc1T1E4WEJNcEVtaVloY1ZqRG9KY2dRd0ZPYSszSEMxUDFG?= =?utf-8?B?UW1zeTNxRHhZeWxIbWRMZlYvYWdoOHBHeFNTbVpYSG1QaXd1QnY2N0VhQmVH?= =?utf-8?B?NExxKzFFZUMvZkp3Z3ZpdHBqTmcrWUg0OElmcUU5UVpubWNMVFNuRHcrNjk4?= =?utf-8?B?SUJESmI0MXp0VWVnT3l0bXJiM3BDUWVjd2QrNmF1aVFLNGVGRVEyQ0Fva09R?= =?utf-8?B?S3RQSWU5eC9RbFpob2hQODVHeWI0My81SmVRVXVEVTNZUmp1UU5sN2RCVThr?= =?utf-8?B?NlhxZ2VyN05nWkRWb1JEdFVjbncwN3ZHYnZkQ1Zjc1ZEeXdUb3RtdjZtY0VD?= =?utf-8?B?MXg0NkVHckE5S0tXYWE3Y2cwUnJIRllrNVZ1Z21pL2RKQS9vOWpCbUgvTkNF?= =?utf-8?B?NUtjdHUwYzdCTFRLVEdtYndRUHIvREdYd0ZWaXVveFdEVUNZUGdOK1Z3TVJK?= =?utf-8?B?ek1RT0F5enRYbi9VNXppcTR5ZUx2bS83TVhydlFERWdWZVVSbFA2S0ppVXpw?= =?utf-8?B?OFVFVzNvVXFHOXNTNWhqUHFHalF6MFVzaDRMYzlWRUZENDA0Nk8vSTNvTkNP?= =?utf-8?B?bXF2cjBTaEkycVRMR1c1ZUZJQzRhWGtZYWszWUdRdjh2eWsyZ1FpdnVXMkxl?= =?utf-8?B?aFg0d2FLVDNNc2IycUM2bDhud3dYanc3V1BpTE9hSUI0NFQ5K1lvd2d4TmVI?= =?utf-8?B?U0dMOVhSZHRJR2FMdUlLc3lFR3dSN29wc0ZLSDdzeEdIYVlDWCtkYzRNekh4?= =?utf-8?B?K1JuWGtJK3FKWno3MkUzblNXZUltc1RHSUsrQlhJM29GMHZjSUl1dDNxa0cv?= =?utf-8?B?eFI4S29vT0s2TW40WG92RmxyejBKL2lEWlFCT2ZGV0xwYi9qS2hTbVlhb0NL?= =?utf-8?B?ZFZaRDhmMHdMZ3ZlcGk5N05wNWh0MGJrMmNnU0N5TjR2NjNhVzU3anArZUgy?= =?utf-8?B?RmFIWnJEZVJwWWUvRmdGckxoTnR5NFhBY2RVME1HU0dkUlVPUXhLOGpxWlNO?= =?utf-8?B?d0NCZHp5RGlzUjJsYmFMQjJ6RWIrUXo1Q2RjV0taSDU3MDYzNnZ0eERVZXFJ?= =?utf-8?B?R0MxZWh0RzR4TnNuRzMrcGliTlllWmlZMEYzNTVTMzdmWHdtVXl3NVJubUVm?= =?utf-8?B?SWZINlhhMWNmRmhTbVJJNVE5R1JjNU1XTzN4WE54b2lTelZ0QTdJTnI1b2ov?= =?utf-8?Q?RmAi2B5DCECVWM+oUzQLP1gvl1zmsLKZRZohEYM?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6564ad5f-ff86-469c-b3b8-08d97e626eec X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 07:19:08.3542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: trMyNMoJnOHdfOecvJzrFnhMp5Jt8Buh1/nqtiygXx+NiFRIvF8esEPSs4mgFzBWB9+MqWler7kVDfENmEJYWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5142 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 00/13] enhancements to host based flow table management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/2021 9:21 PM, Ajit Khaparde wrote: > On Wed, Sep 22, 2021 at 10:36 AM Ferruh Yigit wrote: >> >> On 9/21/2021 5:50 AM, Ajit Khaparde wrote: >>> On Mon, Sep 20, 2021 at 12:42 AM Venkat Duvvuru >>> wrote: >>>> >>>> This patch set adds support for new offload features/enhancments for >>>> Thor adapters like VF representor support, new flow matches/actions >>>> & dynamic SRAM manager support. >>>> >>>> Farah Smith (4): >>>> net/bnxt: updates to TF core index table >>>> net/bnxt: add SRAM manager model >>>> net/bnxt: change log level to debug >>>> net/bnxt: add SRAM manager shared session >>>> >>>> Jay Ding (1): >>>> net/bnxt: add flow meter drop counter support >>>> >>>> Kishore Padmanabha (6): >>>> net/bnxt: add flow template support for Thor >>>> net/bnxt: add support for tunnel offload API >>>> net/bnxt: add support for dynamic encap action >>>> net/bnxt: add wild card TCAM byte order for Thor >>>> net/bnxt: add flow templates for Thor >>>> net/bnxt: add enhancements to TF ULP >>>> >>>> Peter Spreadborough (1): >>>> net/bnxt: enable dpool allocator >>>> >>>> Randy Schacher (1): >>>> net/bnxt: dynamically allocate space for EM defrag function >>> >>> For the patchset, >>> Acked-by: Ajit Khaparde >>> >>> Patchset applied to dpdk-next-net-brcm. >>> 1) Changed instance of TF to TRUFLOW during merge in patch 1/13 and 13/13. >>> >>> Please apply to dpdk-next-net. Thanks >>> >> >> Hi Ajit, >> >> The github actions fails on build for gcc, please check it on my personal github >> repo: >> https://github.com/ferruhy/dpdk/actions/runs/1262767538 >> >> I don't have this error in my environment, this can be related to the slightly >> older compiler in the github (gcc 7.5) > > Yes, even I did not see this. Looks genuine and likely because of some > different compiler. > I will try to submit a fix. Will you be able to squash it with the > relevant commit? > If you can send the fix on top of latest next-net, I can squash it in next-net, assuming the fix is simple. > > > FAILED: drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o > ccache gcc -Idrivers/a715181@@tmp_rte_net_bnxt@sta -Idrivers > -I../drivers -Idrivers/net/bnxt -I../drivers/net/bnxt > -Idrivers/net/bnxt/tf_ulp -I../drivers/net/bnxt/tf_ulp > -Idrivers/net/bnxt/tf_ulp/generic_templates > -I../drivers/net/bnxt/tf_ulp/generic_templates > -Idrivers/net/bnxt/tf_core -I../drivers/net/bnxt/tf_core > -Idrivers/net/bnxt/hcapi/cfa -I../drivers/net/bnxt/hcapi/cfa > -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config > -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include > -I../lib/eal/linux/include -Ilib/eal/x86/include > -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common > -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs > -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics > -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf > -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring > -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci > -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev > -I../drivers/bus/vdev -fdiagnostics-color=always -pipe > -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2 -g -include > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat > -Wformat-nonliteral -Wformat-security -Wmissing-declarations > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef > -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC > -march=corei7 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API > -Wno-format-truncation -DRTE_LIBRTE_BNXT_TF -DSUPPORT_CFA_HW_ALL=1 > -DCC_AVX2_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.bnxt -MD -MQ > 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o' > -MF 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o.d' > -o 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o' > -c ../drivers/net/bnxt/tf_core/tf_sram_mgr.c > ../drivers/net/bnxt/tf_core/tf_sram_mgr.c: In function ‘tf_sram_mgr_bind’: > ../drivers/net/bnxt/tf_core/tf_sram_mgr.c:418:19: error: ‘slice_list’ > may be used uninitialized in this function > [-Werror=maybe-uninitialized] > slice_list->tail = NULL; > ^ > ../drivers/net/bnxt/tf_core/tf_sram_mgr.c:574:29: note: ‘slice_list’ > was declared here > struct tf_sram_slice_list *slice_list; > ^~~~~~~~~~ > cc1: all warnings being treated as errors > >> >> Can you please check the build error? I will keep the set in next-net for now, >> but won't mark it to pull to main until issue is resolved. >> If the fix is trivial, we can update it in the next-net (after issue recorded in >> mail list), if it is not trivial may require a new version of the set. >> >> >> btw, in git history 'TruFlow' is used, so I continue to use it, fyi. > No problem. Thanks > >> >> Thanks, >> ferruh >>