From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8145E42D23; Thu, 22 Jun 2023 13:28:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A197406B8; Thu, 22 Jun 2023 13:28:36 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2069.outbound.protection.outlook.com [40.107.220.69]) by mails.dpdk.org (Postfix) with ESMTP id 396BB406A2; Thu, 22 Jun 2023 13:28:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cScROcHcEGurLCMIST2OXUn66Jz1GeDAtfxncVjLSQ1B6UM3/iW6TQfkIUErBMnYQIXSwG4PJWfLUkwbGw8DAnFWXpWnfqJzkpLgAPXzwIClOsPGbaWmLuJLcBReM5vrWkj7TaO3rdcQRejnLgIudkygxBaeHAbijbuco/lWqZ/K0Wd+E7TkpRiVqRboFnUD0plRaCXex8Ahu44VDiUVk/+DByIiuzHqaoLS+vzaXFYee7H6LzJMh5STzEglwq4KiZhk4XudtgyU4R/a/7gqHj2+wgxYQhw13NATUfp2e7MGvICaERR+0iVEQmapBNeXaZ8OCRBuit6jGIeV54cuRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bjZvMSAldSEcem9yOOICDAf9RIdvimvlt4yHcU6bU3Q=; b=PQkm1QuGG9IhSLYgFhbCKBiP3OPSTBcnkCYSgJm3s282dBSZjALvA+8PUDtWGb144ow8VgL5WsRTi54tsi7RVaQ/KY/tCMXSF2rxbjqNRSDdAvpuwQbdw88yOcnUIEuiw02yqurdr+VkfoIu5SBvEcgyItiYSGQUzMCWBcC0PnbuePhJbZ5PvAsw2uucyv07/qMwK/gcboo3ZoAMNVu/RwpPDhtUmQfIilVZipZ/gGs0XToew2E5n66qC5b/4lf7ttOS43a/bvZW3RXjgZ/ZyZfm8rC+rTc5JjHcjzvNJgsSeeN0qOckf802a9H843CnNaptWtkVtmh5BDkEAl9ndQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bjZvMSAldSEcem9yOOICDAf9RIdvimvlt4yHcU6bU3Q=; b=OyGAouWvIx2iSSp6lDFkwcIxtu9GmPm2PoJ1VHNNfCTp7O2wZYeHHp+pS40K/E5Kb0YVtaFqnMso9BZY27r7Su79za9bKSC9Q9x3zYTGmTeSpEDX01jDm0svOqUUG484fJGur7/yw4knr0AiBB3tiDkzd0DSitwxfybb2PdvA7E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV2PR12MB5920.namprd12.prod.outlook.com (2603:10b6:408:172::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 22 Jun 2023 11:28:29 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.024; Thu, 22 Jun 2023 11:28:28 +0000 Message-ID: <29d2ab5d-f87d-20f1-56fa-022280cea6e7@amd.com> Date: Thu, 22 Jun 2023 12:27:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Artemii Morozov , dev@dpdk.org Cc: Andrew Rybchenko , stable@dpdk.org, Andy Moreton References: <20230531070810.93131-1-artemii.morozov@arknetworks.am> <20230622093110.252817-1-artemii.morozov@arknetworks.am> From: Ferruh Yigit Subject: Re: [PATCH v4] common/sfc_efx/base: set return code in case of the error In-Reply-To: <20230622093110.252817-1-artemii.morozov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0007.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV2PR12MB5920:EE_ X-MS-Office365-Filtering-Correlation-Id: 104fa5dc-3d74-4b0c-f951-08db7313cd0b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y4OVe68DozTDO3jTXCNCl3M1QrMtbHZ8GJFZqJ10lHc0SZjWJZHSkvYqOfbjMX312uTEB1C1qYCTtPD8Kid6Tjmpz4ovPeVhsSFi2giXxjDOjug/rFIKFsNqYYg/3hXqHVLdUD5NxZVoGnv6CQA9ZC7p5bfxP7bandh0hsv/nSVwwmvHgxB+92A7oyn/zmezQ91eGzHAVug8s9HNYnuAmFmJPenjduK2s0uQW6qki/A8iM8bFtC+Yo0fdhO4HHrHAzBnVAwOMLa67APzqprbo1FnPTzRCZFouSYuume2YChjC0WOMkYN/g4ym0bfSKs1BF0kmpBIpytSk9MO1TRwTQFLgt83AaSu54dpXlv6WfQfubpY9BNafj+DUce5t5fgTAg3uy5gbMkXNDzf16EEL1W4+C2JhArOmwfYvORstK7yByKsrzJubWpQJ81r6xJ7Yey2ztLpt9JJ/ilSudX7h4ZEZcw5qXAcdxWLV1NezfPhuD5qruzUt8dToxHUqqS7i0mYKWxv46R6tCO43EBk0ul7ia7vbtjFz2NCrMFTd1LYaMXOSqSalufL+5hN0Qz4gr5o/+mwkiDIk2UfkH0qUaj3gl2LOA/WhdyUI8nAQGd1Q6tTb7rXRKb4PEqAdZSxI5OUV2FGMF5/Ori7FpVF8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(451199021)(6666004)(478600001)(5660300002)(83380400001)(53546011)(6506007)(6486002)(54906003)(31686004)(4326008)(66946007)(8676002)(41300700001)(66556008)(66476007)(8936002)(44832011)(2906002)(36756003)(26005)(6512007)(186003)(38100700002)(316002)(2616005)(31696002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0VLRDJkc3UxQ2QrY1Zoby9oaXc5dVdqUXJXc1h4S2ZkdGM1UFBmQTV4UUM4?= =?utf-8?B?NXhDU0MwaW1WUGp6MGVFd1k0UlhzYmhIZXJzc0RaZitsMjEzN3RFVElxNGFG?= =?utf-8?B?Y3VYTFBFMUtWM3ZILzk1cTl1Mm1UNlBrbEZZVkhJNVh0cUVPTlpYVStXVjVU?= =?utf-8?B?MUx3N3FyaW92eThxTlo3NjFJelZFOGd0R1ljME9LbStnSXJwWU5aLzBKdy9z?= =?utf-8?B?L1BPQXlZaDFqMjJqK1UxZ214ZW0zWDhrOUlBcEIvaVl0VGdlbGI1MUhBSnpB?= =?utf-8?B?VFVTaUV4VWlZWWVFdGF2V0xmOG5oQXl4enVmMEJ0WEVPWWxwSXJTUEFWODZ3?= =?utf-8?B?dzVzdjVla1NkZnlmYkVpM0wyRjgxdzlUK1Y0WC9rcWx5L2hoUnFtVUJuZ1la?= =?utf-8?B?NDhNQlBQOU9VcitFampCSWJNS1Jqd1JtemRycU9UNnV1S01iaFNCRmkvQk4r?= =?utf-8?B?VXhYUERmWnVVUUpxd1FOdE15RStlcXdod2RFaklMQzF6RHNwVFpPdm8vVmNL?= =?utf-8?B?SGhSUzl6TWZpVVNZRk9tUnNhS1JnbStPN3RJUGdqaFI3ODhKeDJVOTdlYnFm?= =?utf-8?B?U0RDT3N3eEg5TXV1a0R5NDIyUWNyOFVpQ3J5dE1tTVYvOHpSUHpaTmVKYWFa?= =?utf-8?B?YkVaeU5iMW10QkE2NUI5akRHUWhrMVkyNWg2U2huUXRyVVc4VmVCSERrck1i?= =?utf-8?B?S1dRWlFlcUZ5T01MTzh2WSsxL0o3ZzAxbHFDWGVWZGtBQ0dhSitsUEJCOVo5?= =?utf-8?B?TzVBeDhEVFppMm9xNitIVkY4OXRDMzJTQk9ld083S3hSZnlFdTY2MWp3eC9O?= =?utf-8?B?SGtvdTNIMXJ2WURjQkgySkhmY0hocjdGSnY4R0tVQVlMd25LdWV0djZ0ZlVS?= =?utf-8?B?VUFKQ3hkaG1ETDgvYU5SVEVSczFJRlVoYnVDc2h1NkhEVUlRN2o3Q0llVnZs?= =?utf-8?B?R0syVFVpb0RTUE01OTBVc0NTR3UwNTJ6a2U3VXEvSVd4amZ0S1ZQWGJYaEpX?= =?utf-8?B?ZXNrK3lWbHd1am9yOXhTNjhLTmlaam5pazFLWFlrbFlaTlVPVjFtQ3FheG9O?= =?utf-8?B?alVkZk9lZ21kWWM3NHByODdyTmJneVRDTnozQi9aRmNJbXZnZzBZV0IrZGZw?= =?utf-8?B?dWt6amp2UGpYc1FhZ2NBV0NiQ0dORTU0NnhpUnhvbW43a2pFa1YrbnFIdGVw?= =?utf-8?B?MUtwcG9FU0VvYjBpbHpGNTBGYVZNQkVXUGhlMWNUb2U1ZWZ4ZWdQNERtd2J0?= =?utf-8?B?Z0RRcEREUkdVZnBrNDhRWE9Ib0huV3JvT3NIa29KakcrdHQ3MGVwbjlrSWc2?= =?utf-8?B?RXF6V2JHeVE4VUZDRWtKakZ3RStMZXhqNjJDemxKN1FqZ2dpNHQyUkZGY0Fs?= =?utf-8?B?alVJREhjaldrYjhvdkF3R1h1elZaeTMvUGlyYU5yK2F3VDRzSnJzZmR5dm5J?= =?utf-8?B?d20ydG1DNFR2MVN2dm5XSk50b0NjbUc4dm4ySXVFTUQraE5GbWN6UERlQVlG?= =?utf-8?B?YXBxSHlnUGF1RnZ0Q09sZGNOcnVIYWovWjM2dS9aNTFEQWxyZVNyUlA5aVYx?= =?utf-8?B?UmpsWllpV25ra0IrWEV3aWdNRm9Yay95T20yc3FrR2hMQThJcUZYdjJOQmZ5?= =?utf-8?B?MHI3QnlLcjJXdjh6R3QwREFSR0w1Y0JKODl5UWxaY1BoNG93eThvR1g3UzZQ?= =?utf-8?B?TDRzV0t0US9BbFVkcHBJYk5xVStpcEVMQlcrdDlQZ09mMy9HdUhJM1ExTlA5?= =?utf-8?B?bkZBUkpjVkZxemU5Nm1TbCtZakJvNXl4OVlGQllnbGtNTTgyRVkrQjhTSUZQ?= =?utf-8?B?MzJSTm1CTnVva21mRDBpVHRpTFJvVEVyUVV6S2FxK2ZqRmlxM2N3dGtsWWRa?= =?utf-8?B?Rm5XZXlWVVpMYVJsOFBKNXZxUTU2eHV0RXNYOUlWRXRWc0ZUTTZEenBZTUN3?= =?utf-8?B?VEFtSE5tUFFCZ2dYQ3ZnaWlVZnUvVUZUWkVTTG5laDNYYjcrZGxFQjVhcE0w?= =?utf-8?B?OENRNmdKb0sxSlhhUXZYQysrVkhOTHdYYzZmWnFuM0FnK3Z2VkpGRWpZSUtS?= =?utf-8?B?K0Q1dDVZbThhT0JPOVN1YlJ2UTNLQ2tGNG9NekZ0YkdFRGlTNjRueVBueXBj?= =?utf-8?Q?WUeg9ztnq++zu7l0g2XCiEjH9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 104fa5dc-3d74-4b0c-f951-08db7313cd0b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 11:28:28.7464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m9yvGla53w9K/wAq41nbhz1WCOR+QEVWz9SsV0KOvmyu5BsIZb1INySJWRuJOC2Y X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5920 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/2023 10:31 AM, Artemii Morozov wrote: > If the prefix for the RSS hash was not chosen the > ENOTSUP error should be returned. Before this patch > the zero code was returned in case of an error. > What is the impact of the problem to user? Previously 'efx_rx_qcreate_internal()' was returning success although it fails, and 'erpp' was not set. There are multiple callers of 'efx_rx_qcreate_internal()', those functions will assume functions succeed when it failed, what kind of problem is this cause? Does it cause a crash, or failure in the Rx queue creation, or no impact at all, can you please describe? Impact information is not always easy to understand from code change or low level details, but most of the times that is what users are interested. Like fixing a return value can be a simple refactoring without any functional impact at all, or it can be causing a crash and making driver completely unusable for some cases, although code change can be similar these two cases has different priority. So commit message/title should highlight the impact, starting from 'fix' keyword. Assume it cause Rx queue creation failure, commit can be something like: ``` common/sfc_efx/base: fix Rx queue creation without RSS hash prefix If the prefix for the RSS hash was not chosen the ENOTSUP error should be returned. Before this patch success was returned for this case causing Rx queue creation to fail. Fixing return value to indicate failure. Fixes: ... Cc: ... ... ``` > Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") > Cc: stable@dpdk.org > > Signed-off-by: Artemii Morozov > Reviewed-by: Andy Moreton > Acked-by: Andrew Rybchenko > --- > v4: add Cc: stable@dpdk.org and transform rss to RSS > > v3: update commit log as fix commit > > v2: don't use capital letters in email > > drivers/common/sfc_efx/base/efx_rx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c > index 68f42f5cac..61726a9f0b 100644 > --- a/drivers/common/sfc_efx/base/efx_rx.c > +++ b/drivers/common/sfc_efx/base/efx_rx.c > @@ -937,8 +937,10 @@ efx_rx_qcreate_internal( > > rss_hash_field = > &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH]; > - if (rss_hash_field->erpfi_width_bits == 0) > + if (rss_hash_field->erpfi_width_bits == 0) { > + rc = ENOTSUP; > goto fail5; > + } > } > > enp->en_rx_qcount++;