From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0061942DD3; Tue, 4 Jul 2023 13:00:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2E9040E03; Tue, 4 Jul 2023 13:00:14 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) by mails.dpdk.org (Postfix) with ESMTP id 510A240042 for ; Tue, 4 Jul 2023 13:00:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDFfqCxNqMtQmJpCM91EyzYlW2Ha5WWEDqL4QLf/9vIxPxaYLtTWFbrYQfzR6ddvvKyyYUmPRBHPJA+nuWcjquZiuuUhwyKZMnjmlwEPQiK4YZ3FbCHFvU9pDeJN2qjdp6FObAZWYeDDkvWsL8dD7FY6RjT4dSWKoMue2YskLMbAnwtgmB2ejz7VX0/NusUHEtH81uVvxPteo3oqixLw+HRktaAXrKAwOvZf/LEJ+quE5/uaWDuBb+yxSV2YwKO9pACMCxORYRSBXTsJCn587kxEt5RJNogTBGyhBB7n63GohG0sydPud/F0Qq27LJl0G1lU68CZveFhFLGPwTAN3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w0H+hBdM6+P1u1ELQdxz9VhZrxJivTdtFVb4OtnjOGU=; b=Yxgwiva1L5mLgPyQJskJcxZrQ+75XiZ507s7FjpUcX/OmRxqCNuPmmzHNR1zbBDrOEm+VW+9E/cErxc0yx2co74Gjg/9CSAzd8rsuRIMrpvJEIOKs2Mvs2Dj4kOl+OvRawyRPfLlMFlndOqoQmbLcpJDyoLGErhyf4ote5Q5riQf9flSFnDF7rbmjPKtiUT2VjECywDqq33nW7agnks4E4OLcUwnijQLBbgHSOULt6O+jQh2Qys+0J9ylTeDt6EIGWFINRvV5+6utSeXWVylWkRfBas1ceoj1OKSlyPAMpmMTET7cheLVNnLseT1SL5ToaGtMb0/Cwtyt7TgzfO3Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w0H+hBdM6+P1u1ELQdxz9VhZrxJivTdtFVb4OtnjOGU=; b=4A3N7J593wisFkjABOtcWwTdwgysBsr7n5y8KhMy0KVuvTwpEv83JsChk6uHk82k/PXeANKI3IwKGnqw/MO9YjirXZXYVJW4T8Na+G/2SsZJ6XioD9X5Dj/xuuk3DR+AHjYnYlmLe00aqA2jWxaxPGnSEDlX68XB7IFHEpCmWgc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BY5PR12MB4917.namprd12.prod.outlook.com (2603:10b6:a03:1d1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 11:00:08 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 11:00:08 +0000 Message-ID: <29d89a6b-49e0-8789-411f-6a89db177b91@amd.com> Date: Tue, 4 Jul 2023 11:59:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port Content-Language: en-US To: Jie Hai , Aman Singh , Yuying Zhang , Shiyang He Cc: dev@dpdk.org, liudongdong3@huawei.com, alialnu@nvidia.com References: <20230703110232.28494-1-haijie1@huawei.com> <20230704084507.12788-1-haijie1@huawei.com> From: Ferruh Yigit In-Reply-To: <20230704084507.12788-1-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0205.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::25) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BY5PR12MB4917:EE_ X-MS-Office365-Filtering-Correlation-Id: deb34bf8-331b-4ad7-f563-08db7c7dd472 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O+xMYubxDD+C1/1rhqaAucMUAvQnn3b0TIRJj+CNBKldjRmo4roRFVs7hy8FRxJwoIJPJZBEefqTdiQW4npS011GUNwBYHuUwVmqDUe7GLcuakxS+aRyF3pyzCu7tw6TMUDt5J4GZet7f6tC7y0wxAfXzGuOp70Cw66ua8wtrsNFF1qs8BVMst+nwEEUjp8NbmMFVifIyqptZSR2bwr6FEsXcjjaKtjx8syvXudnq56UOuMK9/zOW1cN+wmqK9GQY5gBpebKs+aRNjScHotuCnUtYxZdkhHk000K4mFDyQDFadnaUDrvyIw2fBxG0NED6q2pON8xntsWaX4tjDu24MrqOz04rE2td0FAumkTBvOQ9Z64N/ugp80kxIwt1kLhcZ+ZPOdr3UbCehj33v5Gi3WVaXdaNHWwOODLgL46GYrUFbQvIfN+V0lHr2jR9tRR9wxGzLmt/n+FnHTTsZBfAPUDHGx/rT/2/vORbi7u6aFAkcxRz+bfHER/8jcPNylnjHnc0AjqYjEurZkGMrL2u6/y2RLgSSWfVqePCsn4O5YR+28bustXqCgZ3Zm0Dk9gk/9gpRKR3/1N5DhUIRT62N624u+kD3sW9wC8ZpaLgKr4K45WQjm3K2Z3NkCksEmKKF71kvI3DaxC00pBfptkLg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199021)(2906002)(41300700001)(5660300002)(44832011)(8936002)(36756003)(8676002)(31696002)(86362001)(31686004)(6666004)(2616005)(478600001)(186003)(26005)(53546011)(6506007)(6512007)(6486002)(38100700002)(66946007)(110136005)(66476007)(66556008)(316002)(4326008)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0xSZDB4SFpPRU52SWMxYXpnQnplQnh4bXhMWlJNNnV6ZUlyU3JLRk81RFpE?= =?utf-8?B?VlNpamp6blFKRFBwQ3J0NCt4blF3dEw2cHVqMnZBSGFSajI0N3RiMTJlTVZj?= =?utf-8?B?NHVUWmpIWkZ5REZ2WEdmdzJ4OGdFdlJuT25SakpFYndZQnpuUjdBRUhnWTVk?= =?utf-8?B?RTNqQzZWc1gwTU1scGR3TTBlSVM0K0tra1RLcGlsQVo4WERHdWhKMlNIN1JS?= =?utf-8?B?NGJyQVhRQkw5a2RNN0x5RW1RNUlZbUl0TGJEM3lCMG5iSFRWaHA3cGtOUitx?= =?utf-8?B?SlZMM3lXSUNWWEdGYWUvK1hYUUtKZG5uYWIrdERGUDYzSzRuYy83QUNrandQ?= =?utf-8?B?SDhpZEFrT2M3cWhkQXp0THYzUzlucTZOL3NiOFR2VmpEdXFOa2tsQU0wK0Zk?= =?utf-8?B?N1ZqSkRlNFhxckFtWWhIOGxzMHF3VWhDMjdlaDRwekorNG9DbnZaVEVOQll3?= =?utf-8?B?VHFEc1V5VWJpZ0huOWR4VG5XamVEdWJaTUVTQ0dJMXJqaGFVMXcyeGsyUTR6?= =?utf-8?B?SUtsT1NDRmFZMytyNmw3MGt6dzgwdG1JSGM5T3dicVFIWTUrcGxPN0dwTHk2?= =?utf-8?B?WkpHdXFYZ1BTemF2eGdydXdSaDFJMEY3bmRGbEhuZ2RFK2ljT0swbmwvODBI?= =?utf-8?B?MmFuRXhGbEl4WnlVNkhlaWZWOTRYSndXM01lcndjZHljWE00U216L3NPSk9X?= =?utf-8?B?ZDBwVlN2dEt4cUtQQnloVy9nMkQxZFl1aEMvendtcm1NMkF3YUJmYmp2TnVX?= =?utf-8?B?UHNYdE9Cb3dsdGlsb1hvUUVVNEtaL2d4RDRlcUV2bnRpK2ZacTNHWW1ROVZG?= =?utf-8?B?WEdmeHEyS1libFhWWU0zV3N3NHVDTW8xdXpxdUN2VFg0SElQakp1Z3V5anZQ?= =?utf-8?B?eE1yYjRLRk9iTnd5NFEyVjUzc2pxR09aM3NxYWFyMnZVajI0OUZmR2ZUeUdr?= =?utf-8?B?RTVnL2NKNEJYWGFSM3NiM2g5a21nM1orMS9OejJuNTRsNmE1UWRGdWkxbG1Z?= =?utf-8?B?T0Z3OUU0MGNZWmhnVmxvV1NMc2p2VlpmaGxGcWFKMHhOVy9ZRWJkRS9TSklH?= =?utf-8?B?b296citJZVQ1c1FIVnlLSjFObTI3bkE2N1k4b1NiUUFKNjJRYkJDMjd1UE9N?= =?utf-8?B?Z3VWOU8xWVhLRGJJWEhIUnRrck9GTmYxbFVFcC92czM4c1VMNlhWMkROSU5C?= =?utf-8?B?TkdUNk1zOW0wbWRURXY4OUh2MVJ6OEtrblFJSy8yMjM5U1p2aUVZREJZcnVP?= =?utf-8?B?bEtmV1FTYSswWlpjdTU5RDFSSi9WbjJ1emJtWUljbERRZ2RMUC9yWXF4VkdZ?= =?utf-8?B?ZkpLeCtid2l6bWQwdGYxR1B6QXdBc09hTGpJeUp3dUhmbGZqWXZuNFVTZXJL?= =?utf-8?B?R1NhVFBTVnhlWTV2ZDRXK0xpVm5aNXRaZ3c1b1VnOHJQZm9FNHVUSzB6Z21K?= =?utf-8?B?OHQzTzBtUHJvWFdnRDdobVRURFlCNGZQTUs2Z2dyN20yTVE1N3RzeHphenNU?= =?utf-8?B?OHlkUVhSZHZONzgvM3JicnE1VTlxMjA3ZEdpbUp1UlR3VU9SeEM2SHdadWJO?= =?utf-8?B?SjdjTDkvTEUwa1MzRGFMSmFsdVRpUW55WEwzT3RMbWd3Zm9Kc3FtRXpPTXNZ?= =?utf-8?B?anFVWHJkVFV1SERxQXdpZ21yc1dnbHBmdnZ3MnN1UW9YQzN3TXFlYUJVdmJU?= =?utf-8?B?WGs3bE1PNnR4SmowZnJuSG5KVllVT2JSRU95RkNvai82Wlc3U2tmczVLdEZW?= =?utf-8?B?OWdJalBTaW4yM3IwQ0ptWmt0UFUvRGFZRFZ6cUZWOXhpeUpudmgySHUrQXd0?= =?utf-8?B?eVFQMG5JWlNCdWo5djIwSnZqR1ljZnNJZVc5dXVsZnpEeWwzYnV2MngwUmVM?= =?utf-8?B?OXNrNmtNdEgxTDBYcUNReGUvTDUwS0lhNHJ5eFp5UkVYcktObWZScGlQSEVN?= =?utf-8?B?Z0E4ZnE1R3lqeURzSDhuVDNzUmJiRkRNRDc3VWxKUmdDbUd5T2MyUVJUQk5W?= =?utf-8?B?VjNlOUN4UHJ2MncxbjUvdU1rMFBjRERyRytzb1ZRdWk5aGFTb2wvTHY1MUhU?= =?utf-8?B?eExrSnQrdGptREx2aEF5WEs4NkIzQkJHSlhhM2kwN0RaT3V0ckVJQ3REaXhC?= =?utf-8?Q?TidFoYAsRRYYZJm3IbpYj3vkr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: deb34bf8-331b-4ad7-f563-08db7c7dd472 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 11:00:08.1893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zv0hGwdupy7OXAdHU37r6K2p9n0oRW7J1lsN2Z7oY9Abm1KOZex5CooYpyATfRmH X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4917 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/4/2023 9:45 AM, Jie Hai wrote: > Function update_queue_state updates queue state of all queues > of all ports, using the queue num nb_rxq|nb_txq stored locally > by testpmd. An error on the invalid queue ID occurs if we run > testpmd with two ports and detach-attach one of them and start > the other port first. This is because the attached port has not > been configured and has no queues, which differs from nb_rxq|nb_txq. > The similar error happens in multi-process senoris if secondary > process attaches a port and starts it. > > This patch updates queue state of the specified port, which has > been configured by primary process. As the secondary process > cannot configure the ports, make sure that the secondary process > starts the port only after the primary process has done so. > > Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all queues") > Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding") > Cc: stable@dpdk.org > > Signed-off-by: Jie Hai > The problem description and solution looks reasonable to me, but Intel testing still reporting the issue. There is a chance that the issue Intel side observing is different, waiting for more information from Intel test team.