From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3E5BA09FF; Mon, 4 Jan 2021 23:46:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BD58160772; Mon, 4 Jan 2021 23:46:26 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 0F696160771 for ; Mon, 4 Jan 2021 23:46:25 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id 11so17274241pfu.4 for ; Mon, 04 Jan 2021 14:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gL0lAIhY+eRglSX+iuuco6qpZcvPznf45yYZZRPPlyo=; b=fZ8Y0E3wOs74Y3nxhGnTe0sQH0DTKBHpy/u3gVkYm/6oWUzqUgwnDiPBH4Qf6IVG8p /raxL8aELcc3UvmGsNIVqSKBBeAg4C0HzBq1JIvGhzBLtKYsgUAU6VpCirF2hWOkGBLj atvinUcsdpHU2XSjEAWH8kUe5fXfdRE0QFWjQopngZDPGkQsp9AD/1ZXw0HhiGvFOr7v YUWLJRwiech7s+S9+C+FxEyfQ+Eo9D6ZCXT87OEytLbv6wYnNspQQEk85yIomPowuL/K DHApv1qPcy0kg00L0Ll2X/MJnwIBckk5ijhOKQ49o9ASvWqvIUfrgFOkpdeZ+zgSwxsl GCfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gL0lAIhY+eRglSX+iuuco6qpZcvPznf45yYZZRPPlyo=; b=HI4f9qk30jRgLDlYwzZzWKpatWcc5xXLevUdgRY+JG1/4BMgmIrDvSyisZUfoxsUEd NtiQjLixn6/HmKZCG7+VCE9r6TtayeJmXJjHmtaTE51bZLns6VA/xhvmK6t08ay5vz5Q sseZOZg1h3JGseAgcTGf306OnKLoBScdywHBuvpiETu5kQ+/9Q8V02XkNT/wOqs+93ZD KxCLqEiaKpB+yunWbdXYGEUmlBMISUk2MARtxskPSbWheP9lA9Zpk1GkxbL4nKg49WXD WgYf5tY2D6zpRddiKIMmJAEtucOnRUk3SQQTiJqMQbgBDd7u6AAy34NZOINLApV8KleO vxgQ== X-Gm-Message-State: AOAM533iVpEH5oHQHz439zDPG7MVspw5Pe+NdBYpMAfuzEe3lJJRhZ6n ffrr7GUust9UXXsC52QwAuQ+jw== X-Google-Smtp-Source: ABdhPJxfoAeLo4hwnTxHTnHWuM1UWPG3NSmk4BvazoqSXmBOxwKVPThY3ePWvR+TF0YlpO9UVYLsBw== X-Received: by 2002:a62:1a47:0:b029:19b:c093:2766 with SMTP id a68-20020a621a470000b029019bc0932766mr68065038pfa.10.1609800384156; Mon, 04 Jan 2021 14:46:24 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:f528:2a3e:f867:db3? ([2600:1700:6b0:fde0:f528:2a3e:f867:db3]) by smtp.gmail.com with ESMTPSA id g85sm57850926pfb.4.2021.01.04.14.46.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jan 2021 14:46:23 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) From: Andrew Boyer In-Reply-To: Date: Mon, 4 Jan 2021 17:46:20 -0500 Cc: "thomas@monjalon.net" , =?utf-8?Q?Juraj_Linke=C5=A1?= , "bruce.richardson@intel.com" , Ruifeng Wang , Phil Yang , "vcchunga@amazon.com" , Dharmik Thakkar , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "ferruh.yigit@intel.com" , "dev@dpdk.org" , nd Content-Transfer-Encoding: quoted-printable Message-Id: <2B294ECB-F553-4E90-ADF3-A48692195390@pensando.io> References: <1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech> <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <36181A92-BE14-4E30-8F26-915AA109BB2F@pensando.io> <50293579.Yt1MtOie5U@thomas> To: Honnappa Nagarahalli X-Mailer: Apple Mail (2.3608.120.23.2.4) Subject: Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Jan 1, 2021, at 12:19 PM, Honnappa Nagarahalli = wrote: >>=20 >> 30/12/2020 20:09, Andrew Boyer: >>>=20 >>>> On Dec 23, 2020, at 6:47 AM, Juraj Linke=C5=A1 = >> wrote: >>>>=20 >>>> The current way of specifying Arm configuration options is >>>> insufficient since we can't identify the SoC we're building for = from >>>> the MIDR information. For example, we can't distinguish between >>>> N1SDP, Graviton2 or Ampere Altra. >>>>=20 >>>> Add a way to specify the cpu count and numa node count for cross >>>> builds and aarch64 -> aarch64 (SoC) builds. >>>>=20 >>>=20 >>> Hello Juraj, >>> This is great, you have solved a problem for me before I even knew >>> there was one. (We have two SoCs with the same id and pn, but >>> different core counts etc.) >>>=20 >>> Can anyone fill me in on how and when this patchset is going to be = taken? >> Will it go to dpdk-next-net, or to some other branch? >>=20 >> It should go in the main branch. >> I cannot commit on any date, but for sure it would help if you can do = a >> detailed review, thanks. > Testing on your SoC would be of great help. >=20 Hello Honnappa, Juraj, and Bruce, I've got most of the build working under meson. A few questions: 1) Bruce - when the =E2=80=9C-Ddefault_library=3Dboth=E2=80=9D flag is = passed in, the build fails with this error. It=E2=80=99s been broken for = a long time; maybe this option isn=E2=80=99t supported and should be = blocked earlier? ../../dpdk/app/meson.build:48:3: ERROR: Tried to get unknown = variable "both_rte_ethdev". 2) Is there a way to disable specific libraries? I=E2=80=99ve pruned = down the list of drivers, which is great. This feature existed under = make but I don=E2=80=99t see anything about it in meson yet. 3) We need to build kni against the aarch64 kernel headers, but it = fails. It appears that kernel/linux/kni/meson.build doesn=E2=80=99t pass = any cross-compile flags in the make command it creates. The diff below = shows how I hardcoded it to get it to work for now. Thoughts on how to = do this right? meson has the path (in $PATH) and the binary prefixs (in = =E2=80=98[binaries]=E2=80=99 in the cross file). It must know the arch, = too. --- a/kernel/linux/kni/meson.build +++ b/kernel/linux/kni/meson.build @@ -14,6 +14,8 @@ custom_target('rte_kni', input: kni_sources, output: 'rte_kni.ko', command: ['make', '-j4', '-C', kernel_dir + '/build', + = 'CROSS_COMPILE=3D/tool/toolchain/aarch64-1.1/bin/aarch64-linux-gnu-', + 'ARCH=3Daarch64', 'M=3D' + meson.current_build_dir(), 'src=3D' + meson.current_source_dir(), 'MODULE_CFLAGS=3D-include ' + meson.source_root() + = '/config/rte_config.h' + I will try to get to a full review soon. Thank you, Andrew=