From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0056.outbound.protection.outlook.com [104.47.1.56]) by dpdk.org (Postfix) with ESMTP id 7FFBA1041; Wed, 13 Sep 2017 19:59:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=02Y15vy8Klw1XQZKvQT5kwu5WxXnwqOUqSorDO4+AgU=; b=RJLNiJXGi2k6Z3xJ5R2D+xZFTQsyiAqf9AMhdKSumS6l7/WgyGfjFM1vf6KFuUZMVNGCtt3d8QXSfzw6CbfUnspuI6pGo0lQZvbL80dT7YsK1t2PlEPDx2EkbIJCEIi3iyq9sZkR0rzzQwLZjBhHEGBznkARlWU10bZW5Vg1TUw= Received: from HE1PR0501MB2043.eurprd05.prod.outlook.com (10.167.245.149) by HE1PR0501MB2715.eurprd05.prod.outlook.com (10.172.131.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Wed, 13 Sep 2017 17:59:57 +0000 Received: from HE1PR0501MB2043.eurprd05.prod.outlook.com ([fe80::1c2b:6879:ec37:3bb2]) by HE1PR0501MB2043.eurprd05.prod.outlook.com ([fe80::1c2b:6879:ec37:3bb2%13]) with mapi id 15.20.0035.021; Wed, 13 Sep 2017 17:59:56 +0000 From: Yongseok Koh To: Shahaf Shuler CC: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition Thread-Index: AQHTLH4oqIh4MRDlLU6qpNkRFc4rxaKzGzmA Date: Wed, 13 Sep 2017 17:59:56 +0000 Message-ID: <2CEDC921-AE45-4A58-84A5-B2477ADA9DFD@mellanox.com> References: <7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2715; 6:WaYHrlHg5odb+P3zTEBMuB3A0J69vdkt22/YKc3k4v87RW7JT6J2z7hwsj0GPiXbUVJgXc5LMPr4q1ETmqB3pcnOYNCV7d9P/XuIC18I/jX6Z3v3+3fAuiGQx29wdGZoU/a5fKF0uF9u1AX/Dne7WEBMpExADMcBeznpKxE7LGVORTFt5bYJUzQoAIoRfkdyZdKrUsA20EFcqWoeMMma0sE2LXeL1NCR1XMBoLIArFcsckm6B2TmiWRItTK+NObv5JI9ftc4gL5HWfYBC9dEs8zHJKdGflup4flbFYqLZx+FP8AR8GP/peVJ28+eNEGzMkgWIFZk9KZ3Ql1vmJwdKQ==; 5:adRRf+xwYEHjRe+TL4Fp4HsPX5nMCa5WvtU5rnSJPriLUu9PK9WhfGHUduVhCo2Auc9cma2J3ihzJpxc1RlZcuy19MyCmEBrz2WRPwYy9o2oSaLpoaNxJuKkhvGE+0MVPQOzNajKMK1VSH0TaqFaJA==; 24:bkGSfJKdSNEx1hwrHcG5YuAZO5ZH7bLkyqVTk675HEp0wfMUToCpy2UYryrbKSuCnYQU30JQF9Tb44FmxoFxdI0J0VmyU4p2v9t7r8TviHU=; 7:xZZlHkh7i0/XA0f+DB9mQKEbzaOoOCiCaucYf0O5RYYPAUWz68CUljTLwzGb70KOV90tpcTGLDLBIh+jZWKmCGORuJmjKTYXd6XTr9O5Mp9Y8MLFrBwFVK7gJhsrm5ip84uE4K+jfZEoqYqWa722A0WlcnjJWuG5rVJMXGlk4CkJsvZR5ukM9gwDK1KWrsqOBYUUBfr/QSb4wVAXZIGsccdl+ATt/aK3dun3vle4qPA= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: ffc318ab-70e1-4e55-79b4-08d4fad13e7e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:HE1PR0501MB2715; x-ms-traffictypediagnostic: HE1PR0501MB2715: x-exchange-antispam-report-test: UriScan:(788757137089); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0501MB2715; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0501MB2715; x-forefront-prvs: 042957ACD7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(377454003)(24454002)(199003)(189002)(97736004)(4326008)(305945005)(82746002)(7736002)(2950100002)(5660300001)(99286003)(106356001)(54906002)(6512007)(101416001)(36756003)(110136004)(50986999)(66066001)(6862004)(54356999)(25786009)(53936002)(5250100002)(76176999)(6246003)(86362001)(33656002)(229853002)(53546010)(189998001)(3280700002)(6506006)(83716003)(3660700001)(6436002)(81166006)(81156014)(8676002)(105586002)(8936002)(6486002)(316002)(6636002)(14454004)(2906002)(2900100001)(102836003)(478600001)(6116002)(3846002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2715; H:HE1PR0501MB2043.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2017 17:59:56.9042 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2715 Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/mlx5: fix Tx stats error counter definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 18:00:00 -0000 > On Sep 13, 2017, at 3:50 AM, Shahaf Shuler wrote: >=20 > The current Tx error counter counts, according to its description, > the total number of packets not sent when TX ring full. It is reported > to application as part of oerrors field. >=20 > The drop due to full ring is not the statistic that should be set on > oerrors field. Such number can be counted by the application using the > return value of the Tx burst function. > The number that should be set there is the number of packets the device > could not transmit in any way, even when it has resources. >=20 > Therefore, replace this counter to count the total number of failed > transmitted packets. >=20 > Fixes: 87011737b715 ("mlx5: add software counters") > Cc: stable@dpdk.org > Cc: adrien.mazarguil@6wind.com >=20 > Signed-off-by: Shahaf Shuler > --- Acked-by: Yongseok Koh