From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0060.outbound.protection.outlook.com [104.47.1.60]) by dpdk.org (Postfix) with ESMTP id 60CFE1B68B for ; Mon, 23 Oct 2017 20:54:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sRhVXoThWI3ahOhF4yvYToMs+mY5raV/q8GN8Bvakj4=; b=ksMS49QeJ5/XTqZB1/ftSp5DVBO0Ki9ve2iEY7Fv6mubaraS5XpTAKrNH5V8b7jCNg9U3jhRubQLW/4KYU3Ix3SYaG5dhUu7z4hoadX0BaiR0kvtFRWUQ5UijJe+0KPVout/vpcrg0X8qwEXFyEvkwHlQho2TeDAJMph/qm+oFo= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2048.eurprd05.prod.outlook.com (10.167.195.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Mon, 23 Oct 2017 18:54:33 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::9db8:1a11:e640:50c6]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::9db8:1a11:e640:50c6%13]) with mapi id 15.20.0156.007; Mon, 23 Oct 2017 18:54:33 +0000 From: Yongseok Koh To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "dev@dpdk.org" , Adrien Mazarguil Thread-Topic: [PATCH v3 3/3] net/mlx5: fix RSS hash update Thread-Index: AQHTS/ChI9wevu4YK0CCeRvtQZ5cjaLxyNcA Date: Mon, 23 Oct 2017 18:54:33 +0000 Message-ID: <2D2789DA-1BFB-464C-8E2E-C6D9503ED68A@mellanox.com> References: <120a5c8345cac22559f0bc95f9f256dae4664b4b.1508757360.git.nelio.laranjeiro@6wind.com> In-Reply-To: <120a5c8345cac22559f0bc95f9f256dae4664b4b.1508757360.git.nelio.laranjeiro@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2048; 6:CKNXSmcU7gWO1kW3wJEaV8A7OxqykvGS+yoZ70bZmZ7NaN1PhXcJiF2p1CooizQy6puEVsh1EAPqteXeGdSFh5GaP0KhJ8gINXSPdQ6hdXj+qWRcHs4F7C10zmJRcqpOORvANAce4ln2qe4reOW9GuOvVu9KIwPphvpV2e6dab3BzYIMJOGcbEbys9UFjvfFKZt1BKuOuVaBSuFOwNwFMCvpueHt5vVBKqYVgEpc00EkKUMKwpIlHejN2ZHa99t6KtO2sFGf5G1XaJs550AC8xoELNQGtvTDUojXlO4sqcwIkWRC3uGupgRXtOiyzlkuWwVe1txPT4reDiOPjhjTVg==; 5:w1mXCdO41UAi6bEha5MKlV35zI8UJ9AhTAGaAbM1qldRnrc4rBwQSY3W+5ewGgucNEfCTtCXU1gFJJOz76r5JQ2esWJ4NwTmQQ5OvzIPo+Dlauo7Km6wp2zDmERZYEquAi5Gdgc4idBmb7F2GypX3A==; 24:znwL4kU8ga8QoMoJYmdxfHfsvJSXZ2SKf9k3WMjdTMROpb0yJ5LY+VTdw6jKrQPTXmPCZvOeklBDDC448qW3kjfYFKqkPYGmG+27ix9KxiM=; 7:8b3KD+IXVPbPB+bgLCAvRjvq+SCFkUGgyZtxQdR+xBubc4aSDCl5tZRfUReOyM5nk7DsFK8XA0QUgNFxB/xA8VdZ7RNL6+ULx9my7RBFyK6ES8TVYME3xc/gOBDkBoaHkt6cfKIp4OBTi648QHDrjjO9COda/hhmfzLWpqyWy6Q2atN3wSIBAZ3Ep1BivdyiUHgtqw9WytXFnwzmEJuVr6SXz+mvtL9lDlD5Hrv0ZNQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 2cae06e5-2710-408c-f86e-08d51a478008 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:VI1PR0501MB2048; x-ms-traffictypediagnostic: VI1PR0501MB2048: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(3231020)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0501MB2048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0501MB2048; x-forefront-prvs: 046985391D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(199003)(24454002)(189002)(54356999)(2950100002)(5660300001)(7736002)(6916009)(76176999)(6486002)(305945005)(6506006)(36756003)(2906002)(6246003)(229853002)(66066001)(14454004)(25786009)(478600001)(5250100002)(97736004)(82746002)(53546010)(6436002)(68736007)(54906003)(50986999)(83716003)(33656002)(105586002)(53936002)(3280700002)(15650500001)(106356001)(86362001)(189998001)(6512007)(316002)(101416001)(99286003)(3660700001)(4326008)(102836003)(8676002)(6116002)(2900100001)(81156014)(81166006)(8936002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2048; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cae06e5-2710-408c-f86e-08d51a478008 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2017 18:54:33.4927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2048 Subject: Re: [dpdk-dev] [PATCH v3 3/3] net/mlx5: fix RSS hash update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 18:54:35 -0000 > On Oct 23, 2017, at 4:17 AM, Nelio Laranjeiro wrote: >=20 > Few bugs fixes in both configuration get and hash update where inputs are > not handled as expected by the ethdev layer. >=20 > RSS structure may not be totally usable, the PMD should try to take as mo= st > information from it has it can when it is an hash update or it should try > to fill as most as possible in the configuration get. > This means that in the RSS configuration structure, the memory space for > the RSS hash key may not be present, but the PMD should consider the hash > field valid and process/set it. >=20 > Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all prot= ocols") >=20 > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh =20 Thanks=