From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 858DE292D for ; Wed, 21 Jun 2017 16:27:51 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 21 Jun 2017 07:27:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,369,1493708400"; d="scan'208";a="1185288051" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 21 Jun 2017 07:27:50 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 21 Jun 2017 07:27:50 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.162]) by FMSMSX151.amr.corp.intel.com ([169.254.7.116]) with mapi id 14.03.0319.002; Wed, 21 Jun 2017 07:27:49 -0700 From: "Wiles, Keith" To: "Richardson, Bruce" CC: Thomas Monjalon , "gaetan.rivet@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH] mk: symlink every headers first Thread-Index: AQHS6gtF5qn+kpnNlEKRXg0eQ27wyqIvkxkAgABDQAA= Date: Wed, 21 Jun 2017 14:27:49 +0000 Message-ID: <2D791B20-6CAC-482D-811B-4B4829242710@intel.com> References: <20170620212139.9508-1-thomas@monjalon.net> <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170621102702.GA93468@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.193.120] Content-Type: text/plain; charset="us-ascii" Content-ID: <49586D35C7670B449C10180D9ABEDBCF@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH] mk: symlink every headers first X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 14:27:52 -0000 > On Jun 21, 2017, at 5:27 AM, Bruce Richardson wrote: >=20 > On Tue, Jun 20, 2017 at 11:21:39PM +0200, Thomas Monjalon wrote: >> If a library or a build tool uses a definition from a driver, >> there is a build ordering issue, like seen when moving PCI code >> into a bus driver. >>=20 >> One option is to keep PCI helpers and some common definitions in EAL. >> The other option is to symlink every headers at the beginning of >> the build so they can be included by any other component. >>=20 >> This patch shows how to achieve the second option. >>=20 >> Signed-off-by: Thomas Monjalon >> --- >=20 > My 2c. >=20 > This may be worth doing, however, two points to consider. >=20 > 1. If we look to change build system this may not be worth doing unless > a compelling need becomes obvious in the short term. In the meantime, > for cases where it is needed... > 2. libraries can already access the includes from drivers or other > places fairly easily, just by adding the relevant "-I" flag to the > CFLAGS for that lib. >=20 > That said, since the work is already done developing this, and if it > doesn't hurt in terms of build time, I suppose we might as well merge > it in. >=20 > So tentative ack from me, subject to testing and feedback from others. +1, I already have to make sure everything is symlinked first in my private= DPDK work for other reasons. This patch would allow me to remove that spec= ial code. >=20 > /Bruce Regards, Keith