From: "Yao, Lei A" <lei.a.yao@intel.com>
To: Jianbo Liu <jianbo.liu@linaro.org>,
"Xu, Qian Q" <qian.q.xu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] i40e: enable i40e pmd on ARM platform
Date: Wed, 10 Aug 2016 04:42:00 +0000 [thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D9502048BC8@shsmsx102.ccr.corp.intel.com> (raw)
Hi, Jianbo
I have tested you patch , this v3 patch didn't impact the performance on X86 platform.
Non-vector PMD single core performance with patch : ~35 Mpps
Non-vector PMD single core performance without patch : ~35 Mpps
BRs
Lei
-----Original Message-----
Date: Fri, 5 Aug 2016 14:36:23 +0530
From: Jianbo Liu <jianbo.liu@linaro.org>
To: dev@dpdk.org, helin.zhang@intel.com, jingjing.wu@intel.com
Cc: Jianbo Liu <jianbo.liu@linaro.org>
Subject: [dpdk-dev] [PATCH v3] i40e: enable i40e pmd on ARM platform
Message-ID: <1470387983-12713-1-git-send-email-jianbo.liu@linaro.org>
And add read memory barrier to avoid status inconsistency between two RX descriptors readings.
Signed-off-by: Jianbo Liu <jianbo.liu@linaro.org>
---
config/defconfig_arm64-armv8a-linuxapp-gcc | 2 +-
doc/guides/nics/features/i40e.ini | 1 +
drivers/net/i40e/i40e_rxtx.c | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/config/defconfig_arm64-armv8a-linuxapp-gcc b/config/defconfig_arm64-armv8a-linuxapp-gcc
index 1a17126..08f282b 100644
--- a/config/defconfig_arm64-armv8a-linuxapp-gcc
+++ b/config/defconfig_arm64-armv8a-linuxapp-gcc
@@ -46,6 +46,6 @@ CONFIG_RTE_EAL_IGB_UIO=n
CONFIG_RTE_LIBRTE_IVSHMEM=n
CONFIG_RTE_LIBRTE_FM10K_PMD=n
-CONFIG_RTE_LIBRTE_I40E_PMD=n
+CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=n
CONFIG_RTE_SCHED_VECTOR=n
diff --git a/doc/guides/nics/features/i40e.ini b/doc/guides/nics/features/i40e.ini
index fb3fb60..0d143bc 100644
--- a/doc/guides/nics/features/i40e.ini
+++ b/doc/guides/nics/features/i40e.ini
@@ -45,3 +45,4 @@ Linux UIO = Y
Linux VFIO = Y
x86-32 = Y
x86-64 = Y
+ARMv8 = Y
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 554d167..57825fb 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -994,6 +994,8 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq)
I40E_RXD_QW1_STATUS_SHIFT;
}
+ rte_smp_rmb();
+
/* Compute how many status bits were set */
for (j = 0, nb_dd = 0; j < I40E_LOOK_AHEAD; j++)
nb_dd += s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT);
--
2.4.11
next reply other threads:[~2016-08-10 4:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 4:42 Yao, Lei A [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-08-02 6:58 [dpdk-dev] [PATCH] " Jianbo Liu
2016-08-05 9:06 ` [dpdk-dev] [PATCH v3] " Jianbo Liu
2016-09-23 1:13 ` Zhang, Qi Z
2016-09-27 13:39 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DBBFF226F7CF64BAFCA79B681719D9502048BC8@shsmsx102.ccr.corp.intel.com \
--to=lei.a.yao@intel.com \
--cc=dev@dpdk.org \
--cc=jianbo.liu@linaro.org \
--cc=jingjing.wu@intel.com \
--cc=qian.q.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).