From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 782E02A5E for ; Mon, 7 Nov 2016 16:05:45 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 07 Nov 2016 07:05:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,606,1473145200"; d="scan'208";a="28309684" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 07 Nov 2016 07:05:43 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 7 Nov 2016 07:05:44 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 7 Nov 2016 07:05:43 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Mon, 7 Nov 2016 23:05:41 +0800 From: "Yao, Lei A" To: Yuanhan Liu , "dev@dpdk.org" CC: Thomas Monjalon , "Tan, Jianfeng" , Kevin Traynor , Ilya Maximets , Kyle Larose , Maxime Coquelin Thread-Topic: [dpdk-dev] [PATCH v2 00/10] net/virtio: fix queue reconfigure issue Thread-Index: AQHSN0i7TjO3yoqs7EytmTCtBPjrpqDNoSYw Date: Mon, 7 Nov 2016 15:05:40 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D9537F245C2@shsmsx102.ccr.corp.intel.com> References: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com> <1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com> In-Reply-To: <1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 00/10] net/virtio: fix queue reconfigure issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 15:05:47 -0000 Tested-by: Lei Yao - Apply patch to v16.11-rc2 - Compile: Pass - OS: Ubuntu16.04 4.4.0-45-generic - GCC: 5.4.0 Most of the basic Virtio related test cases are tested with this patch. No = function issue found and no obvious performance drop. The following is the = pass case list: TC1:=A0 vhost/virtio PVP vector performance =A0=A0=A0=A0=A0 TC2:=A0 vhost/virtio PVP normal path performance=20 TC3:=A0 vhost/virtio PVP mergeable path performance=20 TC7: vhost/virtio-net PVP ipv4 fwd normal path performance TC8: vhost/virtio-net PVP ipv4 fwd mergeable path performance TC9: vhost/virtio-net VM2VM iperf with TSO enabled performance TC11: vhost/virtio-pmd PVP with 2q 2c vector performance TC12: vhost/virtio-pmd PVP with 2q 1c vector performance TC16: vhost/virtio1.0 PVP normal performance TC17: vhost/virtio 1.0 PVP mergeable performance TC18: vhost/virtio 1.0 PVP vector performance(should be same as normal) TC19: dpdk vhost + virtio-pmd PVP vector performance TC20: dpdk vhost + virtio-pmd PVP non-vector performance TC21: dpdk vhost + virtio-pmd PVP mergeable performance TC25: Test Vhost/virtio-pmd PVP vector performance with qemu2.5 TC26: Test Vhost/virtio-pmd PVP vector performance with qemu2.6 TC27: Test Vhost/virtio-pmd PVP vector performance with qemu2.7 test vhost-user reconnect with virtio-pmd test virtio-pmd reconnect with vhost-user=20 test vhost-user reconnect with multi virtio-pmd multi test virtio-pmd reconnect with vhost-user -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yuanhan Liu Sent: Saturday, November 5, 2016 5:41 PM To: dev@dpdk.org Cc: Thomas Monjalon ; Tan, Jianfeng ; Kevin Traynor ; Ilya Maximets ; Kyle Larose ; Maxime Coquelin ; Yuanhan Liu Subject: [dpdk-dev] [PATCH v2 00/10] net/virtio: fix queue reconfigure issu= e This patchset fixes few issues related to virtio queue reconfigure: increase or shrink the queue number. The major issue and the reason behind = is described with length details in patch 4 "net/virtio: allocate queue at = init stage". Those bugs can not be fixed by few lines of code, it's because the current = driver init logic is quite wrong, that I need change quite many places to m= ake it right. Meanwhile, I have already done my best to keep the changes be= ing as minimal as possible, so that we could have fewer changes to break so= mething else; also, it's would be easier for review. v2: - fix two more minor issues regarding to queue enabling; see patch 9 and 10. - refined commit log a bit. Thanks. --yliu --- Yuanhan Liu (10): net/virtio: revert fix restart net/virtio: simplify queue memzone name net/virtio: simplify queue allocation net/virtio: allocate queue at init stage net/virtio: initiate vring at init stage net/virtio: move queue configure code to proper place net/virtio: complete init stage at the right place net/virtio: remove started field net/virtio: fix less queues being enabled issue net/virtio: fix multiple queue enabling drivers/net/virtio/virtio_ethdev.c | 248 +++++++++++++++++-------------- = drivers/net/virtio/virtio_ethdev.h | 16 -- drivers/net/virtio/virtio_pci.h | 3 +- drivers/net/virtio/virtio_rxtx.c | 291 ++++++++++++---------------------= ---- drivers/net/virtio/virtqueue.h | 7 + 5 files changed, 237 insertions(+), 328 deletions(-) -- 1.9.0