From: "Yao, Lei A" <lei.a.yao@intel.com>
To: "Ma, Liang J" <liang.j.ma@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ktraynor@redhat.com" <ktraynor@redhat.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH v10 1/4] lib/librte_power: traffic pattern aware power control
Date: Fri, 12 Oct 2018 01:59:11 +0000 [thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D9544FFB1A9@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1538488107-7181-1-git-send-email-liang.j.ma@intel.com>
+
+ if (get_freq_index(LOW) > total_avail_freqs[i])
+ return -1;
+
+ if (rte_get_master_lcore() != i) {
+ w->wrk_stats[i].lcore_id = i;
+ set_policy(&w->wrk_stats[i], policy);
+ }
+ }
+
+ return 0;
+}
Hi, Liang
There is one issue in this part.
When you find one frequency level can't be support on the server
we used, you return directly. This will skip the set_policy step in the following.
If skip the set_policy step, the behavior will be the power lib always
execute the training steps, even we set the policy.state=MED_NORMAL in the sample.
This will confuse the user, they don’t know why they can't skip the training steps even
the sample is already configured to --empty-poll=0,xxxxx,xxxxxx
BRs
Lei
next prev parent reply other threads:[~2018-10-12 1:59 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 9:57 [dpdk-dev] [PATCH v1 1/2] " Liang Ma
2018-06-08 9:57 ` [dpdk-dev] [PATCH v1 2/2] examples/l3fwd-power: simple app update to support new API Liang Ma
2018-06-19 10:31 ` Hunt, David
2018-06-08 15:26 ` [dpdk-dev] [PATCH v2 1/2] lib/librte_power: traffic pattern aware power control Liang Ma
2018-06-08 15:26 ` [dpdk-dev] [PATCH v2 2/2] examples/l3fwd-power: simple app update to support new API Liang Ma
2018-06-20 14:44 ` [dpdk-dev] [PATCH v3 1/2] lib/librte_power: traffic pattern aware power control Liang Ma
2018-06-20 14:44 ` [dpdk-dev] [PATCH v3 2/2] examples/l3fwd-power: simple app update to support new API Liang Ma
2018-06-26 11:40 ` [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control Radu Nicolau
2018-06-26 11:40 ` [dpdk-dev] [PATCH v4 2/2] examples/l3fwd-power: simple app update to support new API Radu Nicolau
2018-06-26 13:03 ` Hunt, David
2018-06-26 13:03 ` [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control Hunt, David
2018-06-27 17:33 ` Kevin Traynor
2018-07-05 14:45 ` Liang, Ma
2018-07-12 17:30 ` Thomas Monjalon
2018-09-11 9:19 ` Hunt, David
2018-09-13 9:46 ` Kevin Traynor
2018-09-13 13:30 ` Liang, Ma
2018-07-10 16:04 ` [dpdk-dev] [PATCH v5 " Radu Nicolau
2018-07-10 16:04 ` [dpdk-dev] [PATCH v5 2/2] examples/l3fwd-power: simple app update to support new API Radu Nicolau
2018-08-31 15:04 ` [dpdk-dev] [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control Liang Ma
2018-08-31 15:04 ` [dpdk-dev] [PATCH v6 2/4] examples/l3fwd-power: simple app update for new API Liang Ma
2018-08-31 15:04 ` [dpdk-dev] [PATCH v6 3/4] doc/guides/proguides/power-man: update the power API Liang Ma
2018-08-31 15:04 ` [dpdk-dev] [PATCH v6 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update Liang Ma
2018-09-04 1:11 ` [dpdk-dev] [PATCH v6 1/4] lib/librte_power: traffic pattern aware power control Yao, Lei A
2018-09-04 2:09 ` Yao, Lei A
2018-09-04 14:10 ` [dpdk-dev] [PATCH v7 " Liang Ma
2018-09-04 14:10 ` [dpdk-dev] [PATCH v7 2/4] examples/l3fwd-power: simple app update for new API Liang Ma
2018-09-04 14:10 ` [dpdk-dev] [PATCH v7 3/4] doc/guides/proguides/power-man: update the power API Liang Ma
2018-09-04 14:10 ` [dpdk-dev] [PATCH v7 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update Liang Ma
2018-09-13 10:54 ` [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control Kevin Traynor
2018-09-13 13:37 ` Liang, Ma
2018-09-13 14:05 ` Hunt, David
2018-09-17 13:30 ` [dpdk-dev] [PATCH v8 " Liang Ma
2018-09-17 13:30 ` [dpdk-dev] [PATCH v8 2/4] examples/l3fwd-power: simple app update for new API Liang Ma
2018-09-28 11:19 ` Hunt, David
2018-10-02 10:18 ` Liang, Ma
2018-09-17 13:30 ` [dpdk-dev] [PATCH v8 3/4] doc/guides/proguide/power-man: update the power API Liang Ma
2018-09-25 12:31 ` Kovacevic, Marko
2018-09-25 12:44 ` Kovacevic, Marko
2018-09-28 12:30 ` Hunt, David
2018-09-17 13:30 ` [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update Liang Ma
2018-09-25 13:20 ` Kovacevic, Marko
2018-09-28 12:43 ` Hunt, David
2018-09-28 12:52 ` Liang, Ma
2018-09-28 10:47 ` [dpdk-dev] [PATCH v8 1/4] lib/librte_power: traffic pattern aware power control Hunt, David
2018-10-02 10:13 ` Liang, Ma
2018-09-28 14:58 ` [dpdk-dev] [PATCH v9 " Liang Ma
2018-09-28 14:58 ` [dpdk-dev] [PATCH v9 2/4] examples/l3fwd-power: simple app update for new API Liang Ma
2018-09-28 14:58 ` [dpdk-dev] [PATCH v9 3/4] doc/guides/pro_guide/power-man: update the power API Liang Ma
2018-10-02 13:48 ` [dpdk-dev] [PATCH v10 1/4] lib/librte_power: traffic pattern aware power control Liang Ma
2018-10-02 13:48 ` [dpdk-dev] [PATCH v10 2/4] examples/l3fwd-power: simple app update for new API Liang Ma
2018-10-02 14:23 ` Hunt, David
2018-10-02 13:48 ` [dpdk-dev] [PATCH v10 3/4] doc/guides/pro_guide/power-man: update the power API Liang Ma
2018-10-02 14:24 ` Hunt, David
2018-10-02 13:48 ` [dpdk-dev] [PATCH v10 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: update Liang Ma
2018-10-02 14:25 ` Hunt, David
2018-10-02 14:22 ` [dpdk-dev] [PATCH v10 1/4] lib/librte_power: traffic pattern aware power control Hunt, David
2018-10-12 1:59 ` Yao, Lei A [this message]
2018-10-12 10:02 ` Liang, Ma
2018-10-12 13:22 ` Yao, Lei A
2018-10-19 10:23 ` [dpdk-dev] [PATCH v11 1/5] " Liang Ma
2018-10-19 10:23 ` [dpdk-dev] [PATCH v11 2/5] examples/l3fwd-power: simple app update for new API Liang Ma
2018-10-19 10:23 ` [dpdk-dev] [PATCH v11 3/5] doc/guides/pro_guide/power-man: update the power API Liang Ma
2018-10-19 10:23 ` [dpdk-dev] [PATCH v11 5/5] doc: update release notes for empty poll library Liang Ma
2018-10-19 11:07 ` [dpdk-dev] [PATCH v12 1/5] lib/librte_power: traffic pattern aware power control Liang Ma
2018-10-19 11:07 ` [dpdk-dev] [PATCH v12 2/5] examples/l3fwd-power: simple app update for new API Liang Ma
2018-10-19 11:07 ` [dpdk-dev] [PATCH v12 3/5] doc/guides/pro_guide/power-man: update the power API Liang Ma
2018-10-19 11:07 ` [dpdk-dev] [PATCH v12 4/5] doc/guides/sample_app_ug/l3_forward_power_man.rst: update Liang Ma
2018-10-19 11:07 ` [dpdk-dev] [PATCH v12 5/5] doc: update release notes for empty poll library Liang Ma
2018-10-22 12:41 ` Kovacevic, Marko
2018-10-25 23:39 ` Thomas Monjalon
2018-10-25 23:22 ` [dpdk-dev] [PATCH v12 1/5] lib/librte_power: traffic pattern aware power control Thomas Monjalon
2018-10-25 23:32 ` Thomas Monjalon
2018-10-25 23:54 ` Thomas Monjalon
2018-10-25 23:55 ` Thomas Monjalon
2018-10-26 13:34 ` Liang, Ma
2018-10-01 10:06 ` [dpdk-dev] [PATCH v9 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update Liang Ma
2018-06-14 10:59 ` [dpdk-dev] [PATCH v1 1/2] lib/librte_power: traffic pattern aware power control Hunt, David
2018-06-18 16:11 ` Liang, Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DBBFF226F7CF64BAFCA79B681719D9544FFB1A9@shsmsx102.ccr.corp.intel.com \
--to=lei.a.yao@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=liang.j.ma@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).