DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yao, Lei A" <lei.a.yao@intel.com>
To: "Hunt, David" <david.hunt@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power: fix no PCI option for guest cli
Date: Wed, 30 Oct 2019 01:09:27 +0000	[thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D95497CF9BF@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20191029114013.22803-1-david.hunt@intel.com>



> -----Original Message-----
> From: Hunt, David <david.hunt@intel.com>
> Sent: Tuesday, October 29, 2019 7:40 PM
> To: dev@dpdk.org
> Cc: Yao, Lei A <lei.a.yao@intel.com>; Hunt, David <david.hunt@intel.com>
> Subject: [PATCH v1] examples/vm_power: fix no PCI option for guest cli
> 
> If there are no ports available to the guest cli application, it will exit when
> setting up the default policy because it fails to set the mac address. This
> should not be the case, as this example can be used for many other use
> cases that do not need ports.
> 
> If ports not found, simply set nb_mac_to_monitor in the policy to zero and
> continue.
> 
> Fixes: 70febdcfd60f ("examples: check status of getting MAC address")
> Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Lei Yao <lei.a.yao@intel.com>
> ---
>  examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> index eb0ae9114..96c1a1ff6 100644
> --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> @@ -79,9 +79,9 @@ set_policy_defaults(struct channel_packet *pkt)
> 
>  	ret = set_policy_mac(0, 0);
>  	if (ret != 0)
> -		return ret;
> -
> -	pkt->nb_mac_to_monitor = 1;
> +		pkt->nb_mac_to_monitor = 0;
> +	else
> +		pkt->nb_mac_to_monitor = 1;
> 
>  	pkt->t_boost_status.tbEnabled = false;
> 
> --
> 2.17.1


  reply	other threads:[~2019-10-30  1:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 11:40 David Hunt
2019-10-30  1:09 ` Yao, Lei A [this message]
2019-11-12  7:29   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2DBBFF226F7CF64BAFCA79B681719D95497CF9BF@shsmsx102.ccr.corp.intel.com \
    --to=lei.a.yao@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).