From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0053.outbound.protection.outlook.com [104.47.2.53]) by dpdk.org (Postfix) with ESMTP id 33D31DE3 for ; Thu, 24 May 2018 20:33:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KDbB+nkVjNCGSNMZK/TNbIAD5+/voZm1FQZaCQ5t1Jg=; b=unHc3qOWSrW60gQWPaaQdReSRnxPVTvOF+77eqV1oi4WcJkDlWYIcnNFgbB8DgZQ+F4c0I14Rp46G2KlohmKF7gE6mGh+wiJ9EIRxEMLyg5m7A0IEUbVSPZ7Z89jgGesov5GYZ05HwniOl9oWVRSSGS3/guTc1HLGlLE1eyGblI= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2688.eurprd05.prod.outlook.com (10.172.15.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.776.11; Thu, 24 May 2018 18:33:15 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d%13]) with mapi id 15.20.0797.011; Thu, 24 May 2018 18:33:15 +0000 From: Yongseok Koh To: Adrien Mazarguil CC: Shahaf Shuler , "dev@dpdk.org" , "Xueming(Steven) Li" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix crash when configure is not called Thread-Index: AQHT842tw/zPWVhrWkyBPWic0SBOXg== Date: Thu, 24 May 2018 18:33:15 +0000 Message-ID: <2E4AE535-A917-49AA-97F1-91E3712434A9@mellanox.com> References: <20180524143535.29996-1-adrien.mazarguil@6wind.com> <69BE5B78-DAAA-4F84-A238-4E3BB8FF5B50@mellanox.com> In-Reply-To: <69BE5B78-DAAA-4F84-A238-4E3BB8FF5B50@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2688; 7:URs9WQJzg948vcimd++p0Rsnkck0vwj8cLJMnPb2MYnxm0dRP38I+301RUFFKNiQcvsTSfLmaw1SOgKcn9QN+obS9pJ1CBishfdONco7wPElMAbMM2sW0nqr1pu8s7MYfwt6XijrkL12T62BQDYoiduDNJBmpjZsXBTYGlWQGsRwjKvup9nH1Zktqj0CcFHf9A3PR/H0cVeHkPl6We6mLc2RcmkK4mEu37p+exiCDnvBY72V/crmt9LGXvHTt9/i x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2688; x-ms-traffictypediagnostic: VI1PR0501MB2688: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2688; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2688; x-forefront-prvs: 0682FC00E8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(366004)(39380400002)(346002)(189003)(199004)(4326008)(33656002)(5250100002)(66066001)(59450400001)(6512007)(53936002)(83716003)(99286004)(2616005)(6916009)(486006)(6436002)(316002)(6116002)(54906003)(2900100001)(86362001)(3846002)(446003)(11346002)(82746002)(476003)(6506007)(14454004)(26005)(81156014)(2906002)(478600001)(229853002)(76176011)(102836004)(3280700002)(36756003)(105586002)(53546011)(6486002)(305945005)(68736007)(81166006)(8936002)(3660700001)(97736004)(6246003)(7736002)(25786009)(107886003)(106356001)(186003)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2688; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: e3QdF5l/+BiknmAFDotK/7k9Ts0hJGT9W0TXEenVk3945Fgex4ni1v32cef46eIIVhfNTXiCTbkAOTaONNb6CioNuzB/N1kPnaHpb3v/2vGJ2nLykXGUoLAcTdy2VDyZ626MKuINzyUltuoMsU6P+CgWUtsc10gWpeadDBcYx2lI1y9jXPaQV9SmvbEtd78/ spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <61A8EC2B9CAECD42B2AA0BC25143627D@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 100b7427-28fc-41fc-b1c3-08d5c1a4d010 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 100b7427-28fc-41fc-b1c3-08d5c1a4d010 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2018 18:33:15.1876 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2688 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix crash when configure is not called X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 18:33:16 -0000 > On May 24, 2018, at 11:21 AM, Yongseok Koh wrote: >=20 >=20 >> On May 24, 2018, at 7:36 AM, Adrien Mazarguil wrote: >>=20 >> Although uncommon, applications may destroy a device immediately after >> probing it without going through dev_configure() first. >>=20 >> This patch addresses a crash which occurs when mlx5_dev_close() calls >> mlx5_mr_release() due to an uninitialized entry in the private structure= . >>=20 >> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") >> Cc: Yongseok Koh >>=20 >> Signed-off-by: Adrien Mazarguil >> --- > Acked-by: Yongseok Koh And you might want to write the same patch for mlx4. Thanks, Yongseok=