From: "Wiles, Keith" <keith.wiles@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: pktmbuf pool create helper for specific mempool ops
Date: Fri, 22 Dec 2017 13:53:13 +0000 [thread overview]
Message-ID: <2EF32BD2-5F89-48BA-B9DB-10C09BD33297@intel.com> (raw)
In-Reply-To: <1513942211-8314-1-git-send-email-hemant.agrawal@nxp.com>
> On Dec 22, 2017, at 5:30 AM, Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Introduce a new helper for pktmbuf pool, which will allow
> the application to optionally specify the mempool ops name
> as well.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> This change was discussed in the
> "doc: announce ABI change for pktmbuf pool create API"
> http://dpdk.org/dev/patchwork/patch/32306/
>
> lib/librte_mbuf/rte_mbuf.c | 24 ++++++++++++++++++------
> lib/librte_mbuf/rte_mbuf.h | 42 ++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 60 insertions(+), 6 deletions(-)
>
This patch looks good to me, but you forgot the MAP file patch to add the new API.
Regards,
Keith
next prev parent reply other threads:[~2017-12-22 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 11:30 Hemant Agrawal
2017-12-22 13:53 ` Wiles, Keith [this message]
2018-01-16 14:52 ` Olivier Matz
2018-01-16 14:59 ` Wiles, Keith
2018-01-17 5:29 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2EF32BD2-5F89-48BA-B9DB-10C09BD33297@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).