From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3E2A71B379 for ; Fri, 22 Dec 2017 14:53:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2017 05:53:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,441,1508828400"; d="scan'208";a="13887860" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 22 Dec 2017 05:53:14 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 22 Dec 2017 05:53:14 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.21]) by fmsmsx123.amr.corp.intel.com ([169.254.7.83]) with mapi id 14.03.0319.002; Fri, 22 Dec 2017 05:53:14 -0800 From: "Wiles, Keith" To: Hemant Agrawal CC: "dev@dpdk.org" , "olivier.matz@6wind.com" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [PATCH] mbuf: pktmbuf pool create helper for specific mempool ops Thread-Index: AQHTexhpZYuBh1S9vUOi9Cfgc48vHaNP6FSA Date: Fri, 22 Dec 2017 13:53:13 +0000 Message-ID: <2EF32BD2-5F89-48BA-B9DB-10C09BD33297@intel.com> References: <1513942211-8314-1-git-send-email-hemant.agrawal@nxp.com> In-Reply-To: <1513942211-8314-1-git-send-email-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.0.10] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mbuf: pktmbuf pool create helper for specific mempool ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 13:53:16 -0000 > On Dec 22, 2017, at 5:30 AM, Hemant Agrawal wrot= e: >=20 > Introduce a new helper for pktmbuf pool, which will allow > the application to optionally specify the mempool ops name > as well. >=20 > Signed-off-by: Hemant Agrawal > --- > This change was discussed in the=20 > "doc: announce ABI change for pktmbuf pool create API" > http://dpdk.org/dev/patchwork/patch/32306/ >=20 > lib/librte_mbuf/rte_mbuf.c | 24 ++++++++++++++++++------ > lib/librte_mbuf/rte_mbuf.h | 42 +++++++++++++++++++++++++++++++++++++++++= + > 2 files changed, 60 insertions(+), 6 deletions(-) >=20 This patch looks good to me, but you forgot the MAP file patch to add the n= ew API. Regards, Keith