From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D03B31E2B for ; Thu, 25 Oct 2018 09:02:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 00:02:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="102506349" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 25 Oct 2018 00:02:27 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 00:02:27 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Oct 2018 00:02:26 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.102]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0415.000; Thu, 25 Oct 2018 15:02:25 +0800 From: "Yan, Zhirun" To: "Ye, Xiaolong" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Xing, Beilei" Thread-Topic: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask Thread-Index: AQHUbCiR9SwXODYa40GQ5LpSWXIkIKUu8/GAgACTWhA= Date: Thu, 25 Oct 2018 07:02:24 +0000 Message-ID: <2F9759EBFF61914290A3BA61BDBE2C860B9977E4@SHSMSX101.ccr.corp.intel.com> References: <20181025134216.37416-1-zhirun.yan@intel.com> <20181025060845.GB55104@intel.com> In-Reply-To: <20181025060845.GB55104@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 07:02:32 -0000 > -----Original Message----- > From: Ye, Xiaolong > Sent: Thursday, October 25, 2018 2:09 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask >=20 > On 10/25, Zhirun Yan wrote: > >Tx offload mask is updated in following commit: > >commit 1037ed842c37 ("mbuf: fix Tx offload mask") Currently, the new > >added offload flags will be >=20 > s/will be/are Got it, I will modify in patch v2.=20 Thanks! >=20 > Thanks, > Xiaolong >=20 > >not supported in PMD and application will fail to call PMD transmit > >prepare function. > >This patch updates IXGBE_TX_OFFFLOAD_MASK. > > > >Fixes: b161f72107 ("mbuf: remove too specific flags mask") > >Signed-off-by: Zhirun Yan > >--- > > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c > >b/drivers/net/ixgbe/ixgbe_rxtx.c index e6f61c900..d6e971440 100644 > >--- a/drivers/net/ixgbe/ixgbe_rxtx.c > >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c > >@@ -58,6 +58,10 @@ > > #endif > > /* Bit Mask to indicate what bits required for building TX context */ > > #define IXGBE_TX_OFFLOAD_MASK ( \ > >+ PKT_TX_OUTER_IPV6 | \ > >+ PKT_TX_OUTER_IPV4| \ > >+ PKT_TX_IPV6 | \ > >+ PKT_TX_IPV4 | \ > > PKT_TX_VLAN_PKT | \ > > PKT_TX_IP_CKSUM | \ > > PKT_TX_L4_MASK | \ > >-- > >2.17.1 > >