* [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask
@ 2018-10-25 13:42 Zhirun Yan
2018-10-25 6:08 ` Ye Xiaolong
0 siblings, 1 reply; 3+ messages in thread
From: Zhirun Yan @ 2018-10-25 13:42 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, beilei.xing, Zhirun Yan
Tx offload mask is updated in following commit:
commit 1037ed842c37 ("mbuf: fix Tx offload mask")
Currently, the new added offload flags will be
not supported in PMD and application will fail to
call PMD transmit prepare function.
This patch updates IXGBE_TX_OFFFLOAD_MASK.
Fixes: b161f72107 ("mbuf: remove too specific flags mask")
Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
---
drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index e6f61c900..d6e971440 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -58,6 +58,10 @@
#endif
/* Bit Mask to indicate what bits required for building TX context */
#define IXGBE_TX_OFFLOAD_MASK ( \
+ PKT_TX_OUTER_IPV6 | \
+ PKT_TX_OUTER_IPV4| \
+ PKT_TX_IPV6 | \
+ PKT_TX_IPV4 | \
PKT_TX_VLAN_PKT | \
PKT_TX_IP_CKSUM | \
PKT_TX_L4_MASK | \
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask
2018-10-25 13:42 [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask Zhirun Yan
@ 2018-10-25 6:08 ` Ye Xiaolong
2018-10-25 7:02 ` Yan, Zhirun
0 siblings, 1 reply; 3+ messages in thread
From: Ye Xiaolong @ 2018-10-25 6:08 UTC (permalink / raw)
To: Zhirun Yan; +Cc: dev, qi.z.zhang, beilei.xing
On 10/25, Zhirun Yan wrote:
>Tx offload mask is updated in following commit:
>commit 1037ed842c37 ("mbuf: fix Tx offload mask")
>Currently, the new added offload flags will be
s/will be/are
Thanks,
Xiaolong
>not supported in PMD and application will fail to
>call PMD transmit prepare function.
>This patch updates IXGBE_TX_OFFFLOAD_MASK.
>
>Fixes: b161f72107 ("mbuf: remove too specific flags mask")
>Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
>---
> drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
>index e6f61c900..d6e971440 100644
>--- a/drivers/net/ixgbe/ixgbe_rxtx.c
>+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
>@@ -58,6 +58,10 @@
> #endif
> /* Bit Mask to indicate what bits required for building TX context */
> #define IXGBE_TX_OFFLOAD_MASK ( \
>+ PKT_TX_OUTER_IPV6 | \
>+ PKT_TX_OUTER_IPV4| \
>+ PKT_TX_IPV6 | \
>+ PKT_TX_IPV4 | \
> PKT_TX_VLAN_PKT | \
> PKT_TX_IP_CKSUM | \
> PKT_TX_L4_MASK | \
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask
2018-10-25 6:08 ` Ye Xiaolong
@ 2018-10-25 7:02 ` Yan, Zhirun
0 siblings, 0 replies; 3+ messages in thread
From: Yan, Zhirun @ 2018-10-25 7:02 UTC (permalink / raw)
To: Ye, Xiaolong; +Cc: dev, Zhang, Qi Z, Xing, Beilei
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, October 25, 2018 2:09 PM
> To: Yan, Zhirun <zhirun.yan@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask
>
> On 10/25, Zhirun Yan wrote:
> >Tx offload mask is updated in following commit:
> >commit 1037ed842c37 ("mbuf: fix Tx offload mask") Currently, the new
> >added offload flags will be
>
> s/will be/are
Got it, I will modify in patch v2.
Thanks!
>
> Thanks,
> Xiaolong
>
> >not supported in PMD and application will fail to call PMD transmit
> >prepare function.
> >This patch updates IXGBE_TX_OFFFLOAD_MASK.
> >
> >Fixes: b161f72107 ("mbuf: remove too specific flags mask")
> >Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> >---
> > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> >b/drivers/net/ixgbe/ixgbe_rxtx.c index e6f61c900..d6e971440 100644
> >--- a/drivers/net/ixgbe/ixgbe_rxtx.c
> >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> >@@ -58,6 +58,10 @@
> > #endif
> > /* Bit Mask to indicate what bits required for building TX context */
> > #define IXGBE_TX_OFFLOAD_MASK ( \
> >+ PKT_TX_OUTER_IPV6 | \
> >+ PKT_TX_OUTER_IPV4| \
> >+ PKT_TX_IPV6 | \
> >+ PKT_TX_IPV4 | \
> > PKT_TX_VLAN_PKT | \
> > PKT_TX_IP_CKSUM | \
> > PKT_TX_L4_MASK | \
> >--
> >2.17.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-25 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-25 13:42 [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask Zhirun Yan
2018-10-25 6:08 ` Ye Xiaolong
2018-10-25 7:02 ` Yan, Zhirun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).