From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 24B211E25 for ; Mon, 17 Dec 2018 04:12:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2018 19:12:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,363,1539673200"; d="scan'208";a="119013817" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 16 Dec 2018 19:12:35 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 16 Dec 2018 19:12:34 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 16 Dec 2018 19:12:34 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.201]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.203]) with mapi id 14.03.0415.000; Mon, 17 Dec 2018 11:12:33 +0800 From: "Yan, Zhirun" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Wang, Haiyue" Thread-Topic: [PATCH v4 1/2] net/i40e: support VF request more queues Thread-Index: AQHUk3rNK+jjHUtfT06LM0CXGtGMc6V9m/yAgASpejA= Date: Mon, 17 Dec 2018 03:12:32 +0000 Message-ID: <2F9759EBFF61914290A3BA61BDBE2C860B9DA94D@SHSMSX101.ccr.corp.intel.com> References: <20181213140505.14578-1-zhirun.yan@intel.com> <20181214143720.34163-1-zhirun.yan@intel.com> <20181214143720.34163-2-zhirun.yan@intel.com> <039ED4275CED7440929022BC67E70611532FEF79@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611532FEF79@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] net/i40e: support VF request more queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 03:12:36 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, December 14, 2018 8:00 PM > To: Yan, Zhirun ; dev@dpdk.org > Cc: Wang, Haiyue > Subject: RE: [PATCH v4 1/2] net/i40e: support VF request more queues >=20 >=20 >=20 > > -----Original Message----- > > From: Yan, Zhirun > > Sent: Friday, December 14, 2018 10:37 PM > > To: dev@dpdk.org; Zhang, Qi Z > > Cc: Yan, Zhirun ; Wang, Haiyue > > > > Subject: [PATCH v4 1/2] net/i40e: support VF request more queues > > > > Before this patch, VF gets a default number of queues from the PF. > > This patch enables VF to request a different number. When VF > > configures more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF > > to request more queues, if success, PF will reset the VF. > > > > User can run "port stop all", "port config port_id rxq/txq queue_num" > > and "port start all" to reconfigure queue number. > > > > Signed-off-by: Zhirun Yan > > Signed-off-by: Haiyue Wang > > --- > > drivers/net/i40e/i40e_ethdev_vf.c | 62 > > ++++++++++++++++++++++++++++++- > > 1 file changed, 60 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > > b/drivers/net/i40e/i40e_ethdev_vf.c > > index 05dc6596b..a568fb528 100644 > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > @@ -359,6 +359,25 @@ i40evf_execute_vf_cmd(struct rte_eth_dev *dev, > > struct vf_cmd_info *args) > > } while (i++ < MAX_TRY_TIMES); > > _clear_cmd(vf); > > break; > > + case VIRTCHNL_OP_REQUEST_QUEUES: > > + /*ignore async reply, only wait for system message,*/ > > + /*vf_reset =3D true if get > VIRTCHNL_EVENT_RESET_IMPENDING,*/ > > + /*if not, means request queues failed */ > > + err =3D -1; > > + do { > > + ret =3D i40evf_read_pfmsg(dev, &info); > > + vf->cmd_retval =3D info.result; > > + if (ret =3D=3D I40EVF_MSG_SYS && vf->vf_reset) { > > + err =3D 0; > > + break; > > + } else if (ret =3D=3D I40EVF_MSG_ERR) { >=20 > Base on patch 2/2, in the case some error happen for example that no more > free queue available, I40EVF_MSG_CMD will be returned. > I think it should be "else if (ret =3D=3D I40EVF_MSG_ERR || ret =3D=3D > I40EVF_MSG_CMD)" here So we don't need to wait until end of loop in that > case. Yes, I will modify it in the next version. Thanks. > > + break; > > + } > > + rte_delay_ms(ASQ_DELAY_MS); > > + /* If don't read msg or read sys event, continue */ > > + } while (i++ < MAX_TRY_TIMES); > > + _clear_cmd(vf); > > + break; > > > > default: > > /* for other adminq in running time, waiting the cmd done flag > */ > > @@ > > -1012,6 +1031,28 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t > vlanid) > > return err; > > } > > > > +static int > > +i40evf_request_queues(struct rte_eth_dev *dev, uint16_t num) { > > + struct i40e_vf *vf =3D > > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > > + struct virtchnl_vf_res_request vfres; > > + struct vf_cmd_info args; > > + int err; > > + > > + vfres.num_queue_pairs =3D num; > > + > > + args.ops =3D VIRTCHNL_OP_REQUEST_QUEUES; > > + args.in_args =3D (u8 *)&vfres; > > + args.in_args_size =3D sizeof(vfres); > > + args.out_buffer =3D vf->aq_resp; > > + args.out_size =3D I40E_AQ_BUF_SZ; > > + err =3D i40evf_execute_vf_cmd(dev, &args); > > + if (err) > > + PMD_DRV_LOG(ERR, "fail to execute command > > OP_REQUEST_QUEUES"); > > + > > + return err; > > +} > > + > > static int > > i40evf_del_vlan(struct rte_eth_dev *dev, uint16_t vlanid) { @@ > > -1516,8 > > +1557,11 @@ RTE_PMD_REGISTER_KMOD_DEP(net_i40e_vf, "* igb_uio | > > vfio-pci"); static int i40evf_dev_configure(struct rte_eth_dev *dev) > > { > > + struct i40e_vf *vf =3D > > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > > struct i40e_adapter *ad =3D > > I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > > + uint16_t num_queue_pairs =3D RTE_MAX(dev->data->nb_rx_queues, > > + dev->data->nb_tx_queues); > > > > /* Initialize to TRUE. If any of Rx queues doesn't meet the bulk > > * allocation or vector Rx preconditions we will reset it. > > @@ -1527,6 +1571,20 @@ i40evf_dev_configure(struct rte_eth_dev *dev) > > ad->tx_simple_allowed =3D true; > > ad->tx_vec_allowed =3D true; > > > > + if (num_queue_pairs > vf->vsi_res->num_queue_pairs) { > > + int ret =3D 0; > > + > > + PMD_DRV_LOG(INFO, "change queue pairs from %u to %u", > > + vf->vsi_res->num_queue_pairs, num_queue_pairs); > > + ret =3D i40evf_request_queues(dev, num_queue_pairs); > > + if (ret !=3D 0) > > + return ret; > > + > > + ret =3D i40evf_dev_reset(dev); > > + if (ret !=3D 0) > > + return ret; > > + } > > + > > return i40evf_init_vlan(dev); > > } > > > > @@ -2145,8 +2203,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, > > struct rte_eth_dev_info *dev_info) { > > struct i40e_vf *vf =3D > > I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > > > > - dev_info->max_rx_queues =3D vf->vsi_res->num_queue_pairs; > > - dev_info->max_tx_queues =3D vf->vsi_res->num_queue_pairs; > > + dev_info->max_rx_queues =3D I40E_MAX_QP_NUM_PER_VF; > > + dev_info->max_tx_queues =3D I40E_MAX_QP_NUM_PER_VF; > > dev_info->min_rx_bufsize =3D I40E_BUF_SIZE_MIN; > > dev_info->max_rx_pktlen =3D I40E_FRAME_SIZE_MAX; > > dev_info->hash_key_size =3D (I40E_VFQF_HKEY_MAX_INDEX + 1) * > > sizeof(uint32_t); > > -- > > 2.17.1