From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BCE7A04A3; Wed, 26 Jan 2022 17:53:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CAF342749; Wed, 26 Jan 2022 17:53:59 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2A03A42738; Wed, 26 Jan 2022 17:53:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643216037; x=1674752037; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=va+8bz7hFIORfoAH+hyj03I3KrWVvvFMWziEsbLjfSA=; b=VIup7te9NaXc/GiF24JcOMtF3vTwf9wlsA18MgexYhGU2YIXrilLlXcW PwEacmLc37ZGKVLnvM/RnDkY0l5J4hNREFjQsepjMgH2sT1Pg8orHaa5Y l6PgyaZfEudjkxdTwYWrtbvFq1SzgjyR36/NGDr9bO7Y1lbMquh9Yk6b2 NrH+Q7Km57EyKViIgeq/w+MosL9EwU+zFGPb593BWP27M4VDBQaMfZ94P 6Gcd3zLMstCai0kTnOAiAtBdppNHRXY/9cIA9YqhTqzTST5o2+uRte0hb Cp+2hpywqZojCQAdOMzFkn7xKpB6BnDsptkgpLIMSUlfIXZ1fRxJFGvbI w==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="246371451" X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="246371451" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 08:53:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="618018148" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jan 2022 08:53:55 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 08:53:55 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 26 Jan 2022 08:53:55 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 26 Jan 2022 08:53:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PjE7p29MDMHMlmu0USaoql3Ik+iffWcieZ6FYGILt/KjpSp3/muX+HyUBSF+F5t70YWOWa9WfbcJkBQIH5HQ3UkB3IulFsVs3iN0eieJnyZtz0tAmF3CqaQb2SNohjDY8MhLMffkKkASx/U7cmK102AWgUEkqCCsPAw0J2w7fdSW4KjesRNwMo34XobkNopgL6TmL4fKPqUL1f90DX8/HpNyeIzab4BnsEAlSPiHYqradoi5oHKB/8WQNP6DVyT4aUtiaSZrgxTPrKyHvF3n87iz2a4Phh1z6rQu1FEoShEOddAXQ5ITWdf+TwHFtZC2XFKuaH2dm59wznvaugezSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Kv2pXfT4V++2USRLAjDu4GPiRpWc2No4SxkIWcTF14=; b=kxlLRRIRAtmbzBUqDsZdGW+Uvb3gS1ZEkJUvrAHN5u8CNf6+q/EC0Zv1+8zxJy8dwR6nFDhincsU826obcDl3oup7t5jVQuZ20YyCaZrRwFGwjzmvj98iHgCg54uqyEdZf2AA3UEE2tLf1aOQ9OHwuex+P9MgtbwZhdlPinWGvb0nrSWTnV32G+QTP8A01H2ga5DSHJTGaV0onWOyG9jT2T1OSbOlKfaO/bAUz/uD38DTYzGyo1pTmXvmeLADR9bKBRKnq9ISFMDGd+WaxU0hZ5dZJEETht+Uw0JUNsyWQzSBoV/ZQmNXkTdikPm1bXp6DZfH3V/dLNzstsk4Q9How== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SA0PR11MB4686.namprd11.prod.outlook.com (2603:10b6:806:97::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Wed, 26 Jan 2022 16:53:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.019; Wed, 26 Jan 2022 16:53:53 +0000 Message-ID: <2a077cc2-578a-38c1-3318-a5e84fb3a9db@intel.com> Date: Wed, 26 Jan 2022 16:53:48 +0000 Subject: Re: [dpdk-dev] [PATCH] net/nfp: free HW rings memzone on queue release Content-Language: en-US To: , CC: , Simon Horman References: <20220119114800.6900-1-heinrich.kuhn@corigine.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220119114800.6900-1-heinrich.kuhn@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0163.eurprd04.prod.outlook.com (2603:10a6:10:2b0::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a98d6aca-eab0-4596-5950-08d9e0ec6f3d X-MS-TrafficTypeDiagnostic: SA0PR11MB4686:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:247; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AmAPjd7eLEKrsN6nuC4xEdstZRaupleQ2TtYogxGhPkasGHpebXltfp+4806vJmSjhybMEfOziBUSJihjLPCRSBtt7sjSQdeyw/GseOcpV6tLdLvdfbLyGklEcbn5vFOQT9DyoPnkBoaZzP2Mpy4Fdd/uM2XSdl85+ZU3sfAW8hnroPXtMYMIs0GRnCh3tqXc+qsHh1dIIAVQ+hs7Od2R0KaO/AxTobXFW4sNfsn6qUtpywqGjXOgV2lgny4xJIhfYeOD1EwRHg5OEpj9PWk+DTz6WPm3La04hAbl0xlwgn5XPO4kvmeGWCVzEHe969wsnoAcHKU5bdpalwb+uOBYa6m46Ln5xigfFb0uV9WMZtGKBnOBZr3Yak+fxXzeoOLqawgTb6ZssgSCDirzELW4aqLGoTxZCCFfLOQ2/ImeQaamMgX12hUDYX3Ecg7/59q16QX/ho6IwBNxRVhjkSq8/j3EzElDfK6W2lGd/QPOsNvi5lZUE/LsYu2w6iBCl5yxwwkRiWW5dYRSKEBS+LpHblbBR3UYiIIkpNN5WACtPFxR+lxrflLkkv+azVS1J5BBSe664mrTxgDE4+Fn9k6R5eKpvT9whniijNzK8Cjw51Cfp0yxeWNgaEdhZP0NaaWtS7NIvZ39EpbeLZwWVPaZbHhYDjBoeJj97LWRXiH2AapjXx7sRNR9eNBEkjg29GIy78qx8lu+1Du9bXVz8z2Bw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(6506007)(53546011)(6666004)(6486002)(86362001)(31696002)(83380400001)(2616005)(26005)(186003)(2906002)(38100700002)(4744005)(31686004)(5660300002)(6512007)(44832011)(82960400001)(8676002)(36756003)(66476007)(66556008)(66946007)(4326008)(316002)(8936002)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUFqVlFocXN6eFd3K2NiM2pic1F5UlBvdVBYY3NJb2tiWmRnRDVhcllJVzBU?= =?utf-8?B?dFJXYjM4SGFRWTJOUjdlMmhmUWVXd2pxenJJZ3k1Z1RLcDFSZGxRZG4yTlha?= =?utf-8?B?K2NXOTJRMVNrVmNHdDgyMWQycFU0WjJPazRDK3FEUTNEcnY5dTFHeDRsbjM5?= =?utf-8?B?eTBmWkZ1SW1rL2RncHo0bGNuRGVZbDRzUDZ2VVp0YU9WTnlJS1ozTEJyUmps?= =?utf-8?B?VmhHM1V5TFA3L2lqSmdabDVlRDh1QmFUbFRpMlVmME5DU2M3TDIzOUhoSTFK?= =?utf-8?B?em1nSnFxV2V3d2FsaEpsTC9yaEVFdEQ2cWZHRzg3NTZmNG13WGFoemhQdk5U?= =?utf-8?B?Zm9hcktVSGU3QXM5dXdBZ2dPQ1lGTE42KzBpRmFCeE5YUXFUZTIwZFRzZHBH?= =?utf-8?B?NW40R29uZGNsTHh5VWZSYkVYM0dhYXQzWU8yeGtKN1ptdlkrdGtlSm0vcFBz?= =?utf-8?B?RllDbENiSnBkbElFdjVLUmhCdi91RzJVM28yYjZLUldMdkp2RXVWV1R1bUpP?= =?utf-8?B?M29KTWpienhkdSswL2FCbXppTjRzTkViWCt2YXNRSjVPSkdzS0RGYitiNFBq?= =?utf-8?B?cnNnL09rckxvZXpkZmc0MTRyVlVLd1c0MW5nVkhFYnEwUWdhYUFuaDVBaVZV?= =?utf-8?B?RnIweGsySkppMll4MFhYbjFQTEhDMVJ2cW5mQmRnNWxEUnRVZ1hvQzRIYmdV?= =?utf-8?B?V0JzYXBPTHk1UmpYK09CUXRPYjNpMmQyMTJrbDRUVHFlWDhZSVhOSmxhNGYx?= =?utf-8?B?TWN1YkRHLzQ1SXBNbzNSMlp6bGpwOFhSSHl3WEJUTmt6L1BWUUV4VFhUV2xJ?= =?utf-8?B?U3VnM0Fub2pMNExNdnMxUnAvUGFwdlY1eHBZdjc1bytEanVSS0dCRzZzdnhF?= =?utf-8?B?cGdiMkZqYWZpU3M1YURTdEEzUTU3a0E5bjI1MDkxSWJWdFVMUkZlenFLRE5W?= =?utf-8?B?Y1JSMW5pOGkvdlczY0x6SzA1RXVQUFlFNGlsMDQ5TTR4QWRCRTJkb2hkYVNa?= =?utf-8?B?Y3ZwL1l1V3pyNTE1QTViUHlPcnNtR3k2RFlqRFMwTjh3L0V0V1JpY2orSk50?= =?utf-8?B?S2VibTRQSlFVaEdKWVRQU29nMjdGQUt5OUpRWTlOQ29MRTI5c0lER1ZQSytn?= =?utf-8?B?aWl6VUZVNWNnNkt5Q1ZrejdGb05WbmJmVFlWVFJMWEErcVc0cXBwRDBWVVo0?= =?utf-8?B?dTRpVTFXZzl4MUdyZE12Y2dMbDBqRHFoMVpKYkhsZnhiTTUrb3owU0w4SUpl?= =?utf-8?B?Sy81S0VmTXRObTk1aFlid0RkWGZwWkdrTXg3djlUVkN3cVBxYlphU00wcW5t?= =?utf-8?B?MndRbzNXQUszZ1dxV3JlN0UzMlY2ODZpV0NrWWRKbWpmNFpUZkpuNTNKOGNa?= =?utf-8?B?NWhOSnFNWnFjaFl2L29JMkZCbzlROWIwTk96aG1mQ1dRdnRSQ3M4Vnp1YUNF?= =?utf-8?B?dFk2MUNER09HU3NCa0JNa1E0ZzNVdW1rVkpzeDFLVDdSVHpHeDMzY0hkNU9r?= =?utf-8?B?eTJGTEJoRUFzNTg2Tkl6S0tXc3ZmVU1KWURiblVDaDZyTDNEcjZmaWQxdmhy?= =?utf-8?B?a0VsWlozTE1pdzNwTllQaEZhdjhHU29WWWhhSSs5Vk5rVk5tVjhXa1haekhx?= =?utf-8?B?amsvcDJHSGE3aStPVFE3V1pmaFl0TE1JN0kvNG9sWGN5Z2h0dWsvaFA5RWFW?= =?utf-8?B?S2pVR21uckNwbllzVUZxVW55RGtXck83NFhKNFVnSlZkdTFVbStuVlpGbHky?= =?utf-8?B?UGd1Z1lFdFRZNEdza2EyZTYzNDF1YUE0VEMxdlkzOW85Wk40YWNOL2htNXJX?= =?utf-8?B?Q3pwY1l1M3VrbmY5aFIwZnFrekt6RmxaZEFSSlJlSFRaWXJZcFpmQlF4L2hF?= =?utf-8?B?WHhjTUhyOUkvc0JCaXd6eU5mL0xQb1RJOVVsZnVnekx3UndZY2wyT05uU1JB?= =?utf-8?B?dFNSQkdiMWhWeEpsZlR5YUNUK1JKdUFHT1FUWXVKWE5HYmRndks2QjFDU2lE?= =?utf-8?B?aWpuM0R5YjRrRjc5aVlKMWw2NFNVNDRRYisvRjBxNDdqakhLT0xxcU1FUmJ5?= =?utf-8?B?TzJnR2o0L2JHRERnVmZHNSs4amJ3SE1WZGlwU2FpemxFYWRzT2FiVGE2S3ZU?= =?utf-8?B?dW9KZVcxVG5rT3JHNUE2QTNDMUk3ak5QcyttVTI4WnFGWHlidDRwNXVyMWJR?= =?utf-8?Q?8APG6MBqypSGe6hUHNdbeoM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a98d6aca-eab0-4596-5950-08d9e0ec6f3d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 16:53:53.6580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tnalddp8uoH2PDNzap6krE9/irSmviKyFOwgDb2P/C4TCs04IJl+R6rbBnIsUuidYv1VjXRe0WTYMF6Nt3L3NA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4686 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/19/2022 11:48 AM, heinrich.kuhn@corigine.com wrote: > From: Heinrich Kuhn > > During rx/tx queue setup, memory is reserved for the hardware rings. > This memory zone should subsequently be freed in the queue release > logic. This commit also adds a call to the release logic in the > dev_close() callback so that the ring memzone may be freed during port > close too. > > Fixes: b812daadad0d ("nfp: add Rx and Tx") > Cc: stable@dpdk.org > > Signed-off-by: Heinrich Kuhn > Signed-off-by: Simon Horman Applied to dpdk-next-net/main, thanks.