From: Tom Barbette <barbette@kth.se>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: bruce.richardson@intel.com, john.mcnamara@intel.com,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] rte_ethdev: Add API function to read dev clock
Date: Tue, 2 Apr 2019 21:24:58 +0200 [thread overview]
Message-ID: <2a24e0d9-eeea-ad32-cc86-4bae82574e03@kth.se> (raw)
In-Reply-To: <546fe66a-4183-7df1-4848-1357a52ac9f2@intel.com>
Le 02/04/2019 à 19:46, Ferruh Yigit a écrit :
>> +* **[implements] eth_dev_ops**: ``read_clock``.
>
> This means for a PMD to claim 'timestamp' support, it should implement the
> 'read_clock' dev_ops, is it really the case?
> Should we say 'related' instead of 'implements' ?
Ok for me. I guess this will depend on how another device vendor would
implement the feature.
>> + return eth_err(port_id, (*dev->dev_ops->read_clock)(dev,
>> + timestamp)); > Please fix the syntax.
Just one more tab for the second line, right? Multiple functions just
before have the same spacing. When in Rome...
> Can PMD return a fail?
MLX5's implementation may return any errno value, which are not defined
in the ibv API it is using. Not sure how I should address that in the
comment?
Thanks for the review! I directly addressed other comments in v3.
Tom
next prev parent reply other threads:[~2019-04-02 19:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 6:19 [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API Tom Barbette
2019-03-27 6:19 ` Tom Barbette
2019-03-27 6:19 ` [dpdk-dev] [PATCH v2 1/3] rte_ethdev: Add API function to read dev clock Tom Barbette
2019-03-27 6:19 ` Tom Barbette
2019-04-02 17:46 ` Ferruh Yigit
2019-04-02 17:46 ` Ferruh Yigit
2019-04-02 19:24 ` Tom Barbette [this message]
2019-04-02 19:24 ` Tom Barbette
2019-03-27 6:19 ` [dpdk-dev] [PATCH v2 2/3] mlx5: Implement support for read_clock Tom Barbette
2019-03-27 6:19 ` Tom Barbette
2019-04-02 17:47 ` Ferruh Yigit
2019-04-02 17:47 ` Ferruh Yigit
2019-04-02 18:26 ` Ferruh Yigit
2019-04-02 18:26 ` Ferruh Yigit
2019-04-02 19:05 ` Tom Barbette
2019-04-02 19:05 ` Tom Barbette
2019-04-03 5:28 ` Shahaf Shuler
2019-04-03 5:28 ` Shahaf Shuler
2019-03-27 6:19 ` [dpdk-dev] [PATCH v2 3/3] rxtx_callbacks: Add support for HW timestamp Tom Barbette
2019-03-27 6:19 ` Tom Barbette
2019-04-02 18:22 ` Ferruh Yigit
2019-04-02 18:22 ` Ferruh Yigit
2019-04-02 19:39 ` Tom Barbette
2019-04-02 19:39 ` Tom Barbette
2019-03-27 14:41 ` [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API Stephen Hemminger
2019-03-27 14:41 ` Stephen Hemminger
2019-03-27 14:48 ` Thomas Monjalon
2019-03-27 14:48 ` Thomas Monjalon
2019-03-27 14:54 ` Wiles, Keith
2019-03-27 14:54 ` Wiles, Keith
2019-03-27 16:08 ` Tom Barbette
2019-03-27 16:08 ` Tom Barbette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a24e0d9-eeea-ad32-cc86-4bae82574e03@kth.se \
--to=barbette@kth.se \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=olivier.matz@6wind.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).