From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-3.sys.kth.se (smtp-3.sys.kth.se [130.237.48.192]) by dpdk.org (Postfix) with ESMTP id DDDCD5F1B for ; Tue, 2 Apr 2019 21:25:03 +0200 (CEST) Received: from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-3.sys.kth.se (Postfix) with ESMTP id 9A9D858E9; Tue, 2 Apr 2019 21:25:03 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-3.sys.kth.se ([127.0.0.1]) by smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RFDhBUHixDZI; Tue, 2 Apr 2019 21:25:03 +0200 (CEST) X-KTH-Auth: barbette [83.249.19.162] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1554233103; bh=i1SNvvx6uF86+pL3c254L8uYmGGS7WEleS/Lmzhvw3c=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=NUsyJIB0a/s035EDH7B0uLcw+7xleqaJ0Y3qL3aVe/72IO5ITOBg4rqv8y+RV+vbb zerR/rhoDG9eJda19ag+QQzv/RCyKsusGyI0A+8WxhiZVMfCy4lIN1Gkrkx6cQUPwu QjXlQQAriTfYcCYLVvsFPUBV4GBlix4wyTOpETZQ= X-KTH-mail-from: barbette@kth.se Received: from [192.168.0.59] (c83-249-19-162.bredband.comhem.se [83.249.19.162]) by smtp-3.sys.kth.se (Postfix) with ESMTPSA id 96E855A07; Tue, 2 Apr 2019 21:25:00 +0200 (CEST) To: Ferruh Yigit , dev@dpdk.org Cc: bruce.richardson@intel.com, john.mcnamara@intel.com, Thomas Monjalon , Andrew Rybchenko , Shahaf Shuler , Yongseok Koh , Olivier MATZ References: <20190327061935.19572-1-barbette@kth.se> <20190327061935.19572-2-barbette@kth.se> <546fe66a-4183-7df1-4848-1357a52ac9f2@intel.com> From: Tom Barbette Message-ID: <2a24e0d9-eeea-ad32-cc86-4bae82574e03@kth.se> Date: Tue, 2 Apr 2019 21:24:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <546fe66a-4183-7df1-4848-1357a52ac9f2@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] rte_ethdev: Add API function to read dev clock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 19:25:04 -0000 Le 02/04/2019 à 19:46, Ferruh Yigit a écrit : >> +* **[implements] eth_dev_ops**: ``read_clock``. > > This means for a PMD to claim 'timestamp' support, it should implement the > 'read_clock' dev_ops, is it really the case? > Should we say 'related' instead of 'implements' ? Ok for me. I guess this will depend on how another device vendor would implement the feature. >> + return eth_err(port_id, (*dev->dev_ops->read_clock)(dev, >> + timestamp)); > Please fix the syntax. Just one more tab for the second line, right? Multiple functions just before have the same spacing. When in Rome... > Can PMD return a fail? MLX5's implementation may return any errno value, which are not defined in the ibv API it is using. Not sure how I should address that in the comment? Thanks for the review! I directly addressed other comments in v3. Tom From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6E830A0679 for ; Tue, 2 Apr 2019 21:25:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22D2C5F20; Tue, 2 Apr 2019 21:25:05 +0200 (CEST) Received: from smtp-3.sys.kth.se (smtp-3.sys.kth.se [130.237.48.192]) by dpdk.org (Postfix) with ESMTP id DDDCD5F1B for ; Tue, 2 Apr 2019 21:25:03 +0200 (CEST) Received: from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-3.sys.kth.se (Postfix) with ESMTP id 9A9D858E9; Tue, 2 Apr 2019 21:25:03 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-3.sys.kth.se ([127.0.0.1]) by smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RFDhBUHixDZI; Tue, 2 Apr 2019 21:25:03 +0200 (CEST) X-KTH-Auth: barbette [83.249.19.162] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1554233103; bh=i1SNvvx6uF86+pL3c254L8uYmGGS7WEleS/Lmzhvw3c=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=NUsyJIB0a/s035EDH7B0uLcw+7xleqaJ0Y3qL3aVe/72IO5ITOBg4rqv8y+RV+vbb zerR/rhoDG9eJda19ag+QQzv/RCyKsusGyI0A+8WxhiZVMfCy4lIN1Gkrkx6cQUPwu QjXlQQAriTfYcCYLVvsFPUBV4GBlix4wyTOpETZQ= X-KTH-mail-from: barbette@kth.se Received: from [192.168.0.59] (c83-249-19-162.bredband.comhem.se [83.249.19.162]) by smtp-3.sys.kth.se (Postfix) with ESMTPSA id 96E855A07; Tue, 2 Apr 2019 21:25:00 +0200 (CEST) To: Ferruh Yigit , dev@dpdk.org Cc: bruce.richardson@intel.com, john.mcnamara@intel.com, Thomas Monjalon , Andrew Rybchenko , Shahaf Shuler , Yongseok Koh , Olivier MATZ References: <20190327061935.19572-1-barbette@kth.se> <20190327061935.19572-2-barbette@kth.se> <546fe66a-4183-7df1-4848-1357a52ac9f2@intel.com> From: Tom Barbette Message-ID: <2a24e0d9-eeea-ad32-cc86-4bae82574e03@kth.se> Date: Tue, 2 Apr 2019 21:24:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <546fe66a-4183-7df1-4848-1357a52ac9f2@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] rte_ethdev: Add API function to read dev clock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402192458.3ZcrMLYM3TyHN9bnUknmXMxmSfyt_7q0SqVRa7GyE_Y@z> Le 02/04/2019 à 19:46, Ferruh Yigit a écrit : >> +* **[implements] eth_dev_ops**: ``read_clock``. > > This means for a PMD to claim 'timestamp' support, it should implement the > 'read_clock' dev_ops, is it really the case? > Should we say 'related' instead of 'implements' ? Ok for me. I guess this will depend on how another device vendor would implement the feature. >> + return eth_err(port_id, (*dev->dev_ops->read_clock)(dev, >> + timestamp)); > Please fix the syntax. Just one more tab for the second line, right? Multiple functions just before have the same spacing. When in Rome... > Can PMD return a fail? MLX5's implementation may return any errno value, which are not defined in the ibv API it is using. Not sure how I should address that in the comment? Thanks for the review! I directly addressed other comments in v3. Tom