From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A33F2425F0; Wed, 20 Sep 2023 14:35:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 525EF41101; Wed, 20 Sep 2023 14:35:50 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2040.outbound.protection.outlook.com [40.107.94.40]) by mails.dpdk.org (Postfix) with ESMTP id B33174027B; Wed, 20 Sep 2023 14:35:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSLncR7ttbUjLr2yt4U2HljvUnG+LtdncUB9MFM3HGldwSUJtivjLT29JMrImN0Ua3qo9/dJK1vLFTtQ5FndSciDt7c/ZbRwGX/3GuxEYDYYSqPGv7WuhNiVdIq7TFco0T+HZ+oBZTuUgnk4gKECxxtYvqrvbXtBzVpc5d2nBsfLvG5vTjyj/ejXn+uITivXDYjtpkMjywJbUy9IvXG4fb6vBRthutfRLLOUPPd+GyUfBWing4pWqHkKmNDj0PmHwh+rytZJSlurFFF5mz3maRHfQOOexvZnlc8RltyjtY6rUa6ZAzhE/9LosWT12z470Jqak5PaSra+HE7XP/wCKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3UtFbV4PzBjXmHTLVlnOaX8XMJe3QA8SrW9f6QKBp74=; b=UNPI676To0mWeVrLfxy+d9OBZsGspDFklGQRVXOjXE4SsS7mECvm9SQOPeW/kebR1aKS7wfa0AxS/oEYtVjtWjz51o4ociPD4uCCzlx2i8IjIpQ+0EiyCb9XvIqS3cwIBXHJVLmTKEIc90J7fg5bqg8cdAJZu1WHg7nDKEVkAcBwbTv+aI0SCtCK11E7Gk2VhKKqkE2LTtzv59BxBwbqdnOKByg7ktPf0Bujghn7u+YBefdoKDNtPniLrS4FgxCM8rjfYeED7yXIdfvHbrTZG2eY6/yzqSTh/FAE1G5n1qVbHklimcVZv1TGOVW04DPVM4RnYekjORz3zJr+Mdndjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UtFbV4PzBjXmHTLVlnOaX8XMJe3QA8SrW9f6QKBp74=; b=4aW/1FBRGqQ+RKGQWDDgo/I3hz6DE5VWs12zcUbICqiiapHGr6o6UMwifnqln4BEVTPzjcJtrIfd1camk2Vw1VqDFAmIRR9uZm94HKTy4/hOt3JER3oFEYR0vg42bZTPE3chPyAkNzlDg5K/VJwPWeka2jtsvxclHw7ENN1RRq0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5900.namprd12.prod.outlook.com (2603:10b6:208:398::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Wed, 20 Sep 2023 12:35:45 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Wed, 20 Sep 2023 12:35:45 +0000 Message-ID: <2a2dbe8d-3c63-4d3e-86bd-3ab4b0951118@amd.com> Date: Wed, 20 Sep 2023 13:35:39 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/nfp: fix invalid control message packets Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , stable@dpdk.org References: <20230713030217.1142257-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230713030217.1142257-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0128.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5900:EE_ X-MS-Office365-Filtering-Correlation-Id: 17579df8-9fa9-4d96-1c99-08dbb9d61c6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c2jD7SC2ZBykeDrCF0uPpCcowQNtlzvo+wK4ufLusM+JpxHylvNuKJQJywEAQeM46by7l1IipycIqTnJrHl0rnh2ivJkwVWpc/aGABuKXyJVJQKRyyk9X8ilpnykkAOiR5hsV5GiaTDbjd9zAinjY0yMC705M9D3qjnq+OQKh0ANhpNRXqnHz6M/yzSeJESlIrI1s5gZQ9La12kyFWLMIxYwGSWZpp/uMXiGRbiXlz+0JwphhRETvBJZ1oGNx3AEWgFlCT+VD8DmP351ATRdjExcWu8Scud4zSfEE93QWmSbic7qQQJMdCPCnK9RxTY1oKCz7mld+CApTBCgN8bTJkr9SSiNQD91MR/4sba7iI/53dCtWFROF2xJxIQX3xZcGNbaWuHC/A0nu2Z2qZssLVdizV1Y9PXOce6u1SRT6VkY31MlajQOZM2hWkRQlU6bebGWVbL5wZQ+zNbH2bm+mTH8XfYG5EyJU0/AEUZRmAaPiQyjO+zgLOP8oEyFRqDv8NwXbhEuWqJYJwKGPJZTpHGXQ9q/wkgYodfWYK+Mi/wEk/aCqr3UGySCtdfkvGWluLYHwVddFHObGBkydPjaJwVBMx2P7zoni0fmxfk3l/2UkWAnvkWkY6aRTSRaf/6ilVa/gsNFYIIkfgG13LsIcg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(396003)(376002)(39860400002)(346002)(1800799009)(186009)(451199024)(26005)(8936002)(2616005)(8676002)(4326008)(2906002)(4744005)(36756003)(31696002)(44832011)(5660300002)(86362001)(6506007)(53546011)(6486002)(31686004)(6666004)(6512007)(66556008)(478600001)(66476007)(38100700002)(66946007)(41300700001)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVhZN2xrdll1TkRaa0RRWldoU0NDc1lWY3VVT0EwaUdIUTVvT2ZMTDVIMVlj?= =?utf-8?B?WHZqK3k1Y25PUWVRaWhKNUs0RmRKQ2txYzhURGlXYUlBMXc5dk5veXFtVU41?= =?utf-8?B?RVRHZS9OM0NkVEt0OUNNQnlMNWk0MmR3OElnems5VUVVZE1GZUFBaFVrOTR3?= =?utf-8?B?aXl0UlpWWVFaVjFCTlQvcDZHK2R5ZWs5WFppMk5BUExWTGYvejRwUng2NXl3?= =?utf-8?B?bnhKMWdYQ3FvR210TDJvUk9nYTlSQ2FYdVBRUVd5OTdlUWM3a2Y2ZzFjSFFh?= =?utf-8?B?OGhkSlhvWlQ5NGxTbGdycUJySGNVd3JTazJiVjZrMzRhTnRvK2grYkNoYnRk?= =?utf-8?B?QUJYYStOZkNqSStkbTBhWW9JdUNJWHZJSmZ3K3VZcDVPNFJGL1pGM3VwcmJ6?= =?utf-8?B?WGZGYXhDS3BSYldTZDlwZE1SYXRocE9kQ3NVWnMzbTQ4VDZOZHFJbzRUeXc5?= =?utf-8?B?T0NoakJHbDlqNldja283U2JTMnpzSkp6WFFpYldzSWFpNnFzY1Q3WVk1NzE5?= =?utf-8?B?S3BtakppeHpqdkhsTldpb1FuQzNjNElpN2lsNnd5TnZNWHdxanZsWk9TbXo4?= =?utf-8?B?Q1VucnhaTm1jWms0c24yemZLSGlONGZrR0N3eFgvYlozZWpTaUVPUGpwR3dM?= =?utf-8?B?Nm5BanNYdHNUVHhxVUhJVGdLZzVseEQ0QTh1WmlJL3RZb1IzK0g4YldUcjZU?= =?utf-8?B?OExWQXE0Q3pHbEJBamloN0R5eVFtVURYZ291QXZETnFkaFl0V2xHOHd3YmxC?= =?utf-8?B?c0FDaGFUQ3RabDN3MVZXRSs3djlYLzRkZm1qQTVtU2x3OXZzOFRlZnp1d3J0?= =?utf-8?B?U2V5b2Y1b0FYRFl3NHg0K0JQdGJIRUZqQmQ0a1plR2tMeWk0Ri84SFFNSUd0?= =?utf-8?B?dDRzdFJQQjBESFlYR3Y4WWE3ZkZjWTFUQm9VL3k4OEtQSDFQZjQ4UlRwRmZO?= =?utf-8?B?NEFJb3NQcEVPRXZQTjVmZEZIQnpvUkFRQitnOWpxcHRjK0xnN21Vei9EUU5O?= =?utf-8?B?L2lKZExBaytYcXlyY1ZWS2sybC85RGF6M3lybUExZm9RdU1DS3VEN0RRM3Bq?= =?utf-8?B?Nmc4RlhEdGxtQ0FDL1RwUWdMeWhybit0bG5sbjMrTWVSSWx1ck1iUUlyYnRY?= =?utf-8?B?OXdwSVBVRDRqbkpYcHpKTTVPNUErcGtXZ3lLbWM2WGxaWXk4anR5YUVvZG52?= =?utf-8?B?Z1FpSDJia1NFYmtxL0VjNHA5a0ErTDBiWFhudTFLeklkKzFZbEFqWUVENi94?= =?utf-8?B?R2t1NmJDYnVUNG4zbUV3dlV1VGFhZU9YUW9ZbllGSHVrSWhaT05ZMCtFem1t?= =?utf-8?B?dGxXNlpOUWFWQmNTdmFCWS9YcVR4akxBcXp3Q1laakJ2cTNYS1pobXoxQnZZ?= =?utf-8?B?NW15Y3NLM0dOTjVQbE5OWHRXZllFWFVLcUZyalFzVng5aEtEWWt3azZlVmU4?= =?utf-8?B?ZEY1bHVpSWIxclA5Q2J0SjhaaVlVdFdnTjRmRUwrSEhacXV1VXBkdHZlTkNV?= =?utf-8?B?eTc0MjAwcmtlanlEcVVGSkhkU3Z0Wk9JU0d6K2huNC9kSDZGTUIwaDdZS3g0?= =?utf-8?B?UmZ0VVFLL1JxckYyK1k4dHMzVFhYblpTSGNmYWtSSzZzbWg0WGdad2l0NElS?= =?utf-8?B?Y1RIV1R0QXBydVpaTENvRVNDcE1kSWdwRjk3OHQ1azJIRDc3dWdnc3piSFlq?= =?utf-8?B?MHBkdmU5NEdQWXZhSmJ1cTcyM1F6c3hKVDV1SDJzN3VjL0JwN1dKNVNpbjE5?= =?utf-8?B?YmxHY21IL3FSdWo2SzlnSm5uaUx4YkxUTzlRQkZuTmVzM0VDaGlKZ3Q3enB0?= =?utf-8?B?Zm5mVytlYk5DYndtc3VEVlpsbWVFZkV6WkJFa0taVW5xV3pPK0ovc3NGRGtO?= =?utf-8?B?SEIwUVlQQmNzYTl2ODZUNVpydU5wb2JnNG5MV2Y0M0o0bjRyMFZRdnFVRE1G?= =?utf-8?B?VSsxd0VROUZTdmUrNWNhT1NFME1hMDF4VTVsUWl6Q0pUeHhXRTVRc1kyTTBW?= =?utf-8?B?QktSTW9ONDhWVWpoWW9JWTNWL1F0RFFHVFRZZHU2YTlZTVo3cFNwdStZT0tT?= =?utf-8?B?ZGYvKy9DMVEyeU1VdERzU2Z5bWpPbUpRcGZRNG55T0N1ck9XQ2ZoRUtadXcz?= =?utf-8?Q?CoonU7FxNKTMFxmfuEdEOiA2y?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17579df8-9fa9-4d96-1c99-08dbb9d61c6c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 12:35:45.7746 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0KizYqWgy7ACk2+msp2E00SSngOX/v/F2tgFIOEgAWfL61EcYI27KIgP44TECync X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5900 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/13/2023 4:02 AM, Chaoyong He wrote: > From: Long Wu > > If we add two cards that uses flower firmware into one dpdk-testpmd, > NFP PMD will printf error log. The reason is that the second card > uses the control VNIC Rx queue of the first card. > > Because rte_eth_dma_zone_reserve() will reserve new DMA zone if > DMA zone's name is unique. But if there is already a zone with the > same name, rte_eth_dma_zone_reserve() will return the pointer of > the previously DMA zone. We try to reserve DMA zone for each card > but we use the same name to reserve. > > We use the PCI address to give control VNIC a unique ring name > to avoid the above situation and let each NIC's ring have its > own DMA zone. > > Fixes: 945441ebdb9c ("net/nfp: add flower ctrl VNIC") > Cc: chaoyong.he@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Long Wu > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.