From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2674A034C; Wed, 27 Apr 2022 19:51:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5819D40E78; Wed, 27 Apr 2022 19:51:06 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70070.outbound.protection.outlook.com [40.107.7.70]) by mails.dpdk.org (Postfix) with ESMTP id 1471E40691 for ; Wed, 27 Apr 2022 19:51:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Otv414xOB9yIJaPFquv6eEQiCMz86uPXygG7shD375xG99J9KuxewtotZzHPp819e8bdxKd/63IttkwaeyI8sOBBMfUvkPF7Ns15hWjaj45xpR2DyqSmTa61IlRreAxCdX1PqrxrcMzYpA0zNKHdGC+0HmR1g/hGBl/DS0t+8IcN+d5PIxcshIjFa/n7KkDDT9z1tC3l+kdimAlhqymJRp5GgTdgmfWqlUcjIS8Hf1dLtWB0Nslz5ioAkwsEg+ciqQPcXF+ikjqR/afNCtXxf5tbxLix/+e70viU6oOl0/bIOlvrXWEL7T6s6xyZRq1WQfddFo50zDB/LgQ+B/saUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nAJVP8q+zyK6+vZe6bxGH0ENwSCXsCFVbkkgbED0IWQ=; b=NsPqCeeARj4RJmuX0e/BKK2FYoXIao8yW0NI4cr7PNu90O6/64ykY3pW8jSSL8inOp4YAgdRwozOHDgAj8HqMeW/XasDvVRVHaaRt4khYc47obu7mwBaB4IhKkl0ttrv+QRkKy9/nvvaxZhvTsgTQjB1f25zFmB5quiVS7z75oCqqyidjuj6i1OgwNYS8w6CAB0bRhWgUkF/Z9wBQsEKPMksxDJIlXs9CYkaZwIcA49V7iKcxrYExXw1KYg9szz/oplUILAMg6nX7SDM/BQDnc9aceujduDiFZzOxK8t/hl2e/Mn2EJcuFUUKTQQ6B0gaa8r6loKJDhq1a87TWPv4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xsightlabs.com; dmarc=pass action=none header.from=xsightlabs.com; dkim=pass header.d=xsightlabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xsightlabs.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nAJVP8q+zyK6+vZe6bxGH0ENwSCXsCFVbkkgbED0IWQ=; b=ne3lkOMbZfrUo8jfFQdhU7E+gJoM8hJioRAgxU+0TqDew/+57CeUAGFyiZAFP4vkXiqqATEpSsZxTA8m4TCuszeqdHaETpc3mIDi7ySdnsc0vPskmYFgJnw9IFWvq88qTgZVf4q6DB2cP3W8PewNVMSsNzwsa2XuFrifpWAyVZ4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xsightlabs.com; Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) by DB9P193MB1241.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:258::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Wed, 27 Apr 2022 17:51:02 +0000 Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::281a:860b:67a1:2cd9]) by DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::281a:860b:67a1:2cd9%9]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022 17:51:02 +0000 Message-ID: <2a335356-236b-c6e2-66a7-7f2d99f7007a@xsightlabs.com> Date: Wed, 27 Apr 2022 13:50:56 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory To: Honnappa Nagarahalli , "dev@dpdk.org" Cc: nd References: <20220426122000.24743-1-donw@xsightlabs.com> From: Don Wallwork In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: VI1PR10CA0089.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:28::18) To DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59e47026-11b3-42ac-f9a0-08da28767eab X-MS-TrafficTypeDiagnostic: DB9P193MB1241:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4DspEP75UviJT57KZ2T7j8tG7JHzOHAHL26jSSLHZBBCUguSyQ6r6W0c2RARe5MSuJBIFXGhkA1ljVjOtiIK2MFxonmAIrx/STFxRonIbUgsZmsWejde1jgovWP7co5stMqH5cy4b5n2WVIaASV+2FothAKmZM5/O9FJ2TXRCH9RrJtVvAjNYZ/5f/SIJqVxWqJNM+4DUUfV1fa01WkZUhboyVev4SvTZGts9AaOr/+R5mYV0ih/AlFnTxp+qiXbl0v8LGzyCOEUbYoBKXmFaS+32chIvIlkSQWtZRPwtZnfAYIK7YGoCfjn4mp3pLII+wspN0rSg28lFnV+wYqhvrWEPdOGFo2gmVoAQVxk/GLlZLJj9titje7iYRlpeXmKhUSurMy5nMGw0+Ombo7wV8tFyA0VKcIml134GU9/J472dRx50tTRhqH+2HuOIHdTQPDDBK9tn5Bv1SGgPmB4162YZdqERCBurZ6UMPKxFUX38ule2yx+MFQ/kxOy4Wv4ySrGvDgLwJKBYiIBOsRQqQC3uN7Q2TzoDxolGxeSnxOsFsitiNIrUfUI9I+xFbt/tqZSP1yxYWT4IcvVjqc1FfkcafX78Zn6CggpFz3gI7X+K6qNwOmgSL7xBJ6++5Z6ItwiztkebpEx/a2FxBTOyISsiQuqQGVTYi/6+20G0UiyvUf9UbcVCFHrA4TYJcT8DlGZJCwQSELvq5CYfvUdFqYVUjXkuLjCTRSexpa8ITO2BRAAb6K8U7pGdci6jzyyvKvAnXOHhiMAfESyi4v6oA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P193MB1482.EURP193.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(38350700002)(6506007)(6666004)(6486002)(26005)(6512007)(53546011)(66556008)(2906002)(4744005)(5660300002)(36756003)(8936002)(31686004)(38100700002)(66946007)(2616005)(52116002)(66476007)(8676002)(4326008)(186003)(31696002)(110136005)(86362001)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEFROEhKaVhobFprelVZZnVoOEwybEU2eC9tUzFvTHQ3UHJ5cXZhZXYrWEtY?= =?utf-8?B?QzFWWTRXcUphUXVXbmplNnNmcXhmVTQxNkQ4aGJ0dXpiMENmdlZ6bWtReEds?= =?utf-8?B?YWVuYm5zbTRIbWVuTUJrajVvbCtjZkpST1hCU3ZsMDBBbzVLNXVkMTBYa0xi?= =?utf-8?B?RFlkTWVDbHdyOHQyKzlUakNkcmlmbzBmbnF6RTFRbWtZbjJIakJUbmltOXd0?= =?utf-8?B?ZmpmZDJCMUhOR1VXQ2tFZDI3U1MydUhFQ2RnSHUrMG5adTNhb2hIZVY5Skl1?= =?utf-8?B?ZGxiQTVjbkRLRDk4RVZiWE04a3Zxa3ZlcmdJNk9TWGRZU05iODN6M0tJQksx?= =?utf-8?B?WUVhS09EUXVOenRtby9DS1JDV1gzNm5ublc3bVpZYlFabyszMmJFc0wwYjlY?= =?utf-8?B?eHZOMDdkK3B5T0QzVEpsTGVxNk9QelFKZU90MWs1eGpuYUdNOUlSOVQ3M2Q4?= =?utf-8?B?cjVlV003MTBPT2FQWUVDWE9yd1dCQk0vQXp1SkpWSDVidmgxNjROQ2VVOUtV?= =?utf-8?B?aUM1ZGxQWVFCSFdJM1UyQm5ZQWxOQXYzbG9OL0NlNTFuR2JCdENsNllaaVBo?= =?utf-8?B?VDVTSmJXUnVPRXI2ZS81OHdSNzNIb1gzU3Z3ZEpneHF0NEtheWxhL3FEWlRw?= =?utf-8?B?bkJsU0xxWkNpL1hJWVhlcXNlazNrNnYzUHpsSEVLZk9UbDMxcXIyRHZ3WmZG?= =?utf-8?B?eHFvVEwzUDMvcHNRWTZTNXpUb0VLV1dVbzAyVjFYVE9oNCtqVThndlNocDFF?= =?utf-8?B?cUIzUmFwM0I0QnY3UDRENTNPQUF2cXdScnR1SGJuUlc1cnczM3pBTXJyeVlx?= =?utf-8?B?SUwvMFhsVFpLSkxKTzg4NUkrb3ZTV3NQc0ExSVVBK2J5UjlUTVdoNitFd1F4?= =?utf-8?B?aGV4a0lBcWVOdFQ1d1lMaW1HMnA5UTdKTkpUYzFwdXhzTVZ2cW9tQVhKN01R?= =?utf-8?B?RFY2YmZXT0VoOFNvb3F2cU1wcHd3R0dvNDNUeDFRd0UvNy9GbGlRV3NUTmxT?= =?utf-8?B?c0FpbktuT0pacUlKdkJwdlhUSVllY2NRZHlSZS9peGxNL3FkVzdXZmRMcGVG?= =?utf-8?B?cVcrSFRQc1pVVWcrMS9RaFBJUVhmT2lqQjFCSzBXMTE3cldaMjJOUHZONTdP?= =?utf-8?B?MFZ3dWtReHpXakpjSTNoaTlKK3NzTE95cDcrVjhuK0UvQ3hFSEw1aGJUUmpi?= =?utf-8?B?YXplTmUrWlo4YlZtRW13L1ZaWHlqNFU1cWYyVWxQUlcvVkhHZEJEU3UyZnhr?= =?utf-8?B?c1NOOWw3WGhReHdVU0R0c1MycTJheTlUL3NPaDNDdEtqS3l2ZUN4a29PS0lB?= =?utf-8?B?YWtwMm1XVk1Oa2RCMW9leTN3YVJ3NmRmZkpHNkdETmljci9ESXFrSlNST293?= =?utf-8?B?VDR3MkJPOWk2ZzFLcjRaSlg2WUlVN1gwRjA4dFcwa2ZkU0lTdlhYRURmd3E2?= =?utf-8?B?Q1ozNURLY0ljeFJYVE5BNnB5MjBCa1BkaTREYnJwZVVackgxblBDV0oxSHlM?= =?utf-8?B?MFFuUjFjZWMzVDQ4Q0EvcVQyNml2WEdUWmRHeCtRblZKZkgxL2FOTFF2cFln?= =?utf-8?B?VkM5aytSamU4SFd5QUxYajZReUpsWWNIQUs2M2w4TDhsMU96K1lJU1I4bVFn?= =?utf-8?B?ajI1bEp1Sm1mVENVdEJHR1dCcUZ6QVdWNTNXbitQNytMR0U5dlFTMXUvTCtI?= =?utf-8?B?c2o3S0NublRIdkM3cGxzM1FDYml3L2c4NVg0L2FHeXE1NzJyOHRMWjl1OGln?= =?utf-8?B?TTRpOE1ncWYzRTBIWXVXMGxmWWRxeEJRS21EalZhVW5IcmJGWkNLWDdtL0di?= =?utf-8?B?Ni8xMGdzeXg3bmtUejkwNDhzMDdURUFsNyszWmhhZzJFVzBoNWxpRk5NUCtO?= =?utf-8?B?SDdWSVRETDd0MG5QTmtKL0FGWUt0VnhPR3ZmVjgxc3JucU5IQVdyVENnaHNN?= =?utf-8?B?VUtmUldDQUUydVJqSXJZa285NG55NDhCbUZBcUdKclFjN1RISDV5VmFxOVRz?= =?utf-8?B?bTljcG1HOWtnbEtRVC93ei9SdVZEeDhNbFhadjlGT0ZPaVorSmhvaFhuU05L?= =?utf-8?B?amovekFXZ1piL3lOOTFGZGpVK3RnY3FNUkpleG5EMkdsQm5FZE8xUFd2eUQz?= =?utf-8?B?VWtkR2lVWW84ampJYS8xSHAvR090OEM2eG5BWkZ5WEdOQVlJYzUyY2taa3N3?= =?utf-8?B?SXdQeUNxTDNCNVV2T1UrNjNDd1krbVJ3SUxUMEZEbnphMXdMT0luS2d2Vnp2?= =?utf-8?B?cUk3SExZTWduREZ6Y2x4RGtnTzd6MWxUTEtITkxlWFJIWXlqUy9OTUdiWCtV?= =?utf-8?B?K0lZTUxpTXF4MkdqQjF1eERkcWwySWxJRW5SMHZHcHpVaGVIcVZmZz09?= X-OriginatorOrg: xsightlabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59e47026-11b3-42ac-f9a0-08da28767eab X-MS-Exchange-CrossTenant-AuthSource: DB9P193MB1482.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 17:51:02.4360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 646a3e34-83ea-4273-9177-ab01923abaa9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PxMYIz89RpUNtznEGVNijsO3iMcTf/o4NGzhnd04HHuwB122T/LAaou8//YiWiDvKm2IYoyDndZlH0Fh8Y2x9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P193MB1241 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/26/2022 8:42 PM, Honnappa Nagarahalli wrote: > > >> Add support for using hugepages for worker lcore stack memory. The intent is >> to improve performance by reducing stack memory related TLB misses and also >> by using memory local to the NUMA node of each lcore. > This is a good idea. Have you measured any performance differences with this patch? What kind of benefits do you see? The performance benefit is very application and target dependent. For example, a trivial test with a small memory/stack footprint would not see much benefit from this change.  An application with deep call stacks and/or significant stack and table data memory usage would benefit.  We're not yet prepared to release specific performance delta data, but we are currently developing applications that benefit from this feature. All other comments will be incorporated in the next version.