From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 398361CEB9 for ; Fri, 6 Apr 2018 11:48:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D08524068031; Fri, 6 Apr 2018 09:48:58 +0000 (UTC) Received: from [10.36.112.46] (ovpn-112-46.ams2.redhat.com [10.36.112.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA2FC10B009B; Fri, 6 Apr 2018 09:48:52 +0000 (UTC) To: Jens Freimann Cc: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-18-jfreimann@redhat.com> <2f621b0a-9c96-d156-31b1-cd5270c8f2bb@redhat.com> <20180406094336.xyibdb7hg5n3yoxx@dhcp-192-241.str.redhat.com> From: Maxime Coquelin Message-ID: <2a4584f6-b1f4-88a0-54e0-35698805e1a5@redhat.com> Date: Fri, 6 Apr 2018 11:48:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180406094336.xyibdb7hg5n3yoxx@dhcp-192-241.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 06 Apr 2018 09:48:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 06 Apr 2018 09:48:58 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 17/21] net/virtio: disable ctrl virtqueue for packed rings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 09:48:59 -0000 On 04/06/2018 11:43 AM, Jens Freimann wrote: > On Fri, Apr 06, 2018 at 11:38:50AM +0200, Maxime Coquelin wrote: >> >> >> On 04/05/2018 12:10 PM, Jens Freimann wrote: >>> Signed-off-by: Jens Freiman >>> --- >>>  drivers/net/virtio/virtio_ethdev.c | 7 +++++++ >>>  1 file changed, 7 insertions(+) >>> >>> diff --git a/drivers/net/virtio/virtio_ethdev.c >>> b/drivers/net/virtio/virtio_ethdev.c >>> index dc220c743..7367d9c5d 100644 >>> --- a/drivers/net/virtio/virtio_ethdev.c >>> +++ b/drivers/net/virtio/virtio_ethdev.c >>> @@ -1157,6 +1157,13 @@ virtio_negotiate_features(struct virtio_hw >>> *hw, uint64_t req_features) >>>      req_features &= ~(1ull << VIRTIO_F_RING_PACKED); >>>  #endif >>> +    if (req_features & (1ULL << VIRTIO_F_RING_PACKED)) { >>> +        req_features &= ~(1ull << VIRTIO_NET_F_CTRL_MAC_ADDR); >>> +        req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ); >>> +        req_features &= ~(1ull << VIRTIO_NET_F_CTRL_RX); >>> +        req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VLAN); >>> +    } >>> + >> >> Does packed ring not support ctrl vqs, or is it just a workaround while >> it is implemented? > > packed queues support virtqueues, but I had not implemented it yet. I > have a patch for it though and will include it in v4. Great, so if you hadn't the patch, I think that a comment would be welcome. But it does not apply as you have the patch in your queue! Thanks, Maxime > > regards, > Jens >> >>>      /* >>>       * Negotiate features: Subset of device feature bits are written >>> back >>>       * guest feature bits. >>>