RE: [RFC 0/4] remove use of VLA

[Konstantin Ananyev <konstantin.ananyev@huawei.com>]

Hi Ferruh,

> On 5/23/2024 5:26 PM, Konstantin Ananyev wrote:
> > From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> >
> > To continue further work on VLA replacement for these series:
> > https://patches.dpdk.org/project/dpdk/list/?series=31887
> > extra few patches to remove VLA for gro lib and ixgbe and ice PMDs.
> > DISCLAIMER: I don't have ice and ixgbe HW available on my box, so
> > didn't make a proper testing for patches #3,4.
> >
> > Konstantin Ananyev (4):
> >   gro: fix overwrite unprocessed packets
> >   gro: remove use of VLAs
> >   net/ixgbe: remove use of VLAs
> >   net/ice: remove use of VLAs
> >
> 
> Hi Konstantin,
> 
> I guess this is send as RFC because the set is not tested?

Two reasons:
 - I wasn't able to test all Intel PMD changes: 
   don't have a box with ixbe HW.
   Tested ice changes just a bit (test-pmd rx_only mode).
   In fact, there seems no that many use-cases for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT.
 - I expect it will become part of greater VLA removal series:
   https://patchwork.dpdk.org/project/dpdk/list/?series=31887 

> If so, @Bruce, @John, can you please help testing this set?
> Btw, it fixes some GRO issues, additional GRO tests also helps if possible?

That would be good, but right now I don't see any unit-tests  for it.
Have to do some manual testing with scapy+testpmd.  
I presume there are some GRO tests in DTS, but I never looked inside it so far.

> 
> Thanks,
> ferruh