From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D108DA034F; Sat, 11 Sep 2021 21:19:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4789F40042; Sat, 11 Sep 2021 21:19:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 00C2F40041 for ; Sat, 11 Sep 2021 21:18:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631387938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDJOzAjPsfb4hJptoIZoCImCHEPIrZkLb2iyEE8Rc5A=; b=YQu6kVj6dXeKA5z2UhGR6Io+tHKBsBLHeLvxER7FdvELLVe8zm64VR0viOi+ltUNBb4AEa iI4cZq7JoMZbEwxwm6aY+fHkpl0NIylCQYHb3Y34ARlcxGpeHS2xNSZHpLYWWMHUn+Tcii 1K3rszdMDc6cJo6IYailaD8QEPVyd2g= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-0aDgUUVFMeaIv4tTvntshQ-1; Sat, 11 Sep 2021 15:18:57 -0400 X-MC-Unique: 0aDgUUVFMeaIv4tTvntshQ-1 Received: by mail-qv1-f69.google.com with SMTP id r3-20020a0cc403000000b00377a3318261so50558020qvi.11 for ; Sat, 11 Sep 2021 12:18:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NDJOzAjPsfb4hJptoIZoCImCHEPIrZkLb2iyEE8Rc5A=; b=xMpyHZXNF3TRBAR0uUFN0kQJkGfGTYTZVjQVnvBmoX/FGTK3uR8dif6CLOQEI7lQwO LZlopzvKhsB4xqRmE53AnPDFQmAnyxLvSqBKkeUJcGibqCykRnH2YKtT6awKUxoWYe/+ VTdc7pqa2mx0GULk+3j+y3ZGvGp7Bpqa/pnSZ1AUL/xGeQyKV95F5XPbtxq39IauppJX IL8zPuqJEibyuHBiY5OCzxsajgT3PCt3XUyE+tynhLokGxbXpGrQke/pv/6EfL8gEQrD Le9oWJ/DL9AjXrJ8wCXGnHMJEJS5d+JxglwJ2yCnKgsBJ3nuEVWUXwJHeMFQzrMXcToQ N/4w== X-Gm-Message-State: AOAM5308L6eRCxmw3Whz/kEX/e2xFoawiwnGWPMJrjnpGS2v+rPEJMw8 mxa1HlqT4cQeQZ3oApCcS59QuZ2P/wPatT1sa6G8CWXKqQcAItN8s+hiHUbGSz8mcG5nouf0O+i X8xM= X-Received: by 2002:a0c:8e83:: with SMTP id x3mr3415816qvb.40.1631387936847; Sat, 11 Sep 2021 12:18:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3F5mefmRoziIx9qtxFOasJUdfkmYV9azPizf0GQ5M//hswpC1MJZecU/LR51LFW5r5YOf9w== X-Received: by 2002:a0c:8e83:: with SMTP id x3mr3415797qvb.40.1631387936676; Sat, 11 Sep 2021 12:18:56 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id j9sm1401444qta.65.2021.09.11.12.18.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Sep 2021 12:18:56 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, mingshan.zhang@intel.com, arun.joshi@intel.com, stable@dpdk.org References: <1631065180-18253-1-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <2a661e89-aca6-4924-ff39-8d0da194093d@redhat.com> Date: Sat, 11 Sep 2021 12:18:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1631065180-18253-1-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v1] baseband/acc100: fix 4GUL outbound size when CRC is dropped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/7/21 6:39 PM, Nicolas Chautru wrote: > This patch fixes the issue by adjusting the outbound size after > turbodecoding when the appended CRC is meant to be dropped. > > Fixes: f404dfe35cc3 ("baseband/acc100: support 4G processing") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 68ba523..b0485e7 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1744,7 +1744,8 @@ > > next_triplet = acc100_dma_fill_blk_type_out( > desc, h_output, *h_out_offset, > - k >> 3, next_triplet, ACC100_DMA_BLKID_OUT_HARD); > + (k - crc24_overlap) >> 3, next_triplet, > + ACC100_DMA_BLKID_OUT_HARD); > if (unlikely(next_triplet < 0)) { > rte_bbdev_log(ERR, > "Mismatch between data to process and mbuf data length in bbdev_op: %p", Thanks for this change, looks good. Reviewed-by: Tom Rix