From: Chas Williams <3chas3@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com, chas3@att.com,
ferruh.yigit@intel.com, arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix segfault when creating bonded device
Date: Wed, 31 Oct 2018 11:37:21 -0400 [thread overview]
Message-ID: <2adb03da-ff43-3ab4-5e5a-0a44622d5f8d@gmail.com> (raw)
In-Reply-To: <2490703.Y8HZJr6zFH@xps>
On 10/31/2018 11:06 AM, Thomas Monjalon wrote:
> 31/10/2018 14:59, Radu Nicolau:
>> After the patch below the call to rte_eth_bond_8023ad_agg_selection_set
>> from probe() segfaults; there is no need to call the function, just set
>> the mode directly.
>>
>> Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing")
>
> It would not segfault if you call rte_eth_dev_probing_finish() at the
> real end of the probing function. Then the port will be considered not
> valid in rte_eth_bond_8023ad_agg_selection_set().
> It does not solve your problem but it is more correct.
> So I suggest to revert this patch (which was a wrong fix):
> http://git.dpdk.org/dpdk/commit/?id=1620175
Or just make the change proposed in this commit and also move this
section before the probing finish. This is performing initial setup of
the interface and it doesn't need to use the public API to do this.
And this should be done before the public API can access the device.
> Then the issue is to allow configuring a port before the end of probing.
That shouldn't be allowed of course.
> This patch is workarounding the public API which checks port validity.
> I think it is a good approach.
next prev parent reply other threads:[~2018-10-31 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 13:59 Radu Nicolau
2018-10-31 15:06 ` Thomas Monjalon
2018-10-31 15:34 ` Radu Nicolau
2018-10-31 15:37 ` Chas Williams [this message]
2018-10-31 15:44 ` Thomas Monjalon
2018-10-31 15:50 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2018-10-31 16:11 ` Thomas Monjalon
2018-10-31 16:14 ` Chas Williams
2018-11-02 20:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2adb03da-ff43-3ab4-5e5a-0a44622d5f8d@gmail.com \
--to=3chas3@gmail.com \
--cc=arybchenko@solarflare.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=radu.nicolau@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).