From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C5EBA0547; Fri, 10 Sep 2021 15:16:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFC3A40DDE; Fri, 10 Sep 2021 15:16:07 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 23BFB406B4 for ; Fri, 10 Sep 2021 15:16:05 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="200597735" X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="200597735" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2021 06:16:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="549322195" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 10 Sep 2021 06:16:05 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 10 Sep 2021 06:16:04 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 10 Sep 2021 06:16:04 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 10 Sep 2021 06:16:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P0a6ZRqKYESrhTZuu3KQAw73/eN3t8Dwge39kBYFKGxBiaTpb0FPJBrfcxhNuwLkiGWZggcwuzvnGGccNAsN4JCIt5MyYfpdwfewuoS0SYwwdW/pp/o6DFCCXk79LyjJm3uvWqd7EG1nUy462qmRzV67lkl3wclH01BalOxiH7OCLKo+xMIJf6vRJm5l0GHK2dU/XcBp5k7IwwUN8VYpG1z8gDKjV/l4abep4HN7nnUeh0zlov0vcNRT0+0gFSPPirslMYIb8pPqNFuPX0pa8fxL83V4iOr1iu346OvMlsPWzJT9SV1FfL1XPzHMppFgRqeN5s9XChtmWHonyC5p+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xhsi31eWS5mAGOlAb5PnBg1XguUwpaIwxK9vjnBhHc=; b=D7losg5olL9pJJ2UarFEMpq/04bSzmyiE3KMwB5lvrB8OhYzaIyEtklvIEE4VeJqtbBETSFAY4Z4oVQgKCeppYhKL4oiY84M9sQ9RT1rqIZL+NYwx1Fb/3hnP5r5TMk+ANpeDAN7zUB4/gGs/C0Ke9mlxPYUCFGXvyZAbIj9kZ4+ZI/H8tfXuC2SbXDfdS0GGKvo/nAPO8rLuidCWc3bNvaVePSBE4sqo/bfiUugwkuy9psmYfYjm03NynFE7VvYJ+saw4h1mI2hAB35dceX27ymBKlmW2/CXkBwA8ymCTbIkG2VupNluBkzWKm8MVdH3FdQkZytWQc2Z204VVPSnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xhsi31eWS5mAGOlAb5PnBg1XguUwpaIwxK9vjnBhHc=; b=TUbKuRxNqjL0Qj+tt87qfVloCjwJQ/swU0mBmUKHI7dJtrUTMNPCMICXPAhjA3f4BSjUHs93TLle8NtvRvQI5z8e3c33oskeT4ioPe0TCZPo7Dm3XCv0lIbfkvbYnlVM0FKNqBHKCS1Vw4HfRX360mEnr0UsFcdjvrZvE7HM0MI= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) by PH0PR11MB4949.namprd11.prod.outlook.com (2603:10b6:510:31::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.21; Fri, 10 Sep 2021 13:16:02 +0000 Received: from PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91]) by PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91%9]) with mapi id 15.20.4500.017; Fri, 10 Sep 2021 13:16:02 +0000 To: Miao Li , CC: , References: <20210910130548.127017-1-miao.li@intel.com> <20210910130548.127017-5-miao.li@intel.com> From: "Burakov, Anatoly" Message-ID: <2ae076fa-3e4d-e825-320f-502739c9d29b@intel.com> Date: Fri, 10 Sep 2021 14:15:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: <20210910130548.127017-5-miao.li@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0077.eurprd07.prod.outlook.com (2603:10a6:6:2b::15) To PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) MIME-Version: 1.0 Received: from [192.168.1.10] (212.17.34.161) by DB6PR07CA0077.eurprd07.prod.outlook.com (2603:10a6:6:2b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.9 via Frontend Transport; Fri, 10 Sep 2021 13:16:01 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af88c3c0-f33a-49d1-a707-08d9745d2368 X-MS-TrafficTypeDiagnostic: PH0PR11MB4949: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: plnayj/utDniVznCgVUiz2lnkA2BfULKO3Tls2J39Z5lmpqumrakqgLg1kvaO0JvEyEWx/5SIKMnt5iFQsN67EXVbHb05qwq6gDyplmqEz5BiA5W/AP4D6D3RS6wq8zxUqJOtJT+c7H3P90QdM4sLFkKms7N48+xzYsYqjIC0EHwzV7FVm5gA33nyQVmD88w+r2sI3UcPQa3rqVNf9viyLyIOJOQGOftXmiyOvU3HLJuHi2HSiwJQvfZbirJcAHAgkTMHMzKkWv0zk1E+xb7YGftJE95S5YIXKp7+l+EtACxRCqosEi9P/zKDZVyVnox11u0P6V5A/VTM8IqDFvKzdUUo8bouG3wTIIXqBAfBl1gLLyJCn5wSrQ4c1Ze2vh6srBfk8GDnwbBitzjFJBLoAy5SAe0TrclkHCpE2BlBdAMBdhqh4Pk75o+DoSuaUuLf7kdqd26Hui3iiTxVLJ8BphuesqqvnQVXv7DYmdi3FpohRgBkQpMaE1bwTLAQdPdqpZ9XHpnbhpaDT/8i3bDwlvnXFQI+0h6k7v9UNuTchnyQmOXL7E6ce+mPugrBtbKLRZFSIWDKS3ZAJ/KPMC5lQI/KcCIeY3cpWjikfuMCk8L3OFutp6Sf1dUfAd3rPCs9Adgs68aVDKLHyNQvM8T6qDLvqgAEosWZyhH9+fnGwVTee8y7aefodaa7ACLD6WsBm/87s/0d0rW/bb33JBGqGfI5bwrzXHhkMgRyawI7js= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5093.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(6666004)(4326008)(53546011)(66556008)(66946007)(478600001)(86362001)(66476007)(31696002)(31686004)(8936002)(8676002)(6486002)(2906002)(38100700002)(186003)(2616005)(16576012)(36756003)(316002)(5660300002)(956004)(26005)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck8zTHpadmRuSlpOVVBBM0V4MUxvR255OEJsK1RIYklOdGFreUNpbUlJZ2xr?= =?utf-8?B?SXIwWGVHUHc3V0FGQkRnT3ZzajhZclhkOFBaN1Rya2h6VjZlRVdGV2lQTzVS?= =?utf-8?B?Q0VnSmFxQXh3NHVTWlhQQkJ5ZU1ob29wOTRDRGFHdWJtR3krV2FSeWQ3VWtm?= =?utf-8?B?ZkpkaEtmb1NkYk96L0hOM0R6RzVNc1UwUWhzOHY3STZZdDdMK0ZWQXNCeXB6?= =?utf-8?B?TGR6dFNuNkZERXIrekQ3TVoyVit5RWxsdDZLaXAwUzJUV3VNZkVrSHE1OU0x?= =?utf-8?B?dVNtVmxlaEtBVU9CZjNnalRBRkV0c3V4UC9RbklSanNBZ2xQT0FrYmZnWVJi?= =?utf-8?B?RTlCbzlvUU5CWEkrVjNwVGlIZWUrOXRvKzhhWDJhMUExdEphQitDWnVqY1JW?= =?utf-8?B?Nk5hejBDUERlNzh3YTA3UUsxK1FQM3dXQkZkRDVSdTVWcjhyUThJT1U1N0tL?= =?utf-8?B?bFV3WlB4THVXcjVlZnNhSEpQbUJpVEtlUWlaRWJ1bVdIOVphMnNXd2YwYVlB?= =?utf-8?B?VXZ6akVjcDFFTE13NktaL1ZYNFhwMUhYUHkwSWpib0hLQWt6QjN4WWhCemZK?= =?utf-8?B?cktRd2g0dFpHWDJ6OXBTeGpDNGZjQVQxU29SeW1nZnl5anZMaVpmTVRuM3Jt?= =?utf-8?B?ZHFWQW85VE1raEd1dHFONDZ5Ukk1N1lIMXRsZTY2bHNHUTI1MGZIQm5ZQjNv?= =?utf-8?B?bmJLUlhUOUxSc05NVjlFTzZVTEFzWXF1bVhkaENZVG1RRjZVckVsRFY4MmZx?= =?utf-8?B?aHYrOWJzbGYrNzVjODUzbnRkQWZhQzV3QXNqM1FrczJrOHpqbVh0NkxWUUZC?= =?utf-8?B?K0FncXpMSlVTb29JQjF0QThNUCs4a2JkSWE5MXZVQi9ScnoxMDVxdTVkUzVw?= =?utf-8?B?SXlzcU9TSXpTZGZGc0J2aTFuQnkzQ3RETG8zWUhxVVluUXdyMk9HTEFyU1A3?= =?utf-8?B?M05yazdkS3BtdnZDYnBlS3g4RUQ2M3RkbU9DWFlQdW1sZlA0RkVxMXZtVHBE?= =?utf-8?B?YzA2ZzAzeU9YeUdUeW9RZEVEN0xWNXo0YkhEUHdsL25xdmlQSlI0VXFpWlZL?= =?utf-8?B?ZkVGYk5tcW54ZlZaeldpcmp1Q1RnK05FSEs5WUhOWERBSHRobDJpNzdjTXpw?= =?utf-8?B?dzNMS1RQdnRmS25hR3JmWVNSRjVta3lxUTdVSE1XT1ErSHYwaVNGM08yc1RU?= =?utf-8?B?TUZ0WW1wUEk4UEJaVlpqaWJRZ1NmblRIU3NRMnpiNjEvSTJ3VmJkejM1SjN4?= =?utf-8?B?Q3l4cThTWVF0SzZKeVYzT0k0NVdVTzFCRW50YzQvUEpSVDMrY2dldmdCNmNo?= =?utf-8?B?V1owTmF1SWNMZ1dvdFdkci93Ym92ejZ6WVplNGVaNzBkSjZXWHRmQ2NhZWV5?= =?utf-8?B?RkFmMVBtSTgvT0hIMExWM2dpTWQvNmNNR2I4Y1ZucXkvaFlpakNOQ0x6dVB3?= =?utf-8?B?YllYZW96cWIrTmI3NjFySnZ0NU10QWUzQnJyWnAvSWU4OU1GM0Rqb1c2ekNK?= =?utf-8?B?a2NUT2dGZW1OdWtOZGd6RHAyRE9NL0swWWdxZzZOanRYZkFKdVBaNXN3K1Yw?= =?utf-8?B?S1NjbmMvRUFpRytuejFNblRGS1RqYXVyUUJSNzNHNW9RbjZkTHEyV3RaV1pa?= =?utf-8?B?YTRuRzdjR2M1OS9rRVRxdEtXcEcrV2tWeDVJV2dqcGI5eVh1TmFaODg1UVh1?= =?utf-8?B?MHFOcldjUGJqQ3FpYUQwNWhzZUg3ODhCbkJ1SFB5dTNSN1pLR3MrajBkTDQr?= =?utf-8?Q?5Zh8eVYdofIe5OuoAdLeTjcRnCe6dYtGDDM1ZFM?= X-MS-Exchange-CrossTenant-Network-Message-Id: af88c3c0-f33a-49d1-a707-08d9745d2368 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5093.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 13:16:02.6050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ASH5fGkH7fYNsPSyXHdMYWHIykqCyd7oEKUo9x97Z8RxpkF/TH30YzqpYnIWcj+H8jWQzMzUEY/6yh71/dl7ZaESbtOyo18QWDiYVrSwSVA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4949 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 4/5] lib/power: modify return of queue_stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10-Sep-21 2:05 PM, Miao Li wrote: > Since some vdevs like virtio and vhost do not support rxq_info_get and > queue state inquiry, the error return value -ENOTSUP need to be ignored > when queue_stopped cannot get rx queue information and rx queue state. > This patch changes the return value of queue_stopped when > rte_eth_rx_queue_info_get return ENOTSUP to support vdevs which cannot > provide rx queue information and rx queue state enable power management. > > Signed-off-by: Miao Li > --- > lib/power/rte_power_pmd_mgmt.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c > index 0ce40f0875..39a2b4cd23 100644 > --- a/lib/power/rte_power_pmd_mgmt.c > +++ b/lib/power/rte_power_pmd_mgmt.c > @@ -382,8 +382,13 @@ queue_stopped(const uint16_t port_id, const uint16_t queue_id) > { > struct rte_eth_rxq_info qinfo; > > - if (rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo) < 0) > - return -1; > + int ret = rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo); > + if (ret < 0) { > + if (ret == -ENOTSUP) > + return 1; > + else > + return -1; > + } > > return qinfo.queue_state == RTE_ETH_QUEUE_STATE_STOPPED; > } > This seems like a deficiency in the original implementation, good catch. Acked-by: Anatoly Burakov -- Thanks, Anatoly