From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 39EB51B1B8 for ; Mon, 30 Oct 2017 23:55:49 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2017 15:55:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,321,1505804400"; d="scan'208";a="169178638" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.254]) ([10.241.225.254]) by fmsmga005.fm.intel.com with ESMTP; 30 Oct 2017 15:55:48 -0700 To: Pengzhen Liu , thomas@monjalon.net Cc: dev@dpdk.org, Keith Wiles References: <1509011493-26531-1-git-send-email-liupengzhen3@huawei.com> From: Ferruh Yigit Message-ID: <2aeb75a6-7fcd-1d93-e424-7994e044a06b@intel.com> Date: Mon, 30 Oct 2017 15:55:48 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509011493-26531-1-git-send-email-liupengzhen3@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/tap: fix invalid queue file descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 22:55:50 -0000 On 10/26/2017 2:51 AM, Pengzhen Liu wrote: > From: Keith Wiles > > Rx and Tx queues share the common tap file descriptor, but save this > value separately. > > Setting up Rx/Tx queue sets up both queues, release_queue close the > tap file but update file descriptor only for that queue. > > This makes other queue's file descriptor invalid. > > As a workaround, prevent release_queue callback to be called by default. > > This is done by separating Rx/Tx setup functions, so that each only > setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling > release_queue before setup_queue. > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > > Signed-off-by: Keith Wiles > Signed-off-by: Ferruh Yigit Hi Pengzhen, This is a commit from repo :) [1] from beginning of the year. I assume this has been sent instead of another patch by mistake, please double check if intended patch sent to mail list. [1] http://dpdk.org/commit/0002ca58