From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 22B27FA5E for ; Thu, 19 Jan 2017 20:07:14 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 19 Jan 2017 11:07:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,255,1477983600"; d="scan'208";a="924482680" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 19 Jan 2017 11:07:10 -0800 To: Hemant Agrawal , dev@dpdk.org References: <1484679174-4174-1-git-send-email-hemant.agrawal@nxp.com> <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com> <1484832240-2048-6-git-send-email-hemant.agrawal@nxp.com> Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com, shreyansh.jain@nxp.com, john.mcnamara@intel.com, jerin.jacob@caviumnetworks.com, Geoff Thorpe , Roy Pledge From: Ferruh Yigit Message-ID: <2aee9218-f7b6-fe4d-d0a5-59b28d8a9149@intel.com> Date: Thu, 19 Jan 2017 19:07:10 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484832240-2048-6-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCHv5 03/33] drivers/common/dpaa2: adding qbman driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2017 19:07:15 -0000 On 1/19/2017 1:23 PM, Hemant Agrawal wrote: > QBMAN, is a hardware block which interfaces with the other > accelerating hardware blocks (For e.g., WRIOP) on NXP's DPAA2 > SoC for queue, buffer and packet scheduling. > > This patch introduces a userspace driver for interfacing with > the QBMAN hw block. > > The qbman-portal component provides APIs to do the low level > hardware bit twiddling for operations such as: > -initializing Qman software portals > -building and sending portal commands > -portal interrupt configuration and processing > > This same/similar code is used in kernel and compat file is used > to make it working in user space. > > Signed-off-by: Geoff Thorpe > Signed-off-by: Roy Pledge > Signed-off-by: Hemant Agrawal > --- <...> > diff --git a/drivers/common/dpaa2/qbman/include/compat.h b/drivers/common/dpaa2/qbman/include/compat.h > new file mode 100644 > index 0000000..d321cc6 > --- /dev/null > +++ b/drivers/common/dpaa2/qbman/include/compat.h > @@ -0,0 +1,403 @@ > +/* Copyright (c) 2008-2016 Freescale Semiconductor, Inc. > + * All rights reserved. Should this say "# BSD LICENSE" ? As in other file comments.. There are multiple this kind of usage. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions are met: > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * * Neither the name of Freescale Semiconductor nor the > + * names of its contributors may be used to endorse or promote products > + * derived from this software without specific prior written permission. > + * <...>