DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
@ 2021-10-04 10:02 Pavan Nikhilesh Bhagavatula
  2021-10-04 11:30 ` Ferruh Yigit
  0 siblings, 1 reply; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2021-10-04 10:02 UTC (permalink / raw)
  To: Ferruh Yigit, Jerin Jacob Kollanukkaran, Maciej Czekaj [C]; +Cc: dev

>On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Due to Linux kernel AF(Admin function) driver dependency, only
>enable
>> build for 64-bit Linux.
>>
>
>Hi Pavan,
>
>Isn't it possible to provide a commit log in the kernel side etc, that let
>others to verify why only 64 bit is required, or if someone want to
>support
>32bit that may help them to investigate the source of the restriction.

Arch 32 support is not implemented on ThunderX, so 32bit will not run.

>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>> ---
>>  v5 Changes
>>  - s/fuction/function.
>>
>>  v4 Changes:
>>  - Update commit message regarding dependency on AF driver.
>>
>>  drivers/net/thunderx/meson.build | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/thunderx/meson.build
>b/drivers/net/thunderx/meson.build
>> index 4bbcea7f93..da665bd76f 100644
>> --- a/drivers/net/thunderx/meson.build
>> +++ b/drivers/net/thunderx/meson.build
>> @@ -1,9 +1,9 @@
>>  # SPDX-License-Identifier: BSD-3-Clause
>>  # Copyright(c) 2017 Cavium, Inc
>>
>> -if is_windows
>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>      build = false
>> -    reason = 'not supported on Windows'
>> +    reason = 'only supported on 64-bit Linux'
>>      subdir_done()
>>  endif
>>
>> --
>> 2.17.1
>>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
  2021-10-04 10:02 [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux Pavan Nikhilesh Bhagavatula
@ 2021-10-04 11:30 ` Ferruh Yigit
  0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2021-10-04 11:30 UTC (permalink / raw)
  To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran,
	Maciej Czekaj [C]
  Cc: dev

On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>
>>> Due to Linux kernel AF(Admin function) driver dependency, only
>> enable
>>> build for 64-bit Linux.
>>>
>>
>> Hi Pavan,
>>
>> Isn't it possible to provide a commit log in the kernel side etc, that let
>> others to verify why only 64 bit is required, or if someone want to
>> support
>> 32bit that may help them to investigate the source of the restriction.
> 
> Arch 32 support is not implemented on ThunderX, so 32bit will not run.
> 

I see, is following correct:
All thunderx, octeonx & octeontx2 only supports VF in the DPDK, and PF is
supported by Linux kernel driver. And Linux kernel driver doesn't support arch32.

Is something changed in kernel driver side to drop the 32bit support?
If it was not supported at all, what is the motivation to disable the DPDK
drivers now?

>>
>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>> ---
>>>  v5 Changes
>>>  - s/fuction/function.
>>>
>>>  v4 Changes:
>>>  - Update commit message regarding dependency on AF driver.
>>>
>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/thunderx/meson.build
>> b/drivers/net/thunderx/meson.build
>>> index 4bbcea7f93..da665bd76f 100644
>>> --- a/drivers/net/thunderx/meson.build
>>> +++ b/drivers/net/thunderx/meson.build
>>> @@ -1,9 +1,9 @@
>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>  # Copyright(c) 2017 Cavium, Inc
>>>
>>> -if is_windows
>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>      build = false
>>> -    reason = 'not supported on Windows'
>>> +    reason = 'only supported on 64-bit Linux'
>>>      subdir_done()
>>>  endif
>>>
>>> --
>>> 2.17.1
>>>
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
  2021-10-04 12:01 Pavan Nikhilesh Bhagavatula
@ 2021-10-04 12:49 ` Ferruh Yigit
  0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2021-10-04 12:49 UTC (permalink / raw)
  To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran,
	Maciej Czekaj [C]
  Cc: dev

On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>>
>>>>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>>>>> enable
>>>>>>> build for 64-bit Linux.
>>>>>>>
>>>>>>
>>>>>> Hi Pavan,
>>>>>>
>>>>>> Isn't it possible to provide a commit log in the kernel side etc, that
>> let
>>>>>> others to verify why only 64 bit is required, or if someone want to
>>>>>> support
>>>>>> 32bit that may help them to investigate the source of the
>> restriction.
>>>>>
>>>>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>>>> run.
>>>>>
>>>>
>>>> I see, is following correct:
>>>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK,
>> and PF
>>>> is
>>>> supported by Linux kernel driver. And Linux kernel driver doesn't
>>>> support arch32.
>>>
>>> AF != PF, AF is something that manages all the shared resources
>> between PF/VF.
>>>
>>
>> I see, I though AF is part of PF functionality. Are there two different
>> kernel
>> modules for PF and AF?
>>
>> So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF by
>> Linux
>> kernel driver.
> 
> Yup that’s correct.
> 
>>
>>>>
>>>> Is something changed in kernel driver side to drop the 32bit support?
>>>> If it was not supported at all, what is the motivation to disable the
>> DPDK
>>>> drivers now?
>>>>
>>>
>>> It was never supported to begin with, motivation is that build will fail if
>> we try to
>>> compile with 32b.
>>>
>>
>> If there is no plan to support 32bit in the kernel side, that is reasonable
>> to
>> disable 32bit build, please provide above details in the commit log.
>>
>> And after above said, how much maintenance cost to support 32bit, if
>> the build
>> error is on the logging format "%lx" etc .. (as we mostly have 32bit build
>> errors), it is better to fix them using 'PRIx64' which is more proper way
>> anyway. If there is more logical issue with 32bit pointers, I agree with
>> you to
>> disable it.
>> Can you please provided the build error in the commit log as record?
>>
> 
> Apologies, I meant that all the functions that don’t fall under 64b are stubbed out
> so the driver wouldn’t work.
> 

so is there build error or not?

>>>>>>
>>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>>>> ---
>>>>>>>  v5 Changes
>>>>>>>  - s/fuction/function.
>>>>>>>
>>>>>>>  v4 Changes:
>>>>>>>  - Update commit message regarding dependency on AF driver.
>>>>>>>
>>>>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/drivers/net/thunderx/meson.build
>>>>>> b/drivers/net/thunderx/meson.build
>>>>>>> index 4bbcea7f93..da665bd76f 100644
>>>>>>> --- a/drivers/net/thunderx/meson.build
>>>>>>> +++ b/drivers/net/thunderx/meson.build
>>>>>>> @@ -1,9 +1,9 @@
>>>>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>>>>
>>>>>>> -if is_windows
>>>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>>>>      build = false
>>>>>>> -    reason = 'not supported on Windows'
>>>>>>> +    reason = 'only supported on 64-bit Linux'
>>>>>>>      subdir_done()
>>>>>>>  endif
>>>>>>>
>>>>>>> --
>>>>>>> 2.17.1
>>>>>>>
>>>>>
>>>
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
@ 2021-10-04 12:01 Pavan Nikhilesh Bhagavatula
  2021-10-04 12:49 ` Ferruh Yigit
  0 siblings, 1 reply; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2021-10-04 12:01 UTC (permalink / raw)
  To: Ferruh Yigit, Jerin Jacob Kollanukkaran, Maciej Czekaj [C]; +Cc: dev

>On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>>
>>>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>>>> enable
>>>>>> build for 64-bit Linux.
>>>>>>
>>>>>
>>>>> Hi Pavan,
>>>>>
>>>>> Isn't it possible to provide a commit log in the kernel side etc, that
>let
>>>>> others to verify why only 64 bit is required, or if someone want to
>>>>> support
>>>>> 32bit that may help them to investigate the source of the
>restriction.
>>>>
>>>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>>> run.
>>>>
>>>
>>> I see, is following correct:
>>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK,
>and PF
>>> is
>>> supported by Linux kernel driver. And Linux kernel driver doesn't
>>> support arch32.
>>
>> AF != PF, AF is something that manages all the shared resources
>between PF/VF.
>>
>
>I see, I though AF is part of PF functionality. Are there two different
>kernel
>modules for PF and AF?
>
>So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF by
>Linux
>kernel driver.

Yup that’s correct.

>
>>>
>>> Is something changed in kernel driver side to drop the 32bit support?
>>> If it was not supported at all, what is the motivation to disable the
>DPDK
>>> drivers now?
>>>
>>
>> It was never supported to begin with, motivation is that build will fail if
>we try to
>> compile with 32b.
>>
>
>If there is no plan to support 32bit in the kernel side, that is reasonable
>to
>disable 32bit build, please provide above details in the commit log.
>
>And after above said, how much maintenance cost to support 32bit, if
>the build
>error is on the logging format "%lx" etc .. (as we mostly have 32bit build
>errors), it is better to fix them using 'PRIx64' which is more proper way
>anyway. If there is more logical issue with 32bit pointers, I agree with
>you to
>disable it.
>Can you please provided the build error in the commit log as record?
>

Apologies, I meant that all the functions that don’t fall under 64b are stubbed out
so the driver wouldn’t work.

>>>>>
>>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>>> ---
>>>>>>  v5 Changes
>>>>>>  - s/fuction/function.
>>>>>>
>>>>>>  v4 Changes:
>>>>>>  - Update commit message regarding dependency on AF driver.
>>>>>>
>>>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/net/thunderx/meson.build
>>>>> b/drivers/net/thunderx/meson.build
>>>>>> index 4bbcea7f93..da665bd76f 100644
>>>>>> --- a/drivers/net/thunderx/meson.build
>>>>>> +++ b/drivers/net/thunderx/meson.build
>>>>>> @@ -1,9 +1,9 @@
>>>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>>>
>>>>>> -if is_windows
>>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>>>      build = false
>>>>>> -    reason = 'not supported on Windows'
>>>>>> +    reason = 'only supported on 64-bit Linux'
>>>>>>      subdir_done()
>>>>>>  endif
>>>>>>
>>>>>> --
>>>>>> 2.17.1
>>>>>>
>>>>
>>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
  2021-10-04 11:34 Pavan Nikhilesh Bhagavatula
@ 2021-10-04 11:50 ` Ferruh Yigit
  0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2021-10-04 11:50 UTC (permalink / raw)
  To: Pavan Nikhilesh Bhagavatula, Jerin Jacob Kollanukkaran,
	Maciej Czekaj [C]
  Cc: dev

On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>>
>>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>>> enable
>>>>> build for 64-bit Linux.
>>>>>
>>>>
>>>> Hi Pavan,
>>>>
>>>> Isn't it possible to provide a commit log in the kernel side etc, that let
>>>> others to verify why only 64 bit is required, or if someone want to
>>>> support
>>>> 32bit that may help them to investigate the source of the restriction.
>>>
>>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>> run.
>>>
>>
>> I see, is following correct:
>> All thunderx, octeonx & octeontx2 only supports VF in the DPDK, and PF
>> is
>> supported by Linux kernel driver. And Linux kernel driver doesn't
>> support arch32.
> 
> AF != PF, AF is something that manages all the shared resources between PF/VF.
> 

I see, I though AF is part of PF functionality. Are there two different kernel
modules for PF and AF?

So can DPDK driver drive PF? In a way, PF by DPDK, VF by DPDK, AF by Linux
kernel driver.

>>
>> Is something changed in kernel driver side to drop the 32bit support?
>> If it was not supported at all, what is the motivation to disable the DPDK
>> drivers now?
>>
> 
> It was never supported to begin with, motivation is that build will fail if we try to 
> compile with 32b.
> 

If there is no plan to support 32bit in the kernel side, that is reasonable to
disable 32bit build, please provide above details in the commit log.

And after above said, how much maintenance cost to support 32bit, if the build
error is on the logging format "%lx" etc .. (as we mostly have 32bit build
errors), it is better to fix them using 'PRIx64' which is more proper way
anyway. If there is more logical issue with 32bit pointers, I agree with you to
disable it.
Can you please provided the build error in the commit log as record?

>>>>
>>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>>> ---
>>>>>  v5 Changes
>>>>>  - s/fuction/function.
>>>>>
>>>>>  v4 Changes:
>>>>>  - Update commit message regarding dependency on AF driver.
>>>>>
>>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/thunderx/meson.build
>>>> b/drivers/net/thunderx/meson.build
>>>>> index 4bbcea7f93..da665bd76f 100644
>>>>> --- a/drivers/net/thunderx/meson.build
>>>>> +++ b/drivers/net/thunderx/meson.build
>>>>> @@ -1,9 +1,9 @@
>>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>>
>>>>> -if is_windows
>>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>>      build = false
>>>>> -    reason = 'not supported on Windows'
>>>>> +    reason = 'only supported on 64-bit Linux'
>>>>>      subdir_done()
>>>>>  endif
>>>>>
>>>>> --
>>>>> 2.17.1
>>>>>
>>>
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
@ 2021-10-04 11:34 Pavan Nikhilesh Bhagavatula
  2021-10-04 11:50 ` Ferruh Yigit
  0 siblings, 1 reply; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2021-10-04 11:34 UTC (permalink / raw)
  To: Ferruh Yigit, Jerin Jacob Kollanukkaran, Maciej Czekaj [C]; +Cc: dev

>On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
>>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>>
>>>> Due to Linux kernel AF(Admin function) driver dependency, only
>>> enable
>>>> build for 64-bit Linux.
>>>>
>>>
>>> Hi Pavan,
>>>
>>> Isn't it possible to provide a commit log in the kernel side etc, that let
>>> others to verify why only 64 bit is required, or if someone want to
>>> support
>>> 32bit that may help them to investigate the source of the restriction.
>>
>> Arch 32 support is not implemented on ThunderX, so 32bit will not
>run.
>>
>
>I see, is following correct:
>All thunderx, octeonx & octeontx2 only supports VF in the DPDK, and PF
>is
>supported by Linux kernel driver. And Linux kernel driver doesn't
>support arch32.

AF != PF, AF is something that manages all the shared resources between PF/VF.

>
>Is something changed in kernel driver side to drop the 32bit support?
>If it was not supported at all, what is the motivation to disable the DPDK
>drivers now?
>

It was never supported to begin with, motivation is that build will fail if we try to 
compile with 32b.

>>>
>>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>> ---
>>>>  v5 Changes
>>>>  - s/fuction/function.
>>>>
>>>>  v4 Changes:
>>>>  - Update commit message regarding dependency on AF driver.
>>>>
>>>>  drivers/net/thunderx/meson.build | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/thunderx/meson.build
>>> b/drivers/net/thunderx/meson.build
>>>> index 4bbcea7f93..da665bd76f 100644
>>>> --- a/drivers/net/thunderx/meson.build
>>>> +++ b/drivers/net/thunderx/meson.build
>>>> @@ -1,9 +1,9 @@
>>>>  # SPDX-License-Identifier: BSD-3-Clause
>>>>  # Copyright(c) 2017 Cavium, Inc
>>>>
>>>> -if is_windows
>>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>>      build = false
>>>> -    reason = 'not supported on Windows'
>>>> +    reason = 'only supported on 64-bit Linux'
>>>>      subdir_done()
>>>>  endif
>>>>
>>>> --
>>>> 2.17.1
>>>>
>>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
  2021-10-04  5:56 ` [dpdk-dev] [PATCH v5 " pbhagavatula
@ 2021-10-04  9:05   ` Ferruh Yigit
  0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2021-10-04  9:05 UTC (permalink / raw)
  To: pbhagavatula, jerinj, Maciej Czekaj; +Cc: dev

On 10/4/2021 6:56 AM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Due to Linux kernel AF(Admin function) driver dependency, only enable
> build for 64-bit Linux.
> 

Hi Pavan,

Isn't it possible to provide a commit log in the kernel side etc, that let
others to verify why only 64 bit is required, or if someone want to support
32bit that may help them to investigate the source of the restriction.

> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  v5 Changes
>  - s/fuction/function.
> 
>  v4 Changes:
>  - Update commit message regarding dependency on AF driver.
> 
>  drivers/net/thunderx/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
> index 4bbcea7f93..da665bd76f 100644
> --- a/drivers/net/thunderx/meson.build
> +++ b/drivers/net/thunderx/meson.build
> @@ -1,9 +1,9 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Cavium, Inc
> 
> -if is_windows
> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>      build = false
> -    reason = 'not supported on Windows'
> +    reason = 'only supported on 64-bit Linux'
>      subdir_done()
>  endif
> 
> --
> 2.17.1
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux
  2021-10-03 20:36 [dpdk-dev] [PATCH v4 " pbhagavatula
@ 2021-10-04  5:56 ` pbhagavatula
  2021-10-04  9:05   ` Ferruh Yigit
  0 siblings, 1 reply; 8+ messages in thread
From: pbhagavatula @ 2021-10-04  5:56 UTC (permalink / raw)
  To: ferruh.yigit, jerinj, Maciej Czekaj; +Cc: dev, Pavan Nikhilesh

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel AF(Admin function) driver dependency, only enable
build for 64-bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
 v5 Changes
 - s/fuction/function.

 v4 Changes:
 - Update commit message regarding dependency on AF driver.

 drivers/net/thunderx/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/thunderx/meson.build b/drivers/net/thunderx/meson.build
index 4bbcea7f93..da665bd76f 100644
--- a/drivers/net/thunderx/meson.build
+++ b/drivers/net/thunderx/meson.build
@@ -1,9 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc

-if is_windows
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     build = false
-    reason = 'not supported on Windows'
+    reason = 'only supported on 64-bit Linux'
     subdir_done()
 endif

--
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-10-04 12:50 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 10:02 [dpdk-dev] [PATCH v5 1/3] net/thunderx: enable build only on 64-bit Linux Pavan Nikhilesh Bhagavatula
2021-10-04 11:30 ` Ferruh Yigit
  -- strict thread matches above, loose matches on Subject: below --
2021-10-04 12:01 Pavan Nikhilesh Bhagavatula
2021-10-04 12:49 ` Ferruh Yigit
2021-10-04 11:34 Pavan Nikhilesh Bhagavatula
2021-10-04 11:50 ` Ferruh Yigit
2021-10-03 20:36 [dpdk-dev] [PATCH v4 " pbhagavatula
2021-10-04  5:56 ` [dpdk-dev] [PATCH v5 " pbhagavatula
2021-10-04  9:05   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).