From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C93C41CFC; Tue, 21 Feb 2023 11:42:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FDEB431BF; Tue, 21 Feb 2023 11:42:28 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2087.outbound.protection.outlook.com [40.107.95.87]) by mails.dpdk.org (Postfix) with ESMTP id 50312406A2 for ; Tue, 21 Feb 2023 11:42:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bedi4cD7cqbh4vV7l58qiuDA2ZLidMoFAs8TujMTdTSBzaHK3Ji+aIlYOG9KRI86ASv7QHpTLxOYWtUTXq2VZst5uDVkxE8Fpxv8yvOjoqb0fb6Th8vFqaRJArWZ53m5lMk/S5jFLq32MmAOSsfP+XHK/Mu6wQ0Yf7j46u0xbr3SXP2VxQaCI3Y2ZRFwdpuyhdXQlv5lpM7GswQ8PHYpgz1RGfTRRi8Kp/K1+kNPSLkug38qHagxKJCIe/uEg5Y2SinVH5f4ZouJmQgQVLMNmbzcb9SPEnL5RIzU7rjWQq+orqea5aWpK5rRnQ1MNJR7RE7H9Mgo8aE5E+nBBmTHOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ur0rfs2e3p+N94rmfFIt76J95AhM+7wYe6647o7YYsU=; b=VfglvUH4VKnaaPrJG7eYMNVGU7DjslcKK8IhEJGmm2yfcAYfxiXBN8Hp9jvNelaqj07wgaTQ+Q3DJ/Kl1ppDRQRLhtP3A0qNPcgIxVIqDVE6Pe0a/VOrmvICiUZ58DbLbnm1lyg6EqvcSlpw626atPXUEFvgYsKchPHUah+MDIGouSS0z0M3oL9/kmwe4+4/8Lk07ACZQkpflkWq+8vSe3Zcljja2/DY+6aa13WkC/6zzhKwhjO307qg8SpjmUw/W0V1X6OkF5ycUsFTjGjC9g8OD31dt9qqBC2+dl3iuYw550MalTHjp2YugeMQ5JHd4AV2dNcdF2Xr4GrvC1pKCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ur0rfs2e3p+N94rmfFIt76J95AhM+7wYe6647o7YYsU=; b=PImomFXk0KUKb5XboFPFUEHKqSlYunufFZebm34xeGizNHLTuqvWzP18Kxov10J4Q1JKqkjZTxpofswMXXDqN93UBBqv9WjHk3wQsifjgY6QNG0E+kbZfDr2bba1hUhGwxojm7UYozP24Buz2D3yTQFuvdXrIHfWO83PI7bG8kI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5194.namprd12.prod.outlook.com (2603:10b6:408:11b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 21 Feb 2023 10:42:24 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 10:42:24 +0000 Message-ID: <2afe3d25-62d9-f9d5-10a1-50a59bdb6cf6@amd.com> Date: Tue, 21 Feb 2023 10:42:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 2/3] doc: update outdated information for the nfp PMD Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers , Niklas Soderlund , Walter Heymans References: <20230203080845.24126-1-chaoyong.he@corigine.com> <20230220084111.40531-1-chaoyong.he@corigine.com> <20230220084111.40531-3-chaoyong.he@corigine.com> <58d6df9a-4f4d-b911-a08a-d13e3688f23e@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0360.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::36) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5194:EE_ X-MS-Office365-Filtering-Correlation-Id: 49e7df6b-cb1c-4b5e-aab3-08db13f85147 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cZgKJtxHiQDQyk+DJRZhBG4cKa9C3XHEePYoW2F8BbfgEo53kVQbm5dGY9fHEFC9UHzEktgFw0kXUzf7vU/qEsAYFi7TwnczWBp0Wmen894HP/cA7Mmd3HBBnW2QsOpFP+oSBLjFM6ueqyZRoStNkt7v/0B+DpTciRqRj5d0zLWFk/IKMmcd8TcvaGTaMtG3PXbdm7M8Wx6u3D9V0DM5UCpBDr2ZZ4UrsTIRRX6BRrYoNJNiP9UyUdKDg6GEzqIDcFoaaOgtmZIY9Xeb70Er+P0hNa8k+oGQnxIVm5dZxbRpIgDqRYXy0/JBO2D1RS8aDilmhmCy2pmvF6LdWOD+kBgSakahD3TkAGAbJ3XUpnggptOrrEAE6Ktl7WHuPivi73lvUndbS8QL5DKiijHafiJ1DhIphfkfhl1zyg9GYitwIrINurmGZeRGnqmJeDBqwrGzCkN/fQIzHidEYvSPWfxQah+mTxEGv/lHDqbrt7N/F9IHOg2Wu1HNxb4DD4vs5DCNxYPYEoPXGaJSrHHY/GqpN7LB/A/n9sO7WRqAxOVhXI7fuZM3dTPRf6fF8TZDpIQs7SieNGioAo22SASceaVigRo0aJMeiAOHBNlLTXuaiMS8kgh4y2HwAyCqm1FcLE5VzKAUDDfV6bUo3Q3CjlMXY3Nx4XhMRaaUXp2fg/sNVTkoGaLnOrKPZ3eDk3dmpBQn1HojKrBZNLgEHvyofSx/fs/ZzHmUKIQhLRxawuU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199018)(6512007)(966005)(15650500001)(31696002)(2906002)(66556008)(38100700002)(44832011)(5660300002)(6486002)(66574015)(31686004)(36756003)(6666004)(6506007)(86362001)(478600001)(2616005)(8676002)(316002)(186003)(66946007)(53546011)(66476007)(8936002)(110136005)(4326008)(26005)(83380400001)(41300700001)(54906003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWpCb0loYVdiVVI1UWhlNzlOSU5vS3REYm5rSlV5bVBPc2tGYzdhL3lMcjZB?= =?utf-8?B?Y0JSRGl2UmFtSEY2SlVqSTdPc0F2WmxqeEZ2elUrcHBObEN6WlJEV1l6amVp?= =?utf-8?B?bGg5aTFuY3VwWlkzL2ljQ3YvZ1E0VzVhM3ZnWjB1QWI0ZXNlM1JVWEtxVXoy?= =?utf-8?B?SUZMZi9LNEUrUUdNSXBLclpZMHZhR2lZYlpYcUcyVVI1RjV3YnZsYlJ0TUlu?= =?utf-8?B?RWFJd3ZwV29QOWRhMmFxY0hGMDU3SWdiMFh6anZ4eXBSV1l1ZU1yN3dsWUdn?= =?utf-8?B?OXo0c0lLREpBL0c0aFgyMDVtY21mUUc3ZGFwMitkc1ZUU2w0cmViMU9pSTdE?= =?utf-8?B?NEt6aVZtQXR6cnBRNFZJNzlTb3lNQnY0QUM2Y3prUU9HODNlVVd4d3gyQ050?= =?utf-8?B?Z1VVeUFXM0pRajBvUnZ6VG9oWE9hL1JUdUY2SjRXS3pxVEdYUVJ2cWFvODhl?= =?utf-8?B?VHBobDF4SmRGM3IxcUdialVqTWhQc3JVd1ZmSmQ0V2tWWmV5anZoYXdTdWFp?= =?utf-8?B?MGI4VkR6SE1tdUtzV2krdFVZa1lUcTZFT285S0JReGFKajlZNnZXMEIrcjhl?= =?utf-8?B?alNMWFJjcnlkREVNVWdqbzFyMUFJdXN4eURXS3ZybE1MMkYzTkgyNGRCMEJY?= =?utf-8?B?cG9ocWN1Z0FOZVlveU83TEV2YUNTU2IzTXZQaS9wSFFTMktBbXZzdWlsWE5I?= =?utf-8?B?Q0VNaENtMWZWbUg1UzNaTjhYSlNSOXB0bExoTVU3OUovMlFrRmw4SnB4Vmsy?= =?utf-8?B?WkVNR2ZCOGxsRWFqa2YrMEdjRlVPUlZxaHJLOVhGb3FHbjdyYjhTZzhPZE5y?= =?utf-8?B?S1czdXR0djMwdXN3QUZLSCtGRkY3dnBxNVlYMnV1Z2E5cFJzVkdQdHRWWmVF?= =?utf-8?B?QWhoWWJCUndFRmVLN0FjcXZ1S1hiY0JGUGNjcVMyd1Bzdnp0R0FwN2VSc3E5?= =?utf-8?B?aEVFN3NjVStlUXd3dW1FcGlZNTd1c2czdGw0SlBDVThjL281Y1kvNnp0aW8y?= =?utf-8?B?Y2NDY2VTVUdIUXVCZkdTNmVNb0hWbEdVbXZSZ2VrRzRjNWp3TVBTSDBEZnFO?= =?utf-8?B?NmVpMG1XSFpxT3JhakQ3REg4ZUNWc3duS3pZUWQyaVpQMmFWZTdQZUlibHA4?= =?utf-8?B?V3dkSGczZ2tJa2xiZ2Frd2lBcFBiNi94SDVqalF4cGxFdEFTRzBnOGp2eHo1?= =?utf-8?B?Y2tDd1p0RjlROEdqd0dzbFJmbTVzQXp4RXB3WEJackF1SzgvMkpxUmx0ek5k?= =?utf-8?B?M3VtWG5YTU0wMG1Qb3NFN2FaOFowajhNL2crWm5zN3A5dXQ1Qy9XWlYrTzY1?= =?utf-8?B?ZFNMaDB1cjFxWURvN3UwZWx4UXRaeGxva2VBWTFaMytzTndSVy8wQTRPZjIx?= =?utf-8?B?WXN0T2ZOMVoyS2l6UjFLOHlJa2paN0I0amd1L0hjRExoYlhDMm4yTy9MMlVH?= =?utf-8?B?a3hHSDhkcTdCbHJ0SDBHVk1RZ1Yxc2RERENvTGhQQ1dxUWxIdExPbEl4bmc2?= =?utf-8?B?OGJJcWVKNm9PazQ5SjcxdVlQYWJVbWdpQ01vaklwbm5qT1lRREtVa2FMckxR?= =?utf-8?B?R1A1eWxHZW5zbFk2ZEM4VGdVTE50MkxwQWJLR2pJVEFzSTVRL3pOeGlhYmxY?= =?utf-8?B?UEtTeURWdS9DdEgvN0VNMDd1bFE1K1JqcEFTaWVIQW9NQ3liUlJOeUpIbnU2?= =?utf-8?B?eWl4cG16NlZXU1l0c3AyOGUrZ3duY1oxakpRZ3RETi9rUFc5WlFyTHMwQjQ5?= =?utf-8?B?Uk40eVYyWG5MMlJRQUppWVZyZDRra2lhb1lsM0hQR0ZQMlZyT3hyZlVmZGF1?= =?utf-8?B?dGJ5VVhzRWNvS3ptNjBRenVLUDVjUG92UEw3Z3RhTk9IQ1htWnduTloyQTBE?= =?utf-8?B?ZWJFeXptb291RlFTaFo4T0tTT1ZrZlVVOTFQVkxod3hzNElsbG51NEJHcldt?= =?utf-8?B?WCtZMy9vc2dOMU1jbVZRRW93T0IvWFlXNjJ0QS8wWVZHNXdEeHhRcE1WeU03?= =?utf-8?B?K0cydm1NVE15VFA4SzdJWkN1VmFTQVRiMlo3Nm1TNmtQa3NkVnUvWUtPazVG?= =?utf-8?B?QkNQNFVBTVpGT0sxR2RqcUJBME13UGVxT0xsTmREQnhNZURyWlo5RlU1YkRh?= =?utf-8?Q?MVJ6wREpRDQseh0n/ozj8J0zA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49e7df6b-cb1c-4b5e-aab3-08db13f85147 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:42:24.1881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3fEryywyLGZ2/LMBaUFl25d5r34IgQeeaY99rdt7ZXWUTUMwWOI1B2d+0gxumk5t X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5194 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/21/2023 10:11 AM, Chaoyong He wrote: >> On 2/21/2023 9:04 AM, Chaoyong He wrote: >>>> On 2/20/2023 8:41 AM, Chaoyong He wrote: >>>>> From: Walter Heymans >>>>> >>>>> Update nfp documentation with new information and remove outdated >>>>> information. The most significant changes that are updated include: >>>>> - Previously the NFP PMD did not support functionality to control VFs, >>>>> it now does. >>>> >>>> What I understand is DPDK supports VF but if PF is bound to Linux driver. >>>> >>>> Previously support matrix was as following: >>>> >>>> PF VF is supported >>>> ----- ---- -------------- >>>> Linux DPDK Yes >>>> DPDK - Yes >>>> DPDK DPDK NO >>>> DPDK Linux ?No (not recommended) >>>> >>>> >>>> Is PF:DPDK, VF:DPDK supported now? >>>> This requires DPDK PF driver updated to manage VFs, if so can you >>>> please list commits that adds this support in this commit log? >>> >>> Yes, we support this mode now. >>> But actually, our PMD didn't do anything to support it. >>> After the VFIO module in kernel has support vf (not sure about the exact >> kernel version import this), we can directly use the command below to >> support this mode. >>> modprobe vfio-pci enable_sriov=1 disable_idle_d3=1 dpdk-devbind.py -b >>> vfio-pci xx:yy.z echo 2 > >>> /sys/bus/pci/devices/0000\:xx\:yy.z/sriov_numvfs >>> And we get this information first time in this link: >>> https://lwn.net/Articles/813045/ >>> >> >> Ability to create VF via vfio-pci is one thing, as you said that support is added >> unrelated to the driver. >> >> Other thing is PF driver's capability to manage VFs, since not all operations >> are supported by VF driver, sometimes VF driver sends a request to PF driver >> for this, so PF should have capability to receive and handle these requests. Is >> your driver working in similar way? > > Our PMD doesn't has a similar way like this. > The VF either share the same operation function with PF or has a special operation function, or just don't implement the operation at all. > Maybe in the future we have to add something like this, but for now we don't have that yet. > OK, thanks for clarification. I wasn't sure about it, no more objection from me. >> Following documentation is from previous version (that this set removes): >> " >> ... >> Future DPDK versions will have a PMD able to work with the PF and VFs at >> the same time and with the PF implementing VF management along with >> other PF-only functionalities/offloads. >> " >> >> I was expecting some code changes are required for above mentioned "PF >> implementing VF management", are they done already? If so while removing >> that part of the documentation it can be good to document commit IDs of >> those changes. > How about just drop the modification of this parameter? > Is that more acceptable? > >> >> And more directly, right now, do you support to run dpdk application on top >> of both PF and VF at the *same* time? > > Yes, we support that, for example, we can run the testpmd app on top of both PF and VF at the same time. > ack >> >>>> >>>>> - Previously the PF had to be bound to the kernel driver to create VFs, >>>>> then VFs were created and bound to 'vfio-pci'. Currently it is >>>>> possible to bind the PF to 'vfio-pci' and create VFs bound to >>>>> 'vfio-pci'. >>>>> - The name of the Linux kernel driver changed for VFs. Previously the >>>>> 'nfp_netvf' module was used, but now both PFs and VFs use the 'nfp' >>>>> module. >>>>> >>>>> Signed-off-by: Walter Heymans >>>>> Reviewed-by: Chaoyong He >>>>> Reviewed-by: Niklas Söderlund >>>> >>>> <...> >>>> >>>>> @@ -209,8 +207,8 @@ vNIC service will keep polling packets from the >>>>> firmware, and multiplex them to the corresponding representor port. >>>>> >>>>> In the Tx direction, the representor port will prepend the output >>>>> port -information into metadata for each packet, and then send it to >>>>> firmware through -PF vNIC. >>>>> +information into metadata for each packet, and then send it to the >>>>> +firmware through the PF vNIC. >>>>> >>>> >>>> Above change belongs to first patch. >>> >>> Thanks, we will move it in the next version. > I can proceed with set after this minor change, thanks.