From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3AE091B5B3 for ; Fri, 22 Mar 2019 12:00:17 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9650C3082AF0; Fri, 22 Mar 2019 11:00:16 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B8095D75F; Fri, 22 Mar 2019 11:00:15 +0000 (UTC) To: Hajkowski , david.hunt@intel.com Cc: dev@dpdk.org References: <20190321105506.6656-1-marcinx.hajkowski@intel.com> <20190321105506.6656-3-marcinx.hajkowski@intel.com> From: Maxime Coquelin Message-ID: <2b064351-9ac0-ce14-4719-1eb72a7fa338@redhat.com> Date: Fri, 22 Mar 2019 12:00:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190321105506.6656-3-marcinx.hajkowski@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 22 Mar 2019 11:00:16 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for reading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 11:00:17 -0000 On 3/21/19 11:55 AM, Hajkowski wrote: > From: Marcin Hajkowski > > Added new experimental API rte_power_guest_channel_receive_msg > which gives possibility to receive messages send to guest. > > Signed-off-by: Marcin Hajkowski > --- > lib/librte_power/channel_commands.h | 5 ++ > lib/librte_power/guest_channel.c | 65 ++++++++++++++++++++++++++ > lib/librte_power/guest_channel.h | 35 ++++++++++++++ > lib/librte_power/rte_power_version.map | 1 + > 4 files changed, 106 insertions(+) > > diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h > index e7b93a797..33fd53a6d 100644 > --- a/lib/librte_power/channel_commands.h > +++ b/lib/librte_power/channel_commands.h > @@ -28,6 +28,11 @@ extern "C" { > #define CPU_POWER_SCALE_MIN 4 > #define CPU_POWER_ENABLE_TURBO 5 > #define CPU_POWER_DISABLE_TURBO 6 > + > +/* Generic Power Command Response */ > +#define CPU_POWER_CMD_ACK 1 > +#define CPU_POWER_CMD_NACK 2 > + > #define HOURS 24 > > #define MAX_VFS 10 > diff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c > index 9cf7d2cb2..3213fa769 100644 > --- a/lib/librte_power/guest_channel.c > +++ b/lib/librte_power/guest_channel.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > > #include > @@ -19,6 +20,9 @@ > > #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1 > > +/* Timeout for incoming message in milliseconds. */ > +#define TIMEOUT 10 > + > static int global_fds[RTE_MAX_LCORE] = { [0 ... RTE_MAX_LCORE-1] = -1 }; > > int > @@ -125,6 +129,67 @@ int rte_power_guest_channel_send_msg(struct channel_packet *pkt, > return guest_channel_send_msg(pkt, lcore_id); > } > > +int power_guest_channel_read_msg(struct channel_packet *pkt, > + unsigned int lcore_id) > +{ > + int ret; > + > + struct pollfd fds; > + fds.fd = global_fds[lcore_id]; > + fds.events = POLLIN; > + > + ret = poll(&fds, 1, TIMEOUT); > + if (ret == 0) { > + RTE_LOG(DEBUG, GUEST_CHANNEL, "Timeout occurs during poll function.\n"); > + return -1; > + } else if (ret < 0) { > + RTE_LOG(ERR, GUEST_CHANNEL, "Error occurred during poll function: %s\n", > + strerror(ret)); > + return -1; > + } > + > + void *buffer = pkt; I would prefer it to be declared at the beginning of the function, but at least, declare it just before the while loop. > + > + if (lcore_id >= RTE_MAX_LCORE) { > + RTE_LOG(ERR, GUEST_CHANNEL, "Channel(%u) is out of range 0...%d\n", > + lcore_id, RTE_MAX_LCORE-1); > + return -1; > + } > + > + if (global_fds[lcore_id] < 0) { > + RTE_LOG(ERR, GUEST_CHANNEL, "Channel is not connected\n"); > + return -1; > + } > + > + int buffer_len = sizeof(*pkt); > + > + while (buffer_len > 0) { > + ret = read(global_fds[lcore_id], > + buffer, buffer_len); > + if (ret < 0) { > + if (errno == EINTR) > + continue; > + return -1; > + } > + /* No data has been read, this can indicate not > + * consistent buffer_len with actual data size. > + */ > + if (ret == 0) { > + RTE_LOG(ERR, GUEST_CHANNEL, "No more data has been read.\n"); > + return -1; > + } > + buffer = (char *)buffer + ret; > + buffer_len -= ret; > + } > + > + return 0; > +} > + From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3E3F1A00E6 for ; Fri, 22 Mar 2019 12:00:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 034CF1B5B5; Fri, 22 Mar 2019 12:00:19 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3AE091B5B3 for ; Fri, 22 Mar 2019 12:00:17 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9650C3082AF0; Fri, 22 Mar 2019 11:00:16 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B8095D75F; Fri, 22 Mar 2019 11:00:15 +0000 (UTC) To: Hajkowski , david.hunt@intel.com Cc: dev@dpdk.org References: <20190321105506.6656-1-marcinx.hajkowski@intel.com> <20190321105506.6656-3-marcinx.hajkowski@intel.com> From: Maxime Coquelin Message-ID: <2b064351-9ac0-ce14-4719-1eb72a7fa338@redhat.com> Date: Fri, 22 Mar 2019 12:00:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190321105506.6656-3-marcinx.hajkowski@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 22 Mar 2019 11:00:16 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 2/4] power: extend guest channel api for reading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322110013.na4jiuAQI--npLxgEWK53vHpoRyHFCAPVlreLE7ADAQ@z> On 3/21/19 11:55 AM, Hajkowski wrote: > From: Marcin Hajkowski > > Added new experimental API rte_power_guest_channel_receive_msg > which gives possibility to receive messages send to guest. > > Signed-off-by: Marcin Hajkowski > --- > lib/librte_power/channel_commands.h | 5 ++ > lib/librte_power/guest_channel.c | 65 ++++++++++++++++++++++++++ > lib/librte_power/guest_channel.h | 35 ++++++++++++++ > lib/librte_power/rte_power_version.map | 1 + > 4 files changed, 106 insertions(+) > > diff --git a/lib/librte_power/channel_commands.h b/lib/librte_power/channel_commands.h > index e7b93a797..33fd53a6d 100644 > --- a/lib/librte_power/channel_commands.h > +++ b/lib/librte_power/channel_commands.h > @@ -28,6 +28,11 @@ extern "C" { > #define CPU_POWER_SCALE_MIN 4 > #define CPU_POWER_ENABLE_TURBO 5 > #define CPU_POWER_DISABLE_TURBO 6 > + > +/* Generic Power Command Response */ > +#define CPU_POWER_CMD_ACK 1 > +#define CPU_POWER_CMD_NACK 2 > + > #define HOURS 24 > > #define MAX_VFS 10 > diff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c > index 9cf7d2cb2..3213fa769 100644 > --- a/lib/librte_power/guest_channel.c > +++ b/lib/librte_power/guest_channel.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > > #include > @@ -19,6 +20,9 @@ > > #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1 > > +/* Timeout for incoming message in milliseconds. */ > +#define TIMEOUT 10 > + > static int global_fds[RTE_MAX_LCORE] = { [0 ... RTE_MAX_LCORE-1] = -1 }; > > int > @@ -125,6 +129,67 @@ int rte_power_guest_channel_send_msg(struct channel_packet *pkt, > return guest_channel_send_msg(pkt, lcore_id); > } > > +int power_guest_channel_read_msg(struct channel_packet *pkt, > + unsigned int lcore_id) > +{ > + int ret; > + > + struct pollfd fds; > + fds.fd = global_fds[lcore_id]; > + fds.events = POLLIN; > + > + ret = poll(&fds, 1, TIMEOUT); > + if (ret == 0) { > + RTE_LOG(DEBUG, GUEST_CHANNEL, "Timeout occurs during poll function.\n"); > + return -1; > + } else if (ret < 0) { > + RTE_LOG(ERR, GUEST_CHANNEL, "Error occurred during poll function: %s\n", > + strerror(ret)); > + return -1; > + } > + > + void *buffer = pkt; I would prefer it to be declared at the beginning of the function, but at least, declare it just before the while loop. > + > + if (lcore_id >= RTE_MAX_LCORE) { > + RTE_LOG(ERR, GUEST_CHANNEL, "Channel(%u) is out of range 0...%d\n", > + lcore_id, RTE_MAX_LCORE-1); > + return -1; > + } > + > + if (global_fds[lcore_id] < 0) { > + RTE_LOG(ERR, GUEST_CHANNEL, "Channel is not connected\n"); > + return -1; > + } > + > + int buffer_len = sizeof(*pkt); > + > + while (buffer_len > 0) { > + ret = read(global_fds[lcore_id], > + buffer, buffer_len); > + if (ret < 0) { > + if (errno == EINTR) > + continue; > + return -1; > + } > + /* No data has been read, this can indicate not > + * consistent buffer_len with actual data size. > + */ > + if (ret == 0) { > + RTE_LOG(ERR, GUEST_CHANNEL, "No more data has been read.\n"); > + return -1; > + } > + buffer = (char *)buffer + ret; > + buffer_len -= ret; > + } > + > + return 0; > +} > +