From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
To: Tal Shnaiderman <talshn@nvidia.com>, dev@dpdk.org
Cc: thomas@monjalon.net, dmitry.kozliuk@gmail.com,
navasile@linux.microsoft.com, dmitrym@microsoft.com,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register
Date: Fri, 4 Dec 2020 16:56:22 -0800 [thread overview]
Message-ID: <2b0afab6-ad6e-10cf-6055-a07a77d075c4@intel.com> (raw)
In-Reply-To: <20201126080639.16240-1-talshn@nvidia.com>
Hi Tal,
On 11/26/2020 12:06 AM, Tal Shnaiderman wrote:
> interrupt callback register is not implemented in Windows.
> Add stub with -ENOTSUP return value and export the function.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> lib/librte_eal/rte_eal_exports.def | 1 +
> lib/librte_eal/windows/eal_interrupts.c | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 6a6be1cfa6..08cf25ea01 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -63,6 +63,7 @@ EXPORTS
> rte_get_tsc_hz
> rte_hexdump
> rte_hypervisor_get
> + rte_intr_callback_register
> rte_intr_rx_ctl
> rte_lcore_count
> rte_lcore_has_role
> diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> index 6c64a48f34..fea338d705 100644
> --- a/lib/librte_eal/windows/eal_interrupts.c
> +++ b/lib/librte_eal/windows/eal_interrupts.c
> @@ -105,3 +105,12 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
>
> return 0;
> }
> +
> +int
> +rte_intr_callback_register(
> + __rte_unused const struct rte_intr_handle *intr_handle,
> + __rte_unused rte_intr_callback_fn cb,
> + __rte_unused void *cb_arg)
> +{
> + return -ENOTSUP;
> +}
We have also included the same code as it is required to compile i40e PMD.
Will remove it from our patch once this code is merged.
Thanks,
next prev parent reply other threads:[~2020-12-05 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 8:06 Tal Shnaiderman
2020-12-01 16:41 ` Dmitry Kozlyuk
2020-12-05 0:56 ` Kadam, Pallavi [this message]
2020-12-07 20:43 ` Thomas Monjalon
2020-12-05 0:57 ` Kadam, Pallavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b0afab6-ad6e-10cf-6055-a07a77d075c4@intel.com \
--to=pallavi.kadam@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).