From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5548843A23; Wed, 7 Feb 2024 01:57:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B92AD402C8; Wed, 7 Feb 2024 01:57:51 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2052.outbound.protection.outlook.com [40.107.243.52]) by mails.dpdk.org (Postfix) with ESMTP id 8D5E540295 for ; Wed, 7 Feb 2024 01:57:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLxzA1FsfZS0qaxjClSnwaN19B59XnSFIb85VTE6009azXS+B7e2my9v6hDu0I7ELAE5pMnBOTOvqiVcJ4E6+Myuj6KBQo/YO/+7h3VMZbu44LUM0qVTpo2LG9ABN7zIox01yLrZJSlhhwgn6Jel04lRJosZuxxKdYmN2w2K0hLXt51ceQKJYNIbMOvl7QnpXkSugdsBVIOnl6qhsZbLbJrMvaXEiOc6TsxQCAHdK8YFBtrBe8dIkQyvcqAEzd3l8yb1Auvr/t0ohaqpKBZlEer8e8Jnpj6jmzWFq1Q765PNZxFfwQgDfpcWmgmC15/AJLEaPVm1hSLwRUAxJ4WXtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OzC4/rTUQBMwYjek4bQNKh5y3ivVM2vmB+xcwOTXFpg=; b=nVJCblAkeCaEv7d5G/svh2NZGJ9rZH5PWWCIVKOD2l5989Qee9Z2AeZwJDjds32Xyd64Vhex+/adW0JBYSLpBdFPZec6pRVp1vVmJIZM0GCNXEOB88Ry7vAnp1qc5PLBQOOhTElbJVBUwnsnXBpXq/bT30VOD3hup7B2Q8WKToMzQ6o0rEYSCR9ykXVI3wG/y5mOtx5/JU44KtQ9r++BBkT6ujsn1citGO18WSSjfMM1SKMhNwcIzRHucqTcFCnpwNqVOsv8FgnSWzn9TcFBDQNeeyvGrLDY7EL933mhgvt2bC6q0OBzSg0M2JlDiAtj3Xjt2ajJxz200bPtvLP8Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OzC4/rTUQBMwYjek4bQNKh5y3ivVM2vmB+xcwOTXFpg=; b=Qj+l7/6AGKDesVYdHYDLiLKcPzM7iGs5EoN4mcEspk6cAyijO6BVVi7jASWD11do9Vj4glTKvaGzQ785pDsnVvswCQVB8kEAWZ8RSFcOaGAVFirfqPNJF1BRRLfQyUCthrHIwSMaXKF3HR3bIen675MbUMbUF11MWC9jnX/DYaw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6040.namprd12.prod.outlook.com (2603:10b6:8:af::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.8; Wed, 7 Feb 2024 00:57:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 00:57:47 +0000 Message-ID: <2b0c7fe0-5713-4416-987e-34da0dc4aaef@amd.com> Date: Wed, 7 Feb 2024 00:57:42 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ethdev: fast path async flow API Content-Language: en-US To: Thomas Monjalon , Dariusz Sosnowski Cc: Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , dev@dpdk.org References: <20240131093523.1553028-1-dsosnowski@nvidia.com> <20240206173631.2310255-1-dsosnowski@nvidia.com> <13882742.RDIVbhacDa@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <13882742.RDIVbhacDa@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0179.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6040:EE_ X-MS-Office365-Filtering-Correlation-Id: 95c32c44-0f61-489c-6ea0-08dc2777ccba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UDpbzGLeaGHJ+Un8OoYJC+StusFsq9kUtplVXnsdVIG5sGMMKtuHnGQAqLoRicFiLXjRXHT5kGgKFLVeOYqKTA0xL+d4CFP431sHlvFnx8OJSH9KG98aq8sO8RHBgmSxz7rQsgechvXJZTA1LL/chufpZo+92CUD8G64skOMWb7Shqjju8mcTZ+cZEUu/ir9bcmC0Dmx7hHfTXCfqSTx79kNF0zHfLpiQf588wy2ZRO9nmA0af/kw1sVaCNemAQs7UN/ePGBMQ6Iqkm5IEeTguDw+n9WaE77Jc5HGM06Obtb4658ZwxsG/lxO/ZbNeIvtP4eSUoPezifndxdcFqRi3fCIuQLV+Pj5mzWoIY4GmskTrcVWX9JsXLt+YGa8umIs9+HYsx6CxfvrCfGIZOxxvd2t10/HRbL7L4Zd4NAY5NzYPONIUOITHHqaEVnWTHYXvCtqqbSTnqKGFvlVVHcwtwcubryVAMQleFM7SLGfxTMtQzazm3s1Prqy6Zy3BKrcVDLbuGI8wa0ReqYyXc6Ac7e7tJdeIcASAFUvbv+VnluYjRplfOKoMUPZithPzNQ3Lyd4TFmazJH4qoOnqdYbjoO/HU6YIEylnd8QEr5uzxZXoQTmjOd/w4JJXPO/lNL0eI7Cj1EiOzim00yeSs0Rw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(346002)(136003)(376002)(366004)(230922051799003)(64100799003)(186009)(1800799012)(451199024)(31686004)(83380400001)(31696002)(36756003)(41300700001)(86362001)(66946007)(44832011)(8676002)(478600001)(38100700002)(2616005)(66556008)(316002)(26005)(6512007)(6666004)(54906003)(53546011)(2906002)(110136005)(6486002)(4326008)(66476007)(8936002)(5660300002)(6506007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bE9tQjVjVHRUN3FqY09KKzlLK1c1MVk1WlpYOS9qcVZsc3Z1eGtLclA2NXB2?= =?utf-8?B?eHQvT0RneTVDamp0bm1qSlBxRkJxazhiYzNaZGM5Vy9vNTk4RStmTXRtYTZC?= =?utf-8?B?RnovR1dWTnk3M1NEM1RJYy96c2FuaXhoZWthdyt5UzFNcmVpaHMzNXE2WTFh?= =?utf-8?B?cmhtUEo5ZzFBSUxyQTdlQ0t0eU1nYStxUDhwODV0NTF3WjRBcUZwTTNkaFY0?= =?utf-8?B?RDRQSzNFUFlyZ09mK1NMbUtTa2FFMXkvUmZ1OWZrV2cwMmxwTkVXS3BQVWRq?= =?utf-8?B?eTNUZEpNeWdzQ2tLRm1HbmptTDV4bWVPVUJmdUtKZHdOZmZoU0N1eklibVJW?= =?utf-8?B?VFl6Snl3QWx1Mkw2VTlsYTFGSFJZdVhadTljTFk5dEtsUDBVV2ExdnpVajVh?= =?utf-8?B?aWJZTHZHb3ZCMk4rOXg3ekFCM0NpdEVsd2V2TWVKdWNGNVZwTmw5MmdMSVd2?= =?utf-8?B?M2ZpR2lpMktrc1hBQ01PeHA2c3Bza3hjTzYzNU9RWHBLeUhlT29BeExLUG0w?= =?utf-8?B?WVVtbXd1cHo1M1M2QXdvVzgwVzYzODJOcTIwSTRYYm9tZWRhMVlFUUFyM2xG?= =?utf-8?B?c0o5Sml4ZFBON0xiK3kzMXltNThUZUZpL0dHSzA2am91QjRmS0lwRHRIK2Rw?= =?utf-8?B?Vnc5K2VSZkZzVFNJUUZoN0w1Q0ZEVWhSMkFsbmZ3WVVVdjQwYk9yRHhUS1Iv?= =?utf-8?B?SjJoNllLa0NOUExndmUrdjh5TmN5d1RaMFZ3TXRwdzM3YmlTNmIvZGNYNEI4?= =?utf-8?B?VkNVRkwxVGJGZ2piNXM2UllPK1NRUGQvMjZHbW5rdWp0cDFMUUpRaHpDNjA5?= =?utf-8?B?Y0tJekpmNmQ4d1JkWU5TbVM3VURPN0J1R3V6K1l2MC9SVElLbk9hbFVpS3g3?= =?utf-8?B?NWlDbmduTlNudVFrNlIyejRJU0orNGovQ3ZFc0xIVytsQnllVlJRQmJ2a3V4?= =?utf-8?B?aDI3ZjZzV3VXQjJRSXg4QmJQV1A1ZTFGcHUxd2R3OFhTeGR6bHkrUHZSLzFV?= =?utf-8?B?c3B0VHdJYkFhaTdBMStzRjJKWGZWYkh5ZzFPUEN3cFVWcXh4SDdzNUtHVmFH?= =?utf-8?B?SUZ6WVRqQ3p5cjh3ZzByOUR4eS9HWUZmMHIzcnlyQ1pZUWpnM0hrMHAvMkpw?= =?utf-8?B?cUp6dkN2RU5Lak1ZQkhqdDNCbzI0ZFVOeURrcmI1NUJWOTFpNnRkMktZNXNB?= =?utf-8?B?aUI3bnpFSVVTSmkwT0ZBT3VPcGZXTEVEOTRVVE55TkhTc1hzSnVLc3hIc2lC?= =?utf-8?B?bkV1U0pmUzM3U0E3WGc5WW50OS9NZGlzcVZwbUhjZHpjS296V2JuenhtZG5m?= =?utf-8?B?bFFGZFhSWFRTcm94Q2lnM09tSDR3TU5DaUZiclp3UElablZxQmJxK3JkS2N6?= =?utf-8?B?a2k4K0JoMks5NGJBdjhwaWI0YmE0M05rc1FlOUZ4WXM4WDh0d1RvT3FZUmVU?= =?utf-8?B?Y3RZM1pKMTh4QS9aTWxocTllV3NVaERJbXVCcjVqQWcwYnBpbS84OG13ZW5y?= =?utf-8?B?SXV2bVpJZ2VxMXlsc3lUd2RmMm5lc0lsY2hFMkJiQlBFbDZPQ040bUo1TnR3?= =?utf-8?B?cTVtM0FJcjBsOG5jQUNrOHZhMXF4UjFuYTV3TWlTNGlHVjJNWlNDOHZ2blQv?= =?utf-8?B?aHVKRVNuNm8vT1RJNFYvc0lqTEhmWlY4NVp0cGJjYjFPMmJSQ2trNjJ2NTZH?= =?utf-8?B?VG9HZWNrWGpiY2wzS2VuSGwwT2JJSkJRT1ZvQnVvQktYcC92N1lOQnlUVzNW?= =?utf-8?B?dHJOT0RYL3lIdk5icGpOMFNLUXBwWFlMUnpxWWJlZ2l1dnlhTUFjYklJRlAx?= =?utf-8?B?SS9LbytUT1pxaHd5S3pHMSsrL1VudjJxSGE3Q05FenFIa2xmMWhPeTJkeHIx?= =?utf-8?B?ejluZFFtOG1lbEluVWh3aEhvZkJxN0NyYmE4bUhKb2RMMDM1WjYrYVRiSE40?= =?utf-8?B?c0x5Q0Q4OWZPT1VTekNiY0NQa1I0d3Z0dWdKT1NzVFNmcUNMRjYxWDBPdDVZ?= =?utf-8?B?Z3k0VUJ1RnE3ZWtHMlBVSFkvb09HbStZUGFwODhXRGdRREZFN0puRGVQbVN2?= =?utf-8?B?Q0Q5SFRFeFdIVkNyZVpMMXdBSWlzdXBWQ205MXEzSkdjR0pZQ2haTGwyazdG?= =?utf-8?Q?CqLyTZz8SQHMTtHvrzaP4r0VN?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95c32c44-0f61-489c-6ea0-08dc2777ccba X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 00:57:47.1021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xsuOa0XZ1LuiwykdbcHQxujlSQ8G2DAEgKJEamv4BknOO9Jtn4i3STc4H41gTR2M X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6040 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/6/2024 10:21 PM, Thomas Monjalon wrote: > 06/02/2024 18:36, Dariusz Sosnowski: >> --- a/doc/guides/nics/build_and_test.rst >> +++ b/doc/guides/nics/build_and_test.rst >> +- ``RTE_FLOW_DEBUG`` (default **disabled**; enabled automatically on debug builds) >> + >> + Build with debug code in asynchronous flow APIs. >> + >> .. Note:: >> >> - The ethdev library use above options to wrap debug code to trace invalid parameters >> + The ethdev library uses above options to wrap debug code to trace invalid parameters >> on data path APIs, so performance downgrade is expected when enabling those options. >> - Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path. >> + Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path >> + and in asynchronous flow APIs implementation. > > Good > >> --- a/doc/guides/rel_notes/release_24_03.rst >> +++ b/doc/guides/rel_notes/release_24_03.rst >> +* ethdev: PMDs implementing asynchronous flow operations are required to provide relevant functions >> + implementation through ``rte_flow_fp_ops`` struct, instead of ``rte_flow_ops`` struct. >> + Pointer to device-dependent ``rte_flow_fp_ops`` should be provided to ``rte_eth_dev.flow_fp_ops``. > > That's a change only for the driver. > If there is no change for the application, it should not appear in the release notes. > BTW, API means Application Programming Interface :) > >> + This change applies to the following API functions: >> + >> + * ``rte_flow_async_create`` >> + * ``rte_flow_async_create_by_index`` >> + * ``rte_flow_async_actions_update`` >> + * ``rte_flow_async_destroy`` >> + * ``rte_flow_push`` >> + * ``rte_flow_pull`` >> + * ``rte_flow_async_action_handle_create`` >> + * ``rte_flow_async_action_handle_destroy`` >> + * ``rte_flow_async_action_handle_update`` >> + * ``rte_flow_async_action_handle_query`` >> + * ``rte_flow_async_action_handle_query_update`` >> + * ``rte_flow_async_action_list_handle_create`` >> + * ``rte_flow_async_action_list_handle_destroy`` >> + * ``rte_flow_async_action_list_handle_query_update`` >> + >> +* ethdev: Removed the following fields from ``rte_flow_ops`` struct: >> + >> + * ``async_create`` >> + * ``async_create_by_index`` >> + * ``async_actions_update`` >> + * ``async_destroy`` >> + * ``push`` >> + * ``pull`` >> + * ``async_action_handle_create`` >> + * ``async_action_handle_destroy`` >> + * ``async_action_handle_update`` >> + * ``async_action_handle_query`` >> + * ``async_action_handle_query_update`` >> + * ``async_action_list_handle_create`` >> + * ``async_action_list_handle_destroy`` >> + * ``async_action_list_handle_query_update`` > > [...] >> --- a/lib/ethdev/ethdev_driver.h >> +++ b/lib/ethdev/ethdev_driver.h >> @@ -71,6 +71,10 @@ struct rte_eth_dev { >> struct rte_eth_dev_data *data; >> void *process_private; /**< Pointer to per-process device data */ >> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ >> + /** >> + * Fast path flow API functions exported by PMD. >> + */ > > This comment may be on one single line. > >> + const struct rte_flow_fp_ops *flow_fp_ops; >> struct rte_device *device; /**< Backing device */ >> struct rte_intr_handle *intr_handle; /**< Device interrupt handle */ > >> --- a/lib/ethdev/meson.build >> +++ b/lib/ethdev/meson.build >> +if get_option('buildtype').contains('debug') >> + cflags += ['-DRTE_FLOW_DEBUG'] >> +endif > > This looks OK. > > Acked-by: Thomas Monjalon > > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.