From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA4E7A055D; Fri, 10 Jun 2022 02:01:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96C8F4069C; Fri, 10 Jun 2022 02:01:59 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 8331C40689 for ; Fri, 10 Jun 2022 02:01:58 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LK1Jf1h9MzRhZ5; Fri, 10 Jun 2022 07:58:42 +0800 (CST) Received: from [127.0.0.1] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 10 Jun 2022 08:01:55 +0800 Subject: Re: [PATCH v6] ethdev: introduce available Rx descriptors threshold To: Thomas Monjalon , Kalesh A P CC: Andrew Rybchenko , Spike Du , , Xiaoyun Li , Aman Singh , Yuying Zhang , Ferruh Yigit , Ray Kinsella References: <20220607125942.241379-1-spiked@nvidia.com> <22668814.6Emhk5qWAg@thomas> <8994800.rMLUfLXkoz@thomas> From: fengchengwen Message-ID: <2b22236b-f959-51d6-0590-6203e71ba2e2@huawei.com> Date: Fri, 10 Jun 2022 08:01:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <8994800.rMLUfLXkoz@thomas> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, On 2022/6/9 15:05, Thomas Monjalon wrote: > 09/06/2022 02:17, fengchengwen: >> Hi Thomas, >> >> Could it possible accept the patch ' [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events' >> which was delayed by ABI exceptions like this patch ? > > I suppose you refer to this explanation: Yes > > +; Ignore ethdev event enum update > +; because new event cannot be received if not registered > > That's true we discussed in the past that it should have no effect > on applications compiled with an old version of DPDK. > >> PS: I noticed RC-1 was released just now and there may be no window left, but I think since this patch can be an >> exception, why not that patch ? > > As far as I remember, the reset and recovery events patch > have other comments to address before it can be accepted. Yes, but the ABI exceptions is the primary cause of blockage. There's two weeks left to fully discuss I think. We have product requirements for this feature ("device reset and recovery events"), So: Hi kalesh-anakkur, Could you please send a new version about it ? If not, do you mind if I re-develop over it ? > > > > . >