From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0616A053A; Wed, 5 Aug 2020 11:28:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D07E41C042; Wed, 5 Aug 2020 11:28:30 +0200 (CEST) Received: from qrelay147.mxroute.com (qrelay147.mxroute.com [172.82.139.147]) by dpdk.org (Postfix) with ESMTP id 0218C37B4 for ; Wed, 5 Aug 2020 11:28:28 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay147.mxroute.com (ZoneMTA) with ESMTPA id 173bdf34d5a0002bdc.002 for ; Wed, 05 Aug 2020 09:28:25 +0000 X-Zone-Loop: 75045682ff2fe4a88b4009a0c51337ddba4a318fa4f2 X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 3927860047; Wed, 5 Aug 2020 09:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rWyGaQV/mH3U2HlvZ6JJPsO1JMHkIt2um5ONEJzIEM8=; b=Y3YRFhZV7KqK/SvdOulVrjJX5H vaaMz5aLoaH0HZ5JoL1JihGYtty8sOvdY15C3DxnjcjxKgvWO91b0M1lDHjTGc141iuup1lw5K/as MK2VtjtJz1KukgK+/SIJ6rSaKADaNNKcuzfKiQlSFcI2mqHHB0Dd0+Nx1Bj6h4hyf6ewsEoheCArz q9EFd5q5zzHuHHYqEQhh2erCtCfbm0uFYFLteAuV6o3nTzmpdU+gK4I2Lp4TcSR7Ob1GgujK2nwPm 60KCZRX8UUM55FTd8xmn3UYNRUBWAVofs9ESYlEbeew8R0fsX2/4Eix93g/KcNhnQupCinbYnCo9f iTyCmOPg==; To: Thomas Monjalon , dev@dpdk.org Cc: olivier.matz@6wind.com, Neil Horman , John McNamara , Marko Kovacevic References: <20200731160349.3198317-1-thomas@monjalon.net> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <2b245241-5e09-49c4-daf2-79803788615d@ashroe.eu> Date: Wed, 5 Aug 2020 10:28:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200731160349.3198317-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 31/07/2020 17:03, Thomas Monjalon wrote: > In order to prepare for adding more features requiring more space in mbuf, > some static fields must become dynamic. > Some small layout changes may have performance benefits as well. > > The deprecation notice for atomic refcount is moved and reworded > to fit below the layout deprecation. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/deprecation.rst | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index ea4cfa7a48..015c386c76 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -67,6 +67,26 @@ Deprecation Notices > us extending existing enum/define. > One solution can be using a fixed size array instead of ``.*MAX.*`` value. > > +* mbuf: Some fields will be converted to dynamic API in DPDK 20.11 > + in order to reserve more space for the dynamic fields. > + The following static fields will be moved as dynamic: > + > + - ``timestamp`` > + - ``userdata`` / ``udata64`` > + - ``seqn`` > + > + As a consequence, the layout of the ``struct rte_mbuf`` will be re-arranged, > + avoiding impact on vectorized implementation of the driver datapaths, > + while evaluating performance gains of a better use of the first cache line. > + > + The deprecated unioned fields ``buf_physaddr`` and ``refcnt_atomic`` > + (as explained below) will be removed in DPDK 20.11. So what does anyone using these fields do - except panic perhaps. Can we include a reference to the DPDK Userspace presentation, in advance of the documentation supporting the dynamic mbuf. To prepare people for what is to come ... https://www.youtube.com/watch?v=Ttl6MlhmzWY > + > +* mbuf: ``refcnt_atomic`` member in structures ``rte_mbuf`` and > + ``rte_mbuf_ext_shared_info`` is of type ``rte_atomic16_t``. > + Due to adoption of C11 atomic builtins, the field ``refcnt_atomic`` > + will be replaced with ``refcnt`` of type ``uint16_t`` in DPDK 20.11. > + > * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible > will be done in 20.11. > Currently the ``struct eth_dev_ops`` struct is accessible by the application > @@ -132,12 +152,6 @@ Deprecation Notices > in "rte_sched.h". These changes are aligned to improvements suggested in the > RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html. > > -* mbuf: ``refcnt_atomic`` member in structures ``rte_mbuf`` and > - ``rte_mbuf_ext_shared_info`` is of type ``rte_atomic16_t``. Due to adoption > - of C11 atomic builtins it will be of type ``uint16_t``. ``refcnt_atomic`` > - will be removed in 20.11. It will be replaced with ``refcnt`` of type > - ``uint16_t``. > - > * metrics: The function ``rte_metrics_init`` will have a non-void return > in order to notify errors instead of calling ``rte_exit``. > >